[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304494#comment-17304494 ] ASF subversion and git services commented on ARTEMIS-2108: -- Commit 8d848f4615a6ea81002eaf638e93826c810b0884 in activemq-artemis's branch refs/heads/master from gtully [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8d848f4 ] ARTEMIS-3188 / ARTEMIS-2108 Fixing StackOverFlow over bindings This fix was done in collaboration with Gary Tully > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.6.4, 2.7.0 > > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686800#comment-16686800 ] ASF subversion and git services commented on ARTEMIS-2108: -- Commit 773721f7b028754c39e441aa9372dc614f31ce47 in activemq-artemis's branch refs/heads/2.6.x from Justin Bertram [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=773721f ] ARTEMIS-2108 fix another potential StackOverflow (cherry picked from commit f4396da9fd9f7ecc7d9c0b02118d1eb1b76af523) > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.4 > > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685848#comment-16685848 ] ASF GitHub Bot commented on ARTEMIS-2108: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2417 > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.4 > > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685847#comment-16685847 ] ASF subversion and git services commented on ARTEMIS-2108: -- Commit f4396da9fd9f7ecc7d9c0b02118d1eb1b76af523 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f4396da ] ARTEMIS-2108 fix another potential StackOverflow > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.4 > > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675439#comment-16675439 ] ASF GitHub Bot commented on ARTEMIS-2108: - GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2417 ARTEMIS-2108 fix another potential StackOverflow You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2108 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2417.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2417 commit bb9cdd4bdb6fe789afc24d96dbf61985c69f0e3e Author: Justin Bertram Date: 2018-11-05T16:42:32Z ARTEMIS-2108 fix another potential StackOverflow > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.4 > > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[
https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651604#comment-16651604
]
ASF GitHub Bot commented on ARTEMIS-2108:
-
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2345#discussion_r225517433
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/RemoteBindingWithoutLoadBalancingTest.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.cluster.distribution;
+
+import
org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
+import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
+import org.junit.Before;
+import org.junit.Test;
+
+public class RemoteBindingWithoutLoadBalancingTest extends ClusterTestBase
{
+
+ private static final IntegrationTestLogger log =
IntegrationTestLogger.LOGGER;
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ super.setUp();
+
+ setupServers();
+ }
+
+ protected boolean isNetty() {
+ return false;
+ }
+
+ /**
+* It's possible that when a cluster has disabled message load
balancing then a message
+* sent to a node that only has a corresponding remote queue binding
will trigger a
+* stack overflow.
+*/
+ @Test
+ public void testStackOverflow() throws Exception {
+ setupCluster();
+
+ startServers();
+
+ setupSessionFactory(0, isNetty());
+ setupSessionFactory(1, isNetty());
+
+ createQueue(0, "queues.testaddress", "queue0", null, false);
+
+ waitForBindings(0, "queues.testaddress", 1, 0, true);
+
+ waitForBindings(1, "queues.testaddress", 1, 0, false);
+
+ send(1, "queues.testaddress", 1, false, null);
--- End diff --
@michalxo, my guess is that you're sending the message with a JMS client.
The test is using the core API which doesn't auto-create queues.
> Potential StackOverflowError when load balancing disabled
> -
>
> Key: ARTEMIS-2108
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2108
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> It's possible that when a cluster has disabled message load balancing then a
> message sent to a node that only has a corresponding remote queue binding
> will trigger a stack overflow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[
https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651418#comment-16651418
]
ASF GitHub Bot commented on ARTEMIS-2108:
-
Github user michalxo commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2345#discussion_r225473981
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/RemoteBindingWithoutLoadBalancingTest.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.cluster.distribution;
+
+import
org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
+import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
+import org.junit.Before;
+import org.junit.Test;
+
+public class RemoteBindingWithoutLoadBalancingTest extends ClusterTestBase
{
+
+ private static final IntegrationTestLogger log =
IntegrationTestLogger.LOGGER;
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ super.setUp();
+
+ setupServers();
+ }
+
+ protected boolean isNetty() {
+ return false;
+ }
+
+ /**
+* It's possible that when a cluster has disabled message load
balancing then a message
+* sent to a node that only has a corresponding remote queue binding
will trigger a
+* stack overflow.
+*/
+ @Test
+ public void testStackOverflow() throws Exception {
+ setupCluster();
+
+ startServers();
+
+ setupSessionFactory(0, isNetty());
+ setupSessionFactory(1, isNetty());
+
+ createQueue(0, "queues.testaddress", "queue0", null, false);
+
+ waitForBindings(0, "queues.testaddress", 1, 0, true);
+
+ waitForBindings(1, "queues.testaddress", 1, 0, false);
+
+ send(1, "queues.testaddress", 1, false, null);
--- End diff --
Is this really reproducing the issue @jbertram ?
In my testing, when I send message to broker2, the queue is auto-created,
so previously only remote bindings will change to local bindings, OR
message is refused, due to not-existing queue.
> Potential StackOverflowError when load balancing disabled
> -
>
> Key: ARTEMIS-2108
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2108
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> It's possible that when a cluster has disabled message load balancing then a
> message sent to a node that only has a corresponding remote queue binding
> will trigger a stack overflow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645651#comment-16645651 ] ASF GitHub Bot commented on ARTEMIS-2108: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2345 > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2108) Potential StackOverflowError when load balancing disabled
[ https://issues.apache.org/jira/browse/ARTEMIS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637662#comment-16637662 ] ASF GitHub Bot commented on ARTEMIS-2108: - GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2345 ARTEMIS-2108 Potential StackOverflowError when load balancing disabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2108 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2345 commit d9e1a7e007aefe79416f44593a71ce0694bcdc9e Author: Justin Bertram Date: 2018-10-04T00:18:27Z ARTEMIS-2108 Potential StackOverflowError when load balancing disabled > Potential StackOverflowError when load balancing disabled > - > > Key: ARTEMIS-2108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2108 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > It's possible that when a cluster has disabled message load balancing then a > message sent to a node that only has a corresponding remote queue binding > will trigger a stack overflow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
