[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011846#comment-15011846
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


Github user jbertram commented on the pull request:

https://github.com/apache/activemq-artemis/pull/208#issuecomment-157844491
  
@themerius, I'm not sure if @clebertsuconic is done with the test changes, 
but in any case you can add @jscheid as a git remote and cherry-pick his commit 
into your own branch for testing purposes.


> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011842#comment-15011842
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


Github user themerius commented on the pull request:

https://github.com/apache/activemq-artemis/pull/208#issuecomment-157843870
  
Would be nice if this fix goes into the next release of Artemis! Or into 
the branch, so I can test it.


> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011949#comment-15011949
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


Github user jscheid closed the pull request at:

https://github.com/apache/activemq-artemis/pull/208


> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006748#comment-15006748
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


Github user jscheid commented on the pull request:

https://github.com/apache/activemq-artemis/pull/208#issuecomment-157060182
  
Hi @clebertsuconic, is there anything else I can do to move this forward?



> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969589#comment-14969589
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/208#issuecomment-150313180
  
there is some tests changes I have to do for this...

I will keep this open for now


> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-10-21 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967441#comment-14967441
 ] 

clebert suconic commented on ARTEMIS-239:
-

A chat I had about this with Julien:

// possible fix:

julian37: make StompConnection.checkDataReceived return always true
[12:49pm] julian37: document the fact that connectionTTL doesn't apply to STOMP 
connections
[12:49pm] julian37: done
[12:49pm] julian37: ScheduledExecutor is an optimization and a separate issue 
I'd say

> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-10-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967605#comment-14967605
 ] 

ASF GitHub Bot commented on ARTEMIS-239:


GitHub user jscheid opened a pull request:

https://github.com/apache/activemq-artemis/pull/208

ARTEMIS-239 disable ttl for STOMP connections

Leave dead connection detection up to the heart-beating logic.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/waysact/activemq-artemis 
ARTEMIS-239-disable-stomp-ttl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #208


commit 17cebce5eded62360045788f86e4b940cf062455
Author: Julian Scheid 
Date:   2015-10-21T18:18:50Z

ARTEMIS-239 disable ttl for STOMP connections

Leave dead connection detection up to the heart-beating logic.




> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.1.1
>
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-239) Verify Stomp Heart-beating against StompJMS

2015-10-01 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940723#comment-14940723
 ] 

clebert suconic commented on ARTEMIS-239:
-

https://stomp.github.io/stomp-specification-1.2.html#Heart-beating

> Verify Stomp Heart-beating against StompJMS
> ---
>
> Key: ARTEMIS-239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-239
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Assignee: clebert suconic
>
> https://github.com/fusesource/stompjms/issues/26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)