[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120047#comment-15120047
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/350


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120044#comment-15120044
 ] 

ASF subversion and git services commented on ARTEMIS-357:
-

Commit ff95b216ef2a26d8487d3119e7e5f575df5210c8 in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=ff95b21 ]

ARTEMIS-357 test for client buffer mod


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120045#comment-15120045
 ] 

ASF subversion and git services commented on ARTEMIS-357:
-

Commit 4d239ac80355a9eabec99683b11e1c6c308e39c8 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4d239ac ]

ARTEMIS-357 fixing issue with Messages Growing after JMS sends (after my last 
change on ARTEMIS-357)


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120046#comment-15120046
 ] 

ASF subversion and git services commented on ARTEMIS-357:
-

Commit 4d239ac80355a9eabec99683b11e1c6c308e39c8 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4d239ac ]

ARTEMIS-357 fixing issue with Messages Growing after JMS sends (after my last 
change on ARTEMIS-357)


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118592#comment-15118592
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/350

ARTEMIS-357 fixing an issue created by my previous commit on this

@jbertram  helped figuring out the growing buffer issue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #350


commit 4c22138f5b85ea36e546058bfea02788ab1cf95f
Author: jbertram 
Date:   2016-01-26T18:51:45Z

ARTEMIS-357 test for client buffer mod

commit eb6e042c1c35e5f7de10aa03dd29b45f624e636a
Author: Clebert Suconic 
Date:   2016-01-27T03:30:24Z

ARTEMIS-357 fixing issue with Messages Growing after JMS sends (after my 
last change on ARTEMIS-357)




> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118621#comment-15118621
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/350#issuecomment-175383216
  
Tests are broken though.. will have to look tomorrow


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118600#comment-15118600
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


Github user jbertram commented on the pull request:

https://github.com/apache/activemq-artemis/pull/350#issuecomment-175378662
  
Nice work, @clebertsuconic. Glad we squashed this bug.


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118635#comment-15118635
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/350#issuecomment-175393266
  
fixed the tests


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113975#comment-15113975
 ] 

ASF subversion and git services commented on ARTEMIS-357:
-

Commit 7957f574f69e8ac037e3c7f187e2fca3ef9c05ae in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=7957f57 ]

ARTEMIS-357 No need to check copy any longer


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113596#comment-15113596
 ] 

ASF subversion and git services commented on ARTEMIS-357:
-

Commit f5ec15216e15e1fe26e1db2934abda928da7a55f in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f5ec152 ]

ARTEMIS-357 Avoiding possible races on encoding messages

https://issues.apache.org/jira/browse/ARTEMIS-357


> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[clebert suconic (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113582#comment-15113582
 ] 

clebert suconic commented on ARTEMIS-357:
-

this was a discussion on Wildfly: https://issues.jboss.org/browse/WFLY-5480

the interesting thing is that ActiveMQ users were part of the discussion, so 
this discussion on wildfly is very relevant to this JIRA.

> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-357) Possible encoding race over many destinations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113590#comment-15113590
 ] 

ASF GitHub Bot commented on ARTEMIS-357:


GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/337

ARTEMIS-357 Avoiding possible races on encoding messages

https://issues.apache.org/jira/browse/ARTEMIS-357

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #337


commit d87700c95228b014e975b5f1506bb0e8f5a3eab5
Author: Clebert Suconic 
Date:   2016-01-23T05:06:05Z

ARTEMIS-357 Avoiding possible races on encoding messages

https://issues.apache.org/jira/browse/ARTEMIS-357




> Possible encoding race over many destinations
> -
>
> Key: ARTEMIS-357
> URL: https://issues.apache.org/jira/browse/ARTEMIS-357
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
> Fix For: 1.3.0
>
>
> There seems to be a possibility of a race on messageImpl:encodeToBuffer
> The current implementation try to reuse the buffer sent on producer on an 
> optimization that was used when we were on Netty Blocking.
> We have been reported of cases where the client can't decode the message:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)