[jira] [Commented] (ARTEMIS-361) Improve encoding on ServerLocator's properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116168#comment-15116168
 ] 

ASF GitHub Bot commented on ARTEMIS-361:


GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/345

ARTEMIS-361 Fixing URI Encoding of Connection Factory properties

https://issues.apache.org/jira/browse/ARTEMIS-361

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #345


commit e8c3bfa11f9bd6f598d85592d7449c772ea4f6ff
Author: Clebert Suconic 
Date:   2016-01-25T22:02:24Z

ARTEMIS-361 Fixing URI Encoding of Connection Factory properties

https://issues.apache.org/jira/browse/ARTEMIS-361




> Improve encoding on ServerLocator's properties
> --
>
> Key: ARTEMIS-361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-361
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.3.0
>
>
> If you add any weird encoding on properties (such as % and space) the 
> ConnectionFactory serialization might be broken due to these encodings.
> We should be using URLEncoder.encode(STRING, "UTF-8") and 
> URLDecoder.decode(STRING, "UTF-8") for all the Query properties on the 
> URISchema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-361) Improve encoding on ServerLocator's properties

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116240#comment-15116240
 ] 

ASF subversion and git services commented on ARTEMIS-361:
-

Commit e5652d39bccaddb0d75f78026eea016243276f56 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e5652d3 ]

ARTEMIS-361 Fixing URI Encoding of Connection Factory properties

https://issues.apache.org/jira/browse/ARTEMIS-361


> Improve encoding on ServerLocator's properties
> --
>
> Key: ARTEMIS-361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-361
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.3.0
>
>
> If you add any weird encoding on properties (such as % and space) the 
> ConnectionFactory serialization might be broken due to these encodings.
> We should be using URLEncoder.encode(STRING, "UTF-8") and 
> URLDecoder.decode(STRING, "UTF-8") for all the Query properties on the 
> URISchema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-361) Improve encoding on ServerLocator's properties

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116241#comment-15116241
 ] 

ASF subversion and git services commented on ARTEMIS-361:
-

Commit e5652d39bccaddb0d75f78026eea016243276f56 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e5652d3 ]

ARTEMIS-361 Fixing URI Encoding of Connection Factory properties

https://issues.apache.org/jira/browse/ARTEMIS-361


> Improve encoding on ServerLocator's properties
> --
>
> Key: ARTEMIS-361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-361
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 1.3.0
>
>
> If you add any weird encoding on properties (such as % and space) the 
> ConnectionFactory serialization might be broken due to these encodings.
> We should be using URLEncoder.encode(STRING, "UTF-8") and 
> URLDecoder.decode(STRING, "UTF-8") for all the Query properties on the 
> URISchema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)