[jira] [Commented] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807364#comment-17807364 ] ASF subversion and git services commented on ARTEMIS-4558: -- Commit 1fef332bea6909bd33568232c990f85bae3058e8 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1fef332bea ] ARTEMIS-4558 Improving test assertions on IdempotentMirrored Ack Test > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806989#comment-17806989 ] ASF subversion and git services commented on ARTEMIS-4558: -- Commit c6a6e036a436eeb6fbce548a570c86767fb4ebe0 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c6a6e036a4 ] ARTEMIS-4558 Transactional support for mirroring - Async commit * async here meaning the recording of the commit record is not doing a sync on the storage. This is useful for internal operations where we don't need an immediate sync on the journal storage. - Wired notification * I need finer control on a afterWired (to the storage) and before the completions, so I can plug the sync context on mirror right before the commit is called. > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806991#comment-17806991 ] ASF subversion and git services commented on ARTEMIS-4558: -- Commit bc7e4639e0a4665c106f336fb837c33d2cbcd361 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=bc7e4639e0 ] ARTEMIS-4558 Idempotent Mirrored ACKs Mirror acks should be performed atomically with the storage of the source ACK. Both the send of the ack and the recording of the ack should be part of the same transaction (in case of transactional). We are also adding support on transactions for an afterWired callback for the proper plug of OperationContext sync. > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
