[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881484#comment-15881484 ] Matt Pavlovich commented on ARTEMIS-873: My $0.02 is that K, M, G values should be used for 'bytes' fields. If there is a desire to have shortened form for other values, such as time, those should have their units specified.. Using "k" doesn't make a lot of sense when you start talking units other than seconds .. 3K hours, 4M days, etc. For 'time' (or other non-byte) fields an optional units attribute should be included. timeoutInterval="3000" timeoutInterval="3" timeoutIntervalUnits="Seconds" maxMessageSize="3KB" maxMessageSize="5MB" I believe the MB vs MiB discussion is a brain drain on users and we should be practical about it. Use 1024 and move on. > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.2 >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.3 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881407#comment-15881407 ] clebert suconic commented on ARTEMIS-873: - I'm starting to agree with Jeff on this. What about timeouts... if you define 3K Seconds it should be 3000 seconds and not 3 * 1024 seconds. What should we do.. K should mean 1024 on bytes, and 1000 on other values? it sounds horrible that way. Time for a DISCUSS thread? > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.2 >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.3 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861505#comment-15861505 ] Justin Bertram commented on ARTEMIS-873: [~jmesnil], I considered this when I implemented it, but the main impetus for this was parity with 5.x which uses the 1024 multiple. I didn't want a disparity in actual behavior given the same abbreviation. That said, if the community agrees with your suggestion I'm happy to implement it. Would you mind raising a \[DISCUSS\] thread on the user mailing list and making your proposal? > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.2 >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.3 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861497#comment-15861497 ] Jeff Mesnil commented on ARTEMIS-873: - (and of course my comment uses the wrong values :) 1GB = 1000^3 bytes while 1GiB = 1024^3 bytes > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.2 >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.3 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861493#comment-15861493 ] Jeff Mesnil commented on ARTEMIS-873: - I think this (great) RFE should be updated to fix the names and amounts of the multiples. In the code 1GB is set to 1 * 1024 * 1024 but that is wrong. 1GB is 1 * 1000 * 1000 bytes. The correct binary notation would be 1GiB (see https://en.wikipedia.org/wiki/Gibibyte). I understand that most people use kB/MB/GB instead of KiB/MiB/GiB but Artemis should support both notations so that the amount will always be computed correctly. > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.2 >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.3 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830150#comment-15830150 ] ASF subversion and git services commented on ARTEMIS-873: - Commit 9b3cc8c3291b1ca2f2c4becb9c68e8a43f5022c0 in activemq-artemis's branch refs/heads/1.x from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9b3cc8c ] ARTEMIS-873 support byte notation in XML config (cherry picked from commit 113b28577c792a9fef5ac74abe6cd65bc08ffcf2) > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.x > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830105#comment-15830105 ] ASF subversion and git services commented on ARTEMIS-873: - Commit 113b28577c792a9fef5ac74abe6cd65bc08ffcf2 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=113b285 ] ARTEMIS-873 support byte notation in XML config > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos >Assignee: Justin Bertram > Fix For: 2.0.0, 1.5.x > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829198#comment-15829198 ] ASF GitHub Bot commented on ARTEMIS-873: GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/971 ARTEMIS-873 support byte notation in XML config You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-873 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/971.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #971 > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos > Fix For: 2.0.0 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733177#comment-15733177 ] Matt Pavlovich commented on ARTEMIS-873: I agree w/ Jiri. Consistency w/ 5.x would be handy in this case. Also, in addition, it'd be helpful to handle the inevitable white space: For example: "1 gb" "1GB" "1gB" > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos > Fix For: 1.6.0 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732442#comment-15732442 ] Jiri Danek commented on ARTEMIS-873: ActiveMQ 5.14 uses "gb, mb, kb" (case insensitive). For the sake of consistency, doing it the same way in Artemis may be slightly better. > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos > Fix For: 1.6.0 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml
[ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725743#comment-15725743 ] clebert suconic commented on ARTEMIS-873: - nice idea! > Use K,M,G notations on broker.xml > - > > Key: ARTEMIS-873 > URL: https://issues.apache.org/jira/browse/ARTEMIS-873 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Fábio Gomes dos Santos > Fix For: 1.6.0 > > > Many keys in broker.xml need the value in bytes. > To make this easy we can use 1G instead 1073741824. > It is a small feature but very useful > Example: > global-max-size only support the bytes notation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
