[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230882=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230882 ] ASF GitHub Bot logged work on ARTEMIS-2314: --- Author: ASF GitHub Bot Created on: 22/Apr/19 20:48 Start Date: 22/Apr/19 20:48 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2632: ARTEMIS-2314 Compatibility around FQQN URL: https://github.com/apache/activemq-artemis/pull/2632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 230882) Time Spent: 1h 50m (was: 1h 40m) > Broken backwards compatibility with core JMS FQQN consumer > -- > > Key: ARTEMIS-2314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2314 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > When auto-creation is *off* then older clients consuming messages from an > FQQN won't work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230875=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230875 ] ASF GitHub Bot logged work on ARTEMIS-2314: --- Author: ASF GitHub Bot Created on: 22/Apr/19 20:36 Start Date: 22/Apr/19 20:36 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2632: ARTEMIS-2314 Compatibility around FQQN URL: https://github.com/apache/activemq-artemis/pull/2632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 230875) Time Spent: 1h 40m (was: 1.5h) > Broken backwards compatibility with core JMS FQQN consumer > -- > > Key: ARTEMIS-2314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2314 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > When auto-creation is *off* then older clients consuming messages from an > FQQN won't work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230873=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230873 ] ASF GitHub Bot logged work on ARTEMIS-2314: --- Author: ASF GitHub Bot Created on: 22/Apr/19 20:30 Start Date: 22/Apr/19 20:30 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #2629: ARTEMIS-2314 broken compat with old core JMS FQQN consumer URL: https://github.com/apache/activemq-artemis/pull/2629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 230873) Time Spent: 1.5h (was: 1h 20m) > Broken backwards compatibility with core JMS FQQN consumer > -- > > Key: ARTEMIS-2314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2314 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > When auto-creation is *off* then older clients consuming messages from an > FQQN won't work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230759
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 16:03
Start Date: 22/Apr/19 16:03
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #2629: ARTEMIS-2314
broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277337047
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
That's expected since the client is producing to an FQQN as well as
consuming. Support for sending messages to an FQQN was added in 2.7.0.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230759)
Time Spent: 1h 20m (was: 1h 10m)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230753=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230753
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 15:56
Start Date: 22/Apr/19 15:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2629:
ARTEMIS-2314 broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277335136
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
any time you use 2.6.3, 2.4.0, 2.2.0 as the server, and SNAPSHOT as a
client, on any combination
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230753)
Time Spent: 1h (was: 50m)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230754=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230754
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 15:56
Start Date: 22/Apr/19 15:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2629:
ARTEMIS-2314 broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277335136
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
the test you wrote will fail any time you use 2.6.3, 2.4.0, 2.2.0 as the
server, and SNAPSHOT as a client, on any combination
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230754)
Time Spent: 1h 10m (was: 1h)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230752=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230752
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 15:52
Start Date: 22/Apr/19 15:52
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2629:
ARTEMIS-2314 broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277333994
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
I am sending a PR to your branch, the issue is using SNAPSHOT against any
older version, including 2.6.3.
I am not sure you need to test 2.6.3, testing a combinatory of 2.4.0,
SNAPSHOT, 2.10. 2.0 should be enough, unless there was anything specific that
was changed into 2.6.x and that would warrant a speicif test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230752)
Time Spent: 50m (was: 40m)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230735
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 15:17
Start Date: 22/Apr/19 15:17
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #2629: ARTEMIS-2314
broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277322458
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
I added some additional tests for 2.x clients.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230735)
Time Spent: 40m (was: 0.5h)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230729=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230729
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 15:01
Start Date: 22/Apr/19 15:01
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2629:
ARTEMIS-2314 broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277317503
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
You should also test against older versions, at least on 2.0 versions
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230729)
Time Spent: 0.5h (was: 20m)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[
https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=230728=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230728
]
ASF GitHub Bot logged work on ARTEMIS-2314:
---
Author: ASF GitHub Bot
Created on: 22/Apr/19 14:57
Start Date: 22/Apr/19 14:57
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2629:
ARTEMIS-2314 broken compat with old core JMS FQQN consumer
URL: https://github.com/apache/activemq-artemis/pull/2629#discussion_r277316069
##
File path:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/FQQNConsumerTest.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.activemq.artemis.tests.compatibility.base.ServerBase;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.SNAPSHOT;
+import static
org.apache.activemq.artemis.tests.compatibility.GroovyRun.TWO_SIX_THREE;
+
+@RunWith(Parameterized.class)
+public class FQQNConsumerTest extends ServerBase {
+
+ // this will ensure that all tests in this class are run twice,
+ // once with "true" passed to the class' constructor and once with "false"
+ @Parameterized.Parameters(name = "server={0}, producer={1}, consumer={2}")
+ public static Collection getParameters() {
+ // we don't need every single version ever released..
+ // if we keep testing current one against 2.4 and 1.4.. we are sure the
wire and API won't change over time
+ List combinations = new ArrayList<>();
+
+ combinations.add(new Object[]{SNAPSHOT, TWO_SIX_THREE, TWO_SIX_THREE});
Review comment:
why not test against older versions?
At least there's a copy & paste thing here, as the comment says you only
need to test against 2.4 and 1.4.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 230728)
Time Spent: 20m (was: 10m)
> Broken backwards compatibility with core JMS FQQN consumer
> --
>
> Key: ARTEMIS-2314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2314
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When auto-creation is *off* then older clients consuming messages from an
> FQQN won't work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2314) Broken backwards compatibility with core JMS FQQN consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2314?focusedWorklogId=229964=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229964 ] ASF GitHub Bot logged work on ARTEMIS-2314: --- Author: ASF GitHub Bot Created on: 19/Apr/19 00:25 Start Date: 19/Apr/19 00:25 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #2629: ARTEMIS-2314 broken compat with old core JMS FQQN consumer URL: https://github.com/apache/activemq-artemis/pull/2629 When auto-creation is off then older clients consuming messages from an FQQN won't work. This commit fixes that problem and adds a compatibility test to verify. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 229964) Time Spent: 10m Remaining Estimate: 0h > Broken backwards compatibility with core JMS FQQN consumer > -- > > Key: ARTEMIS-2314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2314 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When auto-creation is *off* then older clients consuming messages from an > FQQN won't work. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
