[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[ https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=310755=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310755 ] ASF GitHub Bot logged work on ARTEMIS-2480: --- Author: ASF GitHub Bot Created on: 11/Sep/19 15:51 Start Date: 11/Sep/19 15:51 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310755) Time Spent: 1h 20m (was: 1h 10m) > Reloading configuration can kill broker > --- > > Key: ARTEMIS-2480 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2480 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In some cases if undeploying a queue or address fails during restart then the > broker will die, we should log a warning and continue -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[ https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=310464=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310464 ] ASF GitHub Bot logged work on ARTEMIS-2480: --- Author: ASF GitHub Bot Created on: 11/Sep/19 10:23 Start Date: 11/Sep/19 10:23 Worklog Time Spent: 10m Work Description: andytaylor commented on issue #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831#issuecomment-530319715 feedback applied This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310464) Time Spent: 1h 10m (was: 1h) > Reloading configuration can kill broker > --- > > Key: ARTEMIS-2480 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2480 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In some cases if undeploying a queue or address fails during restart then the > broker will die, we should log a warning and continue -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[
https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309642=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309642
]
ASF GitHub Bot logged work on ARTEMIS-2480:
---
Author: ASF GitHub Bot
Created on: 10/Sep/19 09:02
Start Date: 10/Sep/19 09:02
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2831:
ARTEMIS-2480 - Reloading configuration can kill broker
URL: https://github.com/apache/activemq-artemis/pull/2831#discussion_r322629099
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##
@@ -3022,12 +3022,20 @@ private void
undeployAddressesAndQueueNotInConfiguration(Configuration configura
queue.deleteQueue(true);
}
ActiveMQServerLogger.LOGGER.undeployAddress(addressName);
-removeAddressInfo(addressName, null);
+try {
+ removeAddressInfo(addressName, null);
+} catch (Exception e) {
+
ActiveMQServerLogger.LOGGER.unableToUndeployAddress(addressName,
e.getMessage());
+}
} else if (addressSettings.getConfigDeleteQueues() ==
DeletionPolicy.FORCE) {
for (Queue queue : listConfiguredQueues(addressName)) {
if (!queuesInConfig.contains(queue.getName().toString())) {
ActiveMQServerLogger.LOGGER.undeployQueue(queue.getName());
- queue.deleteQueue(true);
+ try {
+ queue.deleteQueue(true);
Review comment:
this should logic should then also exist in line 3022 also.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 309642)
Time Spent: 50m (was: 40m)
> Reloading configuration can kill broker
> ---
>
> Key: ARTEMIS-2480
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2480
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In some cases if undeploying a queue or address fails during restart then the
> broker will die, we should log a warning and continue
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[ https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309643 ] ASF GitHub Bot logged work on ARTEMIS-2480: --- Author: ASF GitHub Bot Created on: 10/Sep/19 09:02 Start Date: 10/Sep/19 09:02 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831#issuecomment-529843657 test case? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309643) Time Spent: 1h (was: 50m) > Reloading configuration can kill broker > --- > > Key: ARTEMIS-2480 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2480 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In some cases if undeploying a queue or address fails during restart then the > broker will die, we should log a warning and continue -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[
https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309639=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309639
]
ASF GitHub Bot logged work on ARTEMIS-2480:
---
Author: ASF GitHub Bot
Created on: 10/Sep/19 09:00
Start Date: 10/Sep/19 09:00
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2831:
ARTEMIS-2480 - Reloading configuration can kill broker
URL: https://github.com/apache/activemq-artemis/pull/2831#discussion_r322628010
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##
@@ -2025,4 +2025,12 @@ void slowConsumerDetected(String sessionID,
@LogMessage(level = Logger.Level.WARN)
@Message(id = 224101, value = "Apache ActiveMQ Artemis is using a scheduled
pool without remove on cancel policy, so a cancelled task could be not
automatically removed from the work queue, it may also cause unbounded
retention of cancelled tasks.", format = Message.Format.MESSAGE_FORMAT)
void scheduledPoolWithNoRemoveOnCancelPolicy();
+
+ @LogMessage(level = Logger.Level.INFO)
+ @Message(id = 224102, value = "unable to undeply address {0} : reason {1}",
format = Message.Format.MESSAGE_FORMAT)
+ void unableToUndeployAddress(SimpleString addressName, String reason);
+
+ @LogMessage(level = Logger.Level.INFO)
+ @Message(id = 224103, value = "unable to undeply address {0} : reason {1}",
format = Message.Format.MESSAGE_FORMAT)
Review comment:
undepl**o**y
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 309639)
Time Spent: 20m (was: 10m)
> Reloading configuration can kill broker
> ---
>
> Key: ARTEMIS-2480
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2480
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some cases if undeploying a queue or address fails during restart then the
> broker will die, we should log a warning and continue
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[
https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309641=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309641
]
ASF GitHub Bot logged work on ARTEMIS-2480:
---
Author: ASF GitHub Bot
Created on: 10/Sep/19 09:00
Start Date: 10/Sep/19 09:00
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2831:
ARTEMIS-2480 - Reloading configuration can kill broker
URL: https://github.com/apache/activemq-artemis/pull/2831#discussion_r322628136
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##
@@ -2025,4 +2025,12 @@ void slowConsumerDetected(String sessionID,
@LogMessage(level = Logger.Level.WARN)
@Message(id = 224101, value = "Apache ActiveMQ Artemis is using a scheduled
pool without remove on cancel policy, so a cancelled task could be not
automatically removed from the work queue, it may also cause unbounded
retention of cancelled tasks.", format = Message.Format.MESSAGE_FORMAT)
void scheduledPoolWithNoRemoveOnCancelPolicy();
+
+ @LogMessage(level = Logger.Level.INFO)
+ @Message(id = 224102, value = "unable to undeply address {0} : reason {1}",
format = Message.Format.MESSAGE_FORMAT)
Review comment:
typo in message: undepl**o**y
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 309641)
Time Spent: 40m (was: 0.5h)
> Reloading configuration can kill broker
> ---
>
> Key: ARTEMIS-2480
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2480
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In some cases if undeploying a queue or address fails during restart then the
> broker will die, we should log a warning and continue
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[
https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309640=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309640
]
ASF GitHub Bot logged work on ARTEMIS-2480:
---
Author: ASF GitHub Bot
Created on: 10/Sep/19 09:00
Start Date: 10/Sep/19 09:00
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2831:
ARTEMIS-2480 - Reloading configuration can kill broker
URL: https://github.com/apache/activemq-artemis/pull/2831#discussion_r322628136
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##
@@ -2025,4 +2025,12 @@ void slowConsumerDetected(String sessionID,
@LogMessage(level = Logger.Level.WARN)
@Message(id = 224101, value = "Apache ActiveMQ Artemis is using a scheduled
pool without remove on cancel policy, so a cancelled task could be not
automatically removed from the work queue, it may also cause unbounded
retention of cancelled tasks.", format = Message.Format.MESSAGE_FORMAT)
void scheduledPoolWithNoRemoveOnCancelPolicy();
+
+ @LogMessage(level = Logger.Level.INFO)
+ @Message(id = 224102, value = "unable to undeply address {0} : reason {1}",
format = Message.Format.MESSAGE_FORMAT)
Review comment:
undepl**o**y
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 309640)
Time Spent: 0.5h (was: 20m)
> Reloading configuration can kill broker
> ---
>
> Key: ARTEMIS-2480
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2480
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In some cases if undeploying a queue or address fails during restart then the
> broker will die, we should log a warning and continue
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2480) Reloading configuration can kill broker
[ https://issues.apache.org/jira/browse/ARTEMIS-2480?focusedWorklogId=309628=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309628 ] ASF GitHub Bot logged work on ARTEMIS-2480: --- Author: ASF GitHub Bot Created on: 10/Sep/19 08:46 Start Date: 10/Sep/19 08:46 Worklog Time Spent: 10m Work Description: andytaylor commented on pull request #2831: ARTEMIS-2480 - Reloading configuration can kill broker URL: https://github.com/apache/activemq-artemis/pull/2831 https://issues.apache.org/jira/browse/ARTEMIS-2480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309628) Remaining Estimate: 0h Time Spent: 10m > Reloading configuration can kill broker > --- > > Key: ARTEMIS-2480 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2480 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In some cases if undeploying a queue or address fails during restart then the > broker will die, we should log a warning and continue -- This message was sent by Atlassian Jira (v8.3.2#803003)
