[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892408=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892408 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 18:36 Start Date: 27/Nov/23 18:36 Worklog Time Spent: 10m Work Description: jbertram merged PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683 Issue Time Tracking --- Worklog Id: (was: 892408) Time Spent: 1h 40m (was: 1.5h) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[
https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892401
]
ASF GitHub Bot logged work on ARTEMIS-3932:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 17:32
Start Date: 27/Nov/23 17:32
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4683:
URL: https://github.com/apache/activemq-artemis/pull/4683#discussion_r1406511051
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##
@@ -3596,6 +3534,41 @@ public void addAddressSettings(final String address,
}
+ @Override
+ public String addAddressSettings(String address, String
addressSettingsConfigurationAsJson) throws Exception {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.addAddressSettings(this.server,
addressSettingsConfigurationAsJson);
+ }
+ checkStarted();
+
+ clearIO();
+
+ try {
+ // when the QueueConfiguration is passed through createQueue all of
its defaults get set which we return to the caller
Review Comment:
This comment is incorrect.
Issue Time Tracking
---
Worklog Id: (was: 892401)
Time Spent: 1.5h (was: 1h 20m)
> replace addAddressSettings with JSON param
> --
>
> Key: ARTEMIS-3932
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3932
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Andy Taylor
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Similar to what we did with createQueue deprecate the addAddressSettings in
> ServerControl and add a json version
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892363 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 15:09 Start Date: 27/Nov/23 15:09 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1828019781 I gave up on the idea. I was going to write a meta-record..which would simplify usage, but it would probably increase memory of the broker if those settings are over-used. so I'm giving up the idea. Issue Time Tracking --- Worklog Id: (was: 892363) Time Spent: 1h 20m (was: 1h 10m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892357 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 14:21 Start Date: 27/Nov/23 14:21 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1827928209 hmmm... actually I will not do that.. but I will still change the Address and Queue records to use the JSON object format. Issue Time Tracking --- Worklog Id: (was: 892357) Time Spent: 1h 10m (was: 1h) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892356 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 14:19 Start Date: 27/Nov/23 14:19 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1827924148 I am marking this as draft as I will refactor the journal record where I'm using a JSON object to be reused for other cases. Issue Time Tracking --- Worklog Id: (was: 892356) Time Spent: 1h (was: 50m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=891157=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891157 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 17/Nov/23 21:10 Start Date: 17/Nov/23 21:10 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4682: ARTEMIS-3932 deprecate & replace addAddressSettings with JSON version URL: https://github.com/apache/activemq-artemis/pull/4682 Issue Time Tracking --- Worklog Id: (was: 891157) Time Spent: 50m (was: 40m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=891156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891156 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 17/Nov/23 21:09 Start Date: 17/Nov/23 21:09 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1817110025 also: as I commented on the commit, the amount of work to use BeanUtils would be a lot larger and not satisfactory. I still have my branch saved from when I was trying to use BeanUtils, but I would have a much larger set of changes for a small gain over what I'm doing here. For instance: the getters would always go through the default values instead of getting the attributes directly. and it wouldn't be possible to generate the same object back from a "marshaller". (well: wouldn't be possible is a strong word here, lets just say, I could do it with a lot more work involved. Hence I will use the declarative approach as I mentioned here). Issue Time Tracking --- Worklog Id: (was: 891156) Time Spent: 40m (was: 0.5h) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=891155=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891155 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 17/Nov/23 21:04 Start Date: 17/Nov/23 21:04 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1817102989 Notice: I created this PR with the current status of my work before a week break on American Thanksgiving. I won't be able to do extensive work on this PR on the week between Nov-19th and Nov-25th. but I will certainly respond to small inquiries. Issue Time Tracking --- Worklog Id: (was: 891155) Time Spent: 0.5h (was: 20m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=891154=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891154 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 17/Nov/23 21:02 Start Date: 17/Nov/23 21:02 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4683: URL: https://github.com/apache/activemq-artemis/pull/4683 As I worked through implementing a more generic JSON marshaller, I tried using reflection through BeanUtils and other ways however the endresult was always worse as there were a few caveats that were not as easy to accomplish. For that reason I went to a declarative appraoch where I define a meta-data object on AddressSettings and AddressSettingsInfo and reuse the metadata in a few other places. Issue Time Tracking --- Worklog Id: (was: 891154) Time Spent: 20m (was: 10m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=891153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891153 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 17/Nov/23 20:59 Start Date: 17/Nov/23 20:59 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4682: URL: https://github.com/apache/activemq-artemis/pull/4682 (no comment) Issue Time Tracking --- Worklog Id: (was: 891153) Remaining Estimate: 0h Time Spent: 10m > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
