[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883110=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883110 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 03/Oct/23 12:54 Start Date: 03/Oct/23 12:54 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635 Issue Time Tracking --- Worklog Id: (was: 883110) Time Spent: 2h 10m (was: 2h) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883100 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 03/Oct/23 12:26 Start Date: 03/Oct/23 12:26 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1744863864 LGTM. Issue Time Tracking --- Worklog Id: (was: 883100) Time Spent: 2h (was: 1h 50m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883081 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 03/Oct/23 11:39 Start Date: 03/Oct/23 11:39 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1744787211 @brusdev I manually tested and I had the impression that System.getProperty would handle the property defined on both env and -D from java. perhaps we should also test the System.evn to make sure? Issue Time Tracking --- Worklog Id: (was: 883081) Time Spent: 1h 50m (was: 1h 40m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883068=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883068 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 03/Oct/23 10:30 Start Date: 03/Oct/23 10:30 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1744686651 Actually, @gtully pointed me to `envVarNameFromSystemPropertyName`, see https://github.com/apache/activemq-artemis/blob/2.31.0/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java#L151 I'll push a new commit to handle both env (`ARTEMIS_EXTRA_LIBS`) ans system property (`artemis.extra.libs`) Issue Time Tracking --- Worklog Id: (was: 883068) Time Spent: 1h 40m (was: 1.5h) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883046 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 03/Oct/23 06:54 Start Date: 03/Oct/23 06:54 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1744317638 @clebertsuconic thanks for the test, I like it. Maybe for a system property I should use a lowercase name, i.e. `artemis.extra.libs` WDYT? Issue Time Tracking --- Worklog Id: (was: 883046) Time Spent: 1.5h (was: 1h 20m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883012 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 02/Oct/23 22:29 Start Date: 02/Oct/23 22:29 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1743858821 If you agree with the test perhaps you should squash the change. Issue Time Tracking --- Worklog Id: (was: 883012) Time Spent: 1h 20m (was: 1h 10m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=883011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883011 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 02/Oct/23 22:21 Start Date: 02/Oct/23 22:21 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1743851493 @brusdev I converted the Derby Page Test to use this extension, and I used a -D definition on the library folder. And that actually raised me an issue... you'r using System.getEnv. Shouldn't you use System.getProperty() which would work with either -D or a exported property. I sent a commit to your branch for your evaluation. Issue Time Tracking --- Worklog Id: (was: 883011) Time Spent: 1h 10m (was: 1h) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882982=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882982 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 02/Oct/23 19:59 Start Date: 02/Oct/23 19:59 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1743670534 I think we should use the db-tests to validate this. I am going to tweak the Derby Test to use this variable. Issue Time Tracking --- Worklog Id: (was: 882982) Time Spent: 1h (was: 50m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882631=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882631 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 12:45 Start Date: 29/Sep/23 12:45 Worklog Time Spent: 10m Work Description: brusdev commented on code in PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#discussion_r1341320819 ## docs/user-manual/using-server.adoc: ## @@ -532,10 +532,16 @@ NOTE: the environment variable `JAVA_ARGS_APPEND` can be used to append or overr Runtime dependencies like diverts, transformers, broker plugins, JDBC drivers, password decoders, etc. must be accessible by the broker at runtime. Package the dependency in a jar, and put it on the broker's classpath. -This can be done by placing the jar file in the `lib` directory of the broker distribution itself or in the `lib` directory of the broker instance. +This can be done by placing the jar file in the `lib` directory of the broker distribution itself, +by placing the jar file in the `lib` directory of the broker instance or +by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contain the jar file. Review Comment: suggestion applied, thanks Issue Time Tracking --- Worklog Id: (was: 882631) Time Spent: 50m (was: 40m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882588=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882588 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 10:17 Start Date: 29/Sep/23 10:17 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#discussion_r1341179720 ## docs/user-manual/using-server.adoc: ## @@ -532,10 +532,16 @@ NOTE: the environment variable `JAVA_ARGS_APPEND` can be used to append or overr Runtime dependencies like diverts, transformers, broker plugins, JDBC drivers, password decoders, etc. must be accessible by the broker at runtime. Package the dependency in a jar, and put it on the broker's classpath. -This can be done by placing the jar file in the `lib` directory of the broker distribution itself or in the `lib` directory of the broker instance. +This can be done by placing the jar file in the `lib` directory of the broker distribution itself, +by placing the jar file in the `lib` directory of the broker instance or +by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contain the jar file. Review Comment: ```suggestion by placing the jar file in the `lib` directory of the broker instance, or by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contains the jar file. ``` Issue Time Tracking --- Worklog Id: (was: 882588) Time Spent: 40m (was: 0.5h) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882582=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882582 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 09:19 Start Date: 29/Sep/23 09:19 Worklog Time Spent: 10m Work Description: gtully commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1740575543 looks even better :-) Issue Time Tracking --- Worklog Id: (was: 882582) Time Spent: 0.5h (was: 20m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882554=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882554 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 04:00 Start Date: 29/Sep/23 04:00 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1740274336 I changed the implementation to allow only a comma separated list of directories. Issue Time Tracking --- Worklog Id: (was: 882554) Time Spent: 20m (was: 10m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882203 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 27/Sep/23 14:37 Start Date: 27/Sep/23 14:37 Worklog Time Spent: 10m Work Description: brusdev opened a new pull request, #4635: URL: https://github.com/apache/activemq-artemis/pull/4635 The environment variable `JAVA_URL_CLASSPATH_APPEND` is a comma separated list of path URLs, i.e. ``` export JAVA_URL_CLASSPATH_APPEND=file:///usr/local/share/java/my.jar ``` Issue Time Tracking --- Worklog Id: (was: 882203) Remaining Estimate: 0h Time Spent: 10m > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
