[jira] [Work logged] (ARTEMIS-4687) Concurrent use of DocumentBuilder breaking Xpath filtering
[ https://issues.apache.org/jira/browse/ARTEMIS-4687?focusedWorklogId=909781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909781 ] ASF GitHub Bot logged work on ARTEMIS-4687: --- Author: ASF GitHub Bot Created on: 14/Mar/24 03:22 Start Date: 14/Mar/24 03:22 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4852: URL: https://github.com/apache/activemq-artemis/pull/4852 Issue Time Tracking --- Worklog Id: (was: 909781) Time Spent: 40m (was: 0.5h) > Concurrent use of DocumentBuilder breaking Xpath filtering > -- > > Key: ARTEMIS-4687 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4687 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4687) Concurrent use of DocumentBuilder breaking Xpath filtering
[
https://issues.apache.org/jira/browse/ARTEMIS-4687?focusedWorklogId=909756=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909756
]
ASF GitHub Bot logged work on ARTEMIS-4687:
---
Author: ASF GitHub Bot
Created on: 13/Mar/24 21:49
Start Date: 13/Mar/24 21:49
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4852:
URL: https://github.com/apache/activemq-artemis/pull/4852#discussion_r1523955679
##
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/JAXPXPathEvaluator.java:
##
@@ -56,8 +60,11 @@ protected boolean evaluate(String text) {
protected boolean evaluate(InputSource inputSource) {
try {
- return ((Boolean)xpath.evaluate(xpathExpression,
builder.parse(inputSource), XPathConstants.BOOLEAN)).booleanValue();
+ synchronized (builder) {
Review Comment:
I'm not exactly sure if there _should_ be multiple instances. The `builder`
is created in a `static` block in
`org.apache.activemq.artemis.selector.filter.XPathExpression`.
Issue Time Tracking
---
Worklog Id: (was: 909756)
Time Spent: 0.5h (was: 20m)
> Concurrent use of DocumentBuilder breaking Xpath filtering
> --
>
> Key: ARTEMIS-4687
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4687
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4687) Concurrent use of DocumentBuilder breaking Xpath filtering
[
https://issues.apache.org/jira/browse/ARTEMIS-4687?focusedWorklogId=909755=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909755
]
ASF GitHub Bot logged work on ARTEMIS-4687:
---
Author: ASF GitHub Bot
Created on: 13/Mar/24 21:35
Start Date: 13/Mar/24 21:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4852:
URL: https://github.com/apache/activemq-artemis/pull/4852#discussion_r1523944339
##
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/JAXPXPathEvaluator.java:
##
@@ -56,8 +60,11 @@ protected boolean evaluate(String text) {
protected boolean evaluate(InputSource inputSource) {
try {
- return ((Boolean)xpath.evaluate(xpathExpression,
builder.parse(inputSource), XPathConstants.BOOLEAN)).booleanValue();
+ synchronized (builder) {
Review Comment:
shouldn't there be multiple instances created instead? I mean... it seems
the factory always returns the same instance?
Issue Time Tracking
---
Worklog Id: (was: 909755)
Time Spent: 20m (was: 10m)
> Concurrent use of DocumentBuilder breaking Xpath filtering
> --
>
> Key: ARTEMIS-4687
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4687
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4687) Concurrent use of DocumentBuilder breaking Xpath filtering
[ https://issues.apache.org/jira/browse/ARTEMIS-4687?focusedWorklogId=909742=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909742 ] ASF GitHub Bot logged work on ARTEMIS-4687: --- Author: ASF GitHub Bot Created on: 13/Mar/24 21:12 Start Date: 13/Mar/24 21:12 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4852: URL: https://github.com/apache/activemq-artemis/pull/4852 (no comment) Issue Time Tracking --- Worklog Id: (was: 909742) Remaining Estimate: 0h Time Spent: 10m > Concurrent use of DocumentBuilder breaking Xpath filtering > -- > > Key: ARTEMIS-4687 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4687 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
