[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064911#comment-16064911
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1374
  
At least the JIRA here is wrong.. this could be the cause of a Wildfly 
issue.. but the issue is there.. a mismatch somewhere. you should rename this 
to matching boolean property to Boolean as specified somewhere else.. I'm fine 
with this... but the file:// error won't translate here.


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064871#comment-16064871
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1374
  
Well.. even if the change is valid.. we need to understand what is the 
issue..

perhaps the type needs to match the method?

on which case the description of the JIRA is wrong... it would be something 
generic not tight to Wildfly.


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064844#comment-16064844
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user xstefank commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1374#discussion_r124274905
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java
 ---
@@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx) {
   this.localTx = localTx;
}
 
-   public boolean isRebalanceConnections() {
+   public Boolean isRebalanceConnections() {
--- End diff --

@clebertsuconic there is a JBEAP issue associated: 
https://issues.jboss.org/browse/JBEAP-11776 ; Fix is only needed for this 
reason. I am not sure how to handle such case.


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064908#comment-16064908
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1372
  
what is the difference? 


> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064922#comment-16064922
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1372
  
@clebertsuconic ``Unpooled::directBuffer`` is not specified on Netty 
javadoc but could allocate a direct ``ByteBuffer`` with no ``Cleaner`` in it 
i.e. when GC occour the JVM doesn't free it.
Calling directly ``ByteBuffer.allocateDirect`` forces the instantiation of 
the buffer with a ``Cleaner``, hence tests, that create and destroy multiple 
``TimedBuffer`` instances do not goes OOM anymore.


> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064873#comment-16064873
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1374
  
there are a lot of other booleans on the ActivactionSpec.. what if you set 
shareSubscriptions to true for instance?

I'm not convinced of an issue in Artemis yet.


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1255) Unable to validate user

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065258#comment-16065258
 ] 

ASF GitHub Bot commented on ARTEMIS-1255:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1369


> Unable to validate user
> ---
>
> Key: ARTEMIS-1255
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1255
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.5.2, 
> 1.5.3, 1.5.4, 1.5.5, 2.0.0, 2.1.0
>Reporter: Josh Reagan
>
> Trying to connect with a globally set user/password fails for 
> XAConnectionFactory with the following error:
> AMQ119031: Unable to validate user



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065279#comment-16065279
 ] 

ASF GitHub Bot commented on ARTEMIS-1259:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1375


> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065278#comment-16065278
 ] 

ASF subversion and git services commented on ARTEMIS-1259:
--

Commit 028df470309471842ca3cd9729533c4912107a84 in activemq-artemis's branch 
refs/heads/master from [~ch...@me.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=028df47 ]

[ARTEMIS-1259] Log messages without prefixed id code in artemis-server-osgi


> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065254#comment-16065254
 ] 

ASF subversion and git services commented on ARTEMIS-1246:
--

Commit a8356fb057eb45f3a560e3841ce3fec220155153 in activemq-artemis's branch 
refs/heads/master from [~nigro@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a8356fb ]

ARTEMIS-1246 Fixing compatibility issue

It fixes compatibility issues with JMS Core clients using the old address 
model, allowing the client to query JMS temporary queues too.

you would eventually see this issue when using older clients:
AMQ119019: Queue already exists


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1255) Unable to validate user

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065256#comment-16065256
 ] 

ASF subversion and git services commented on ARTEMIS-1255:
--

Commit 177bda4892b0aabd89311ec28b91762fb22ebaae in activemq-artemis's branch 
refs/heads/master from [~jreagan]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=177bda4 ]

ARTEMIS-1255 Fixed authentication issues with XAConnectionFactory

Added the global user/password variables to all of the variations of the 
createContext/createConnectionFactory methods.


> Unable to validate user
> ---
>
> Key: ARTEMIS-1255
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1255
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.5.2, 
> 1.5.3, 1.5.4, 1.5.5, 2.0.0, 2.1.0
>Reporter: Josh Reagan
>
> Trying to connect with a globally set user/password fails for 
> XAConnectionFactory with the following error:
> AMQ119031: Unable to validate user



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065255#comment-16065255
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1365


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1255) Unable to validate user

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065294#comment-16065294
 ] 

ASF GitHub Bot commented on ARTEMIS-1255:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1369
  
FYI - There's no technical reason to close the PR.  You can just push -f on 
your "authentication_fix" branch.


> Unable to validate user
> ---
>
> Key: ARTEMIS-1255
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1255
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.5.2, 
> 1.5.3, 1.5.4, 1.5.5, 2.0.0, 2.1.0
>Reporter: Josh Reagan
>
> Trying to connect with a globally set user/password fails for 
> XAConnectionFactory with the following error:
> AMQ119031: Unable to validate user



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065239#comment-16065239
 ] 

ASF GitHub Bot commented on ARTEMIS-1256:
-

Github user dudaerich commented on the issue:

https://github.com/apache/activemq-artemis/pull/1370
  
Nice wait expression. It is good to know about Wait.waitFor utility. Thanks.


> PagingOMETest.testPageCleanup fails
> ---
>
> Key: ARTEMIS-1256
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: expected:<2> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
> {code}
> Queue.getMessageCount does not guarantee you get accurate number of messages 
> on the queue. To get precise number, the test must wait until all 
> asynchronous tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ARTEMIS-1258) ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved ARTEMIS-1258.
-
Resolution: Fixed

> ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession
> --
>
> Key: ARTEMIS-1258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1258
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> This is related to ARTEMIS-1172.  It would be helpful if the beforeSend and 
> afterSend callback methods also contained the ServerSession as an argument.  
> The old methods will be deprecated and eventually removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (AMQ-6704) Dependency updates for version 5.15.0

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved AMQ-6704.
-
Resolution: Fixed
  Assignee: Christopher L. Shannon

> Dependency updates for version 5.15.0
> -
>
> Key: AMQ-6704
> URL: https://issues.apache.org/jira/browse/AMQ-6704
> Project: ActiveMQ
>  Issue Type: Improvement
>Affects Versions: 5.14.5
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 5.15.0
>
>
> We should go through our dependencies and update any that make sense in time 
> for teh 5.15.0 release.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[Erich Duda (JIRA)]

Erich Duda created ARTEMIS-1256:
---

 Summary: PagingOMETest.testPageCleanup fails
 Key: ARTEMIS-1256
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.1.0, 1.5.5
Reporter: Erich Duda


{code}
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at 
org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
{code}

Queue.getMessageCount does not guarantee you get accurate number of messages on 
the queue. To get precise number, the test must wait until all asynchronous 
tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065093#comment-16065093
 ] 

ASF GitHub Bot commented on ARTEMIS-1259:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1375
  
..checkstyle... also make sure ArtemisFeatureTest is working


> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1258) ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065099#comment-16065099
 ] 

ASF subversion and git services commented on ARTEMIS-1258:
--

Commit a538b969c097cf6f9c95c77707087578a2b48910 in activemq-artemis's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a538b96 ]

ARTEMIS-1258 - Add ServerSession as an argument to beforeSend and
afterSend


> ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession
> --
>
> Key: ARTEMIS-1258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1258
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> This is related to ARTEMIS-1172.  It would be helpful if the beforeSend and 
> afterSend callback methods also contained the ServerSession as an argument.  
> The old methods will be deprecated and eventually removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065104#comment-16065104
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1372


> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1258) ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065100#comment-16065100
 ] 

ASF GitHub Bot commented on ARTEMIS-1258:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1373


> ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession
> --
>
> Key: ARTEMIS-1258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1258
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> This is related to ARTEMIS-1172.  It would be helpful if the beforeSend and 
> afterSend callback methods also contained the ServerSession as an argument.  
> The old methods will be deprecated and eventually removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065112#comment-16065112
 ] 

ASF subversion and git services commented on ARTEMIS-1256:
--

Commit 5c2144b7826c25e8510f870b588e873685291d74 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5c2144b ]

ARTEMIS-1256 PagingOMETest.testPageCleanup fails

Using a Wait condition.

This closes #1370


> PagingOMETest.testPageCleanup fails
> ---
>
> Key: ARTEMIS-1256
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: expected:<2> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
> {code}
> Queue.getMessageCount does not guarantee you get accurate number of messages 
> on the queue. To get precise number, the test must wait until all 
> asynchronous tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065113#comment-16065113
 ] 

ASF GitHub Bot commented on ARTEMIS-1256:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1370


> PagingOMETest.testPageCleanup fails
> ---
>
> Key: ARTEMIS-1256
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: expected:<2> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
> {code}
> Queue.getMessageCount does not guarantee you get accurate number of messages 
> on the queue. To get precise number, the test must wait until all 
> asynchronous tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065109#comment-16065109
 ] 

ASF GitHub Bot commented on ARTEMIS-1256:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1370
  
I'm pushing a new commit closing this one instead.. if you disagree please 
let me know.


> PagingOMETest.testPageCleanup fails
> ---
>
> Key: ARTEMIS-1256
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: expected:<2> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
> {code}
> Queue.getMessageCount does not guarantee you get accurate number of messages 
> on the queue. To get precise number, the test must wait until all 
> asynchronous tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065120#comment-16065120
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
your commit message here is: 'ARTEMIS-1246 AMQ119019: Queue already exists'

It should be fixing:

ARTEMIS-1246 compatibilty issue that will cause Queue already exists error




That commit message is an error message, which I would have to open the 
JIRA to have more information about it.. the logs should be self content about 
the change... opening the JIRA should be an add-on to the discussion... I use 
git logs doezens of times a day.. having to open JIRA for each one of the 
changes is not optimal.


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065127#comment-16065127
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
@franz1981 the only reason I didn't merge this is that this would be a 
hidden feature... no docs.. 

can you add a doc chapter about this?


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065133#comment-16065133
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
I was going to merge by using checkout-PR and merge-branch scripts... (from 
./scripts).

with this commit meesage instead:
```
ARTEMIS-1246 Fixing compatibility issue 

It fixes compatibility issues with JMS Core clients using the old address 
model, allowing the client to query JMS temporary queues too.

you would eventually see this issue when using older clients:

AMQ119019: Queue already exists
```

Isn't there a way to replicate this failure though?


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065016#comment-16065016
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1372
  
@clebertsuconic Probably it would be better to push a PR on Netty to add 
some doc on it too, but I agree, I'll pur a comment to make it more clear :+1: 


> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065033#comment-16065033
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user xstefank closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1371


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065035#comment-16065035
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user xstefank closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1374


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[Dmitrii Tikhomirov (JIRA)]

Dmitrii Tikhomirov created ARTEMIS-1259:
---

 Summary: Log messages without prefixed id code in 
artemis-server-osgi
 Key: ARTEMIS-1259
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Dmitrii Tikhomirov
Priority: Minor
 Fix For: 2.2.0


Run following command in artemis-jms-client root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep -i 
-E -v "test|example|junit" | xargs grep -i -E 
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:  
 ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey() + 
"=" + binding.getValue(), e);
./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
   ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(), newIOOB);


{code}





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[Dmitrii Tikhomirov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitrii Tikhomirov updated ARTEMIS-1259:

Description: 
Run following command in artemis-server-osgi root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
-i -E -v "test|example|junit" | xargs grep -i -E 
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
LOG.info("Broker config " + name + " found. Tracking protocols " + 
Arrays.asList(requiredProtocols));
./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java: 
LOG.info("Required protocol " + protocol + " was added for broker " + name + ". 
" +
./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java: 
LOG.info("Required protocol " + protocol + " was removed for broker " + name + 
". " + (missing.isEmpty() ? "Stopping broker. " : ""));


{code}



  was:
Run following command in artemis-jms-client root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep -i 
-E -v "test|example|junit" | xargs grep -i -E 
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:  
 ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey() + 
"=" + binding.getValue(), e);
./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
   ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(), newIOOB);


{code}




> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1253) Regression: NetworkHealthCheck is not restarting the server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065055#comment-16065055
 ] 

ASF subversion and git services commented on ARTEMIS-1253:
--

Commit f407d86f0fd8d8472600364caf88e1711c0e4e0b in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f407d86 ]

ARTEMIS-1253 Fixing NetworkHealthCheck being shutdown after failures


> Regression: NetworkHealthCheck is not restarting the server
> ---
>
> Key: ARTEMIS-1253
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1253
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> After the network is down, the server won't restart itself. This used to work.
> Regression found at 07ea08a84532036acb0bf165c6185bee9a6a7bbc 
> ARTEMIS-915



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1253) Regression: NetworkHealthCheck is not restarting the server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065054#comment-16065054
 ] 

ASF subversion and git services commented on ARTEMIS-1253:
--

Commit 36110da9c834d606c0c5fb731b4e79504d32d7b2 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=36110da ]

ARTEMIS-1253 Refactoring renaming stop(boolean) to fail(boolean)

This method name would clash with ServiceComponent
As the real meaning here on this method is just to failover
So I've renamed the method to avoid the clash with my next commit

(I've done this on a separate commit as you may need to redo this
 commit from scratch again in other branches instead of lots of clashes on 
cherry-pick)


> Regression: NetworkHealthCheck is not restarting the server
> ---
>
> Key: ARTEMIS-1253
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1253
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> After the network is down, the server won't restart itself. This used to work.
> Regression found at 07ea08a84532036acb0bf165c6185bee9a6a7bbc 
> ARTEMIS-915



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1253) Regression: NetworkHealthCheck is not restarting the server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065053#comment-16065053
 ] 

ASF subversion and git services commented on ARTEMIS-1253:
--

Commit 4bae81490857f1ea292a89bead675669fae6de4e in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4bae814 ]

ARTEMIS-1253 Adding testcase


> Regression: NetworkHealthCheck is not restarting the server
> ---
>
> Key: ARTEMIS-1253
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1253
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> After the network is down, the server won't restart itself. This used to work.
> Regression found at 07ea08a84532036acb0bf165c6185bee9a6a7bbc 
> ARTEMIS-915



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1253) Regression: NetworkHealthCheck is not restarting the server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065065#comment-16065065
 ] 

ASF subversion and git services commented on ARTEMIS-1253:
--

Commit 437232b50ef8b9f21daf3196bc316c62e5b37c57 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=437232b ]

ARTEMIS-1253 Renaming NetworkReplicationTest to NetworkIsolationTest


> Regression: NetworkHealthCheck is not restarting the server
> ---
>
> Key: ARTEMIS-1253
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1253
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> After the network is down, the server won't restart itself. This used to work.
> Regression found at 07ea08a84532036acb0bf165c6185bee9a6a7bbc 
> ARTEMIS-915



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065049#comment-16065049
 ] 

ASF GitHub Bot commented on ARTEMIS-1259:
-

GitHub user treblereel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1375

[ARTEMIS-1259] Log messages without prefixed id code in artemis-serve…

…r-osgi
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1259

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/treblereel/activemq-artemis-wildfly 
IMPROVE_LOGGING_SERVER_OSGI

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1375


commit 5df4ba1fe0af2b2aeab32933dec8ab07b9b5e731
Author: Dmitrii Tikhomirov 
Date:   2017-06-26T14:50:10Z

[ARTEMIS-1259] Log messages without prefixed id code in artemis-server-osgi




> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064993#comment-16064993
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1372
  
@franz1981  mind adding some // about it?


> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1259) Log messages without prefixed id code in artemis-server-osgi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065206#comment-16065206
 ] 

ASF GitHub Bot commented on ARTEMIS-1259:
-

Github user treblereel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1375
  
[main] 17:49:10,023 ERROR [org.apache.activemq.artemis.core.server] 
AMQ224000: Failure in initialisation: 
io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address 
already in use



> Log messages without prefixed id code in artemis-server-osgi
> 
>
> Key: ARTEMIS-1259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1259
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-server-osgi root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-server-osgi]$ find -name "*.java" | grep 
> -i -E -v "test|example|junit" | xargs grep -i -E 
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:  
> LOG.info("Broker config " + name + " found. Tracking protocols " + 
> Arrays.asList(requiredProtocols));
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was added for broker " + name + 
> ". " +
> ./src/main/java/org/apache/activemq/artemis/osgi/ProtocolTracker.java:
>  LOG.info("Required protocol " + protocol + " was removed for broker " + name 
> + ". " + (missing.isEmpty() ? "Stopping broker. " : ""));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1256) PagingOMETest.testPageCleanup fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064461#comment-16064461
 ] 

ASF GitHub Bot commented on ARTEMIS-1256:
-

GitHub user dudaerich opened a pull request:

https://github.com/apache/activemq-artemis/pull/1370

ARTEMIS-1256 PagingOMETest.testPageCleanup fails

Queue.getMessageCount does not guarantee you get accurate number
of messages on the queue. To get precise number, the test must
wait until all asynchronous tasks on the queue are finished.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudaerich/activemq-artemis ARTEMIS-1256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1370






> PagingOMETest.testPageCleanup fails
> ---
>
> Key: ARTEMIS-1256
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1256
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: expected:<2> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.extras.byteman.PagingOMETest.testPageCleanup(PagingOMETest.java:148)
> {code}
> Queue.getMessageCount does not guarantee you get accurate number of messages 
> on the queue. To get precise number, the test must wait until all 
> asynchronous tasks on queue are finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064418#comment-16064418
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
@clebertsuconic I've added an additional comment to the first line of the 
commit message (that is actually the same of the related JIRA) to make more 
clear what case it fixes :+1: 


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ARTEMIS-1172) ActiveMQServerPlugin beforeDeliver and afterDeliver should pass in the ServerConsumer

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved ARTEMIS-1172.
-
Resolution: Fixed

> ActiveMQServerPlugin beforeDeliver and afterDeliver should pass in the 
> ServerConsumer
> -
>
> Key: ARTEMIS-1172
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1172
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> I forgot to add the ServerConsumer to both the beforeDeliver and afterDeliver 
> plugin methods that matches where the message will/has been delivered to.  
> The consumer should be added as an argument and the old methods should be 
> deprecated and eventually removed (probably in Artemis 3.0)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064725#comment-16064725
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

GitHub user xstefank opened a pull request:

https://github.com/apache/activemq-artemis/pull/1374

[ARTEMIS-1257] IJ020017: Invalid archive: file://RaActivatoractivemq-…

…ra when pooled connection factory rebalance-connections is set to true

ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xstefank/jboss-activemq-artemis 
ARTEMIS-1257-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1374


commit fa6b366f12cb12686747089be6748b1f7744325c
Author: xstefank 
Date:   2017-06-27T12:12:24Z

[ARTEMIS-1257] IJ020017: Invalid archive: file://RaActivatoractivemq-ra 
when pooled connection factory rebalance-connections is set to true




> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[Martin Stefanko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Stefanko updated ARTEMIS-1257:
-
External issue URL: https://issues.jboss.org/browse/JBEAP-11776
 External issue ID: JBEAP-11776

> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064671#comment-16064671
 ] 

ASF GitHub Bot commented on ARTEMIS-1223:
-

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1372

ARTEMIS-1223 OutOfDirectMemoryError raised from TimedBuffer

Force allocation of direct ByteBuffer with Cleaner to help GC on tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis timed_buffer_oom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1372


commit fc64d9a1c3a259f492cef6aaebd6a682943322a2
Author: Francesco Nigro 
Date:   2017-06-27T09:47:44Z

ARTEMIS-1223 OutOfDirectMemoryError raised from TimedBuffer

Force allocation of direct ByteBuffer with Cleaner to help GC on tests.




> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT  - tr.r14.java.green_20161011_125790
> GC   - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>Priority: Minor
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it 
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760 
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at 
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at 
> 

[jira] [Commented] (ARTEMIS-1221) Duplicated ID causes LargeMessage lost at backup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064792#comment-16064792
 ] 

ASF GitHub Bot commented on ARTEMIS-1221:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1347
  
@clebertsuconic 
well, it turns out more work need to be done. It happens that the changes 
of code just avoids the bug and makes the test pass. The pendingIDs are not 
used at all. I need a bit more time to correct it. :)


> Duplicated ID causes LargeMessage lost at backup
> 
>
> Key: ARTEMIS-1221
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1221
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.5.6, 2.2.0
>
>
> When a large message is replicated to backup, a pendingID is generated when 
> the large message is finished. This pendingID is generated by a 
> BatchingIDGenerator at backup.
> It is possible that a pendingID generated at backup may be a duplicate to an 
> ID generated at live server. 
> This can cause a problem when a large message with a messageID that is the 
> same as another largemessage's pendingID is replicated and stored in the 
> backup's journal, and then a deleteRecord for the pendingID is appended.
> If backup becomes live and loads the journal, it will drop the large message 
> add record because there is a deleteRecord of the same ID (even though it is 
> a pendingID of another message). As a result the expecting client will never 
> get this large message.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[Martin Stefanko (JIRA)]

Martin Stefanko created ARTEMIS-1257:


 Summary: IJ020017: Invalid archive: file://RaActivatoractivemq-ra 
when pooled connection factory rebalance-connections is set to true
 Key: ARTEMIS-1257
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Martin Stefanko
Assignee: Martin Stefanko


If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is set 
to true, following warning is logged during the server start

{noformat}
2017-06-26 09:22:04,755 WARN  
[org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
 (MSC service thread 1-5) IJ020017: Invalid archive: 
file://RaActivatoractivemq-ra
2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
thread 1-5) Resource adaptor started
2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
(ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
2017-06-26 09:22:04,757 INFO  
[org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
 (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1258) ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064718#comment-16064718
 ] 

ASF GitHub Bot commented on ARTEMIS-1258:
-

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/1373

ARTEMIS-1258 - Add ServerSession as an argument to before/after send plugin 
methods

This improves the beforeSend and afterSend callback by allowing the plugin 
writer to get access to the ServerSession that is doing the send of the message.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1258

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1373


commit 30076ab0aedbdeee8fae533f233917363e7824e5
Author: Christopher L. Shannon (cshannon) 
Date:   2017-06-27T12:02:47Z

ARTEMIS-1258 - Add ServerSession as an argument to beforeSend and
afterSend




> ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession
> --
>
> Key: ARTEMIS-1258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1258
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> This is related to ARTEMIS-1172.  It would be helpful if the beforeSend and 
> afterSend callback methods also contained the ServerSession as an argument.  
> The old methods will be deprecated and eventually removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064643#comment-16064643
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

GitHub user xstefank opened a pull request:

https://github.com/apache/activemq-artemis/pull/1371

[ARTEMIS-1257] IJ020017: Invalid archive: file://RaActivatoractivemq-…

…ra when pooled connection factory rebalance-connections is set to true

ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1371


commit 4420b72b1946d9d61f454fdf8b74ba4b4bb44905
Author: xstefank 
Date:   2017-06-27T10:45:24Z

[ARTEMIS-1257] IJ020017: Invalid archive: file://RaActivatoractivemq-ra 
when pooled connection factory rebalance-connections is set to true




> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[Martin Stefanko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on ARTEMIS-1257 started by Martin Stefanko.

> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1257) IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064765#comment-16064765
 ] 

ASF GitHub Bot commented on ARTEMIS-1257:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1374#discussion_r124260574
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java
 ---
@@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx) {
   this.localTx = localTx;
}
 
-   public boolean isRebalanceConnections() {
+   public Boolean isRebalanceConnections() {
--- End diff --

??? how come this would be an issue? how to replictate it? have a test?


> IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled 
> connection factory rebalance-connections is set to true
> 
>
> Key: ARTEMIS-1257
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1257
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martin Stefanko
>Assignee: Martin Stefanko
>
> If attribute {{rebalance-connections}} on {{pooled-connection-factory}} is 
> set to true, following warning is logged during the server start
> {noformat}
> 2017-06-26 09:22:04,755 WARN  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020017: Invalid archive: 
> file://RaActivatoractivemq-ra
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.ra] (MSC service 
> thread 1-5) Resource adaptor started
> 2017-06-26 09:22:04,757 INFO  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 75) AMQ221003: Deploying queue jms.queue.DLQ
> 2017-06-26 09:22:04,757 INFO  
> [org.jboss.as.connector.services.resourceadapters.ResourceAdapterActivatorService$ResourceAdapterActivator]
>  (MSC service thread 1-5) IJ020002: Deployed: file://RaActivatoractivemq-ra
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1258) ActiveMQServerPlugin beforeSend and afterSend should pass in ServerSession

[Christopher L. Shannon (JIRA)]

Christopher L. Shannon created ARTEMIS-1258:
---

 Summary: ActiveMQServerPlugin beforeSend and afterSend should pass 
in ServerSession
 Key: ARTEMIS-1258
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1258
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Christopher L. Shannon
Assignee: Christopher L. Shannon
 Fix For: 2.2.0


This is related to ARTEMIS-1172.  It would be helpful if the beforeSend and 
afterSend callback methods also contained the ServerSession as an argument.  
The old methods will be deprecated and eventually removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)