[jira] [Commented] (AMBARI-24852) NPE in default host group replacement
[
https://issues.apache.org/jira/browse/AMBARI-24852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671028#comment-16671028
]
Hudson commented on AMBARI-24852:
-
SUCCESS: Integrated in Jenkins build Ambari-branch-2.7 #397 (See
[https://builds.apache.org/job/Ambari-branch-2.7/397/])
AMBARI-24852. NPE in default host group replacement (#2567) (github:
[https://gitbox.apache.org/repos/asf?p=ambari.git=commit=7186cf4034b4ae87e5301eafd3c31622b35150ab])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
> NPE in default host group replacement
> -
>
> Key: AMBARI-24852
> URL: https://issues.apache.org/jira/browse/AMBARI-24852
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.7.0
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.3
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Cluster deployment fails if some property value is null:
> {noformat}
> 2018-10-31 17:38:44,579 INFO [pool-3-thread-1] AsyncCallableService:100 -
> Task ConfigureClusterTask exception during execution
> java.lang.NullPointerException
> at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
> at java.util.regex.Matcher.reset(Matcher.java:309)
> at java.util.regex.Matcher.(Matcher.java:229)
> at java.util.regex.Pattern.matcher(Pattern.java:1093)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$HostGroupUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1754)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.updateValue(BlueprintConfigurationProcessor.java:739)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$null$7(BlueprintConfigurationProcessor.java:705)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$applyDefaultUpdater$8(BlueprintConfigurationProcessor.java:700)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.applyDefaultUpdater(BlueprintConfigurationProcessor.java:697)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doGeneralPropertyUpdatesForClusterCreate(BlueprintConfigurationProcessor.java:664)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:443)
> at
> org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:152)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (AMBARI-24850) Use the proper stack root for Hive pre upgrade
[ https://issues.apache.org/jira/browse/AMBARI-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely resolved AMBARI-24850. - Resolution: Fixed > Use the proper stack root for Hive pre upgrade > -- > > Key: AMBARI-24850 > URL: https://issues.apache.org/jira/browse/AMBARI-24850 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Affects Versions: 2.7.0 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > /usr/hdp was hard coded, need to use Script.get_stack_root() instead -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24852) NPE in default host group replacement
[
https://issues.apache.org/jira/browse/AMBARI-24852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doroszlai, Attila updated AMBARI-24852:
---
Status: Patch Available (was: In Progress)
> NPE in default host group replacement
> -
>
> Key: AMBARI-24852
> URL: https://issues.apache.org/jira/browse/AMBARI-24852
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.7.0
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Cluster deployment fails if some property value is null:
> {noformat}
> 2018-10-31 17:38:44,579 INFO [pool-3-thread-1] AsyncCallableService:100 -
> Task ConfigureClusterTask exception during execution
> java.lang.NullPointerException
> at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
> at java.util.regex.Matcher.reset(Matcher.java:309)
> at java.util.regex.Matcher.(Matcher.java:229)
> at java.util.regex.Pattern.matcher(Pattern.java:1093)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$HostGroupUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1754)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.updateValue(BlueprintConfigurationProcessor.java:739)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$null$7(BlueprintConfigurationProcessor.java:705)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$applyDefaultUpdater$8(BlueprintConfigurationProcessor.java:700)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.applyDefaultUpdater(BlueprintConfigurationProcessor.java:697)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doGeneralPropertyUpdatesForClusterCreate(BlueprintConfigurationProcessor.java:664)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:443)
> at
> org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:152)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24852) NPE in default host group replacement
[
https://issues.apache.org/jira/browse/AMBARI-24852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-24852:
Labels: pull-request-available (was: )
> NPE in default host group replacement
> -
>
> Key: AMBARI-24852
> URL: https://issues.apache.org/jira/browse/AMBARI-24852
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.7.0
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.3
>
>
> Cluster deployment fails if some property value is null:
> {noformat}
> 2018-10-31 17:38:44,579 INFO [pool-3-thread-1] AsyncCallableService:100 -
> Task ConfigureClusterTask exception during execution
> java.lang.NullPointerException
> at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
> at java.util.regex.Matcher.reset(Matcher.java:309)
> at java.util.regex.Matcher.(Matcher.java:229)
> at java.util.regex.Pattern.matcher(Pattern.java:1093)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$HostGroupUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1754)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.updateValue(BlueprintConfigurationProcessor.java:739)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$null$7(BlueprintConfigurationProcessor.java:705)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$applyDefaultUpdater$8(BlueprintConfigurationProcessor.java:700)
> at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.applyDefaultUpdater(BlueprintConfigurationProcessor.java:697)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doGeneralPropertyUpdatesForClusterCreate(BlueprintConfigurationProcessor.java:664)
> at
> org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:443)
> at
> org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:152)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AMBARI-24852) NPE in default host group replacement
Doroszlai, Attila created AMBARI-24852:
--
Summary: NPE in default host group replacement
Key: AMBARI-24852
URL: https://issues.apache.org/jira/browse/AMBARI-24852
Project: Ambari
Issue Type: Bug
Components: ambari-server
Affects Versions: 2.7.0
Reporter: Doroszlai, Attila
Assignee: Doroszlai, Attila
Fix For: 2.7.3
Cluster deployment fails if some property value is null:
{noformat}
2018-10-31 17:38:44,579 INFO [pool-3-thread-1] AsyncCallableService:100 - Task
ConfigureClusterTask exception during execution
java.lang.NullPointerException
at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
at java.util.regex.Matcher.reset(Matcher.java:309)
at java.util.regex.Matcher.(Matcher.java:229)
at java.util.regex.Pattern.matcher(Pattern.java:1093)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$HostGroupUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1754)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.updateValue(BlueprintConfigurationProcessor.java:739)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$null$7(BlueprintConfigurationProcessor.java:705)
at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.lambda$applyDefaultUpdater$8(BlueprintConfigurationProcessor.java:700)
at java.util.HashMap$EntrySet.forEach(HashMap.java:1044)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.applyDefaultUpdater(BlueprintConfigurationProcessor.java:697)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doGeneralPropertyUpdatesForClusterCreate(BlueprintConfigurationProcessor.java:664)
at
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:443)
at
org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:152)
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (AMBARI-24843) Make Ambaripreupload.py more configurable
[
https://issues.apache.org/jira/browse/AMBARI-24843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doroszlai, Attila resolved AMBARI-24843.
Resolution: Done
> Make Ambaripreupload.py more configurable
> -
>
> Key: AMBARI-24843
> URL: https://issues.apache.org/jira/browse/AMBARI-24843
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When testing {{Ambaripreupload.py}} locally, one needs to work around some
> hardcoded values (JDBC driver, DFS type). The goal of this change is to make
> the script more configurable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670654#comment-16670654
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229844986
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/credential/FileSecretStore.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.credential;
+
+import org.apache.commons.io.FileUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.File;
+import java.nio.charset.Charset;
+
+public class FileSecretStore implements SecretStore {
+
+ private static final Logger logger =
LogManager.getLogger(FileSecretStore.class);
+
+ private final String fileLocation;
+ private final String defaultSecret;
+
+ public FileSecretStore(String fileLocation, String defaultSecret) {
+this.fileLocation = fileLocation;
+this.defaultSecret = defaultSecret;
+ }
+
+ public FileSecretStore(String fileLocation) {
+this.fileLocation = fileLocation;
+this.defaultSecret = null;
+ }
+
+ @Override
+ public char[] getSecret() {
+try {
+ File pwdFile = new File(fileLocation);
+ if (!pwdFile.exists() && defaultSecret != null) {
+FileUtils.writeStringToFile(pwdFile, defaultSecret,
Charset.defaultCharset());
+return defaultSecret.toCharArray();
+ } else {
+return FileUtils.readFileToString(pwdFile,
Charset.defaultCharset()).toCharArray();
Review comment:
File content can be read directly to byte or char array That would be more
secure than readFileToString. Also defaultSecret can be a char[]
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24843) Make Ambaripreupload.py more configurable
[
https://issues.apache.org/jira/browse/AMBARI-24843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670548#comment-16670548
]
Hudson commented on AMBARI-24843:
-
FAILURE: Integrated in Jenkins build Ambari-branch-2.6 #709 (See
[https://builds.apache.org/job/Ambari-branch-2.6/709/])
AMBARI-24843. Make Ambaripreupload.py more configurable (#2563) (github:
[https://gitbox.apache.org/repos/asf?p=ambari.git=commit=2237560490df7f8a23c056853d493a31309547dd])
* (edit) ambari-server/src/main/resources/scripts/Ambaripreupload.py
> Make Ambaripreupload.py more configurable
> -
>
> Key: AMBARI-24843
> URL: https://issues.apache.org/jira/browse/AMBARI-24843
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When testing {{Ambaripreupload.py}} locally, one needs to work around some
> hardcoded values (JDBC driver, DFS type). The goal of this change is to make
> the script more configurable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670444#comment-16670444 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #17: AMBARI-24833. Create cloud input/output skeleton. URL: https://github.com/apache/ambari-logsearch/pull/17#issuecomment-434783497 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/27/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670364#comment-16670364 ] Hudson commented on AMBARI-24851: - SUCCESS: Integrated in Jenkins build Ambari-LogSearch-master-Commit #21 (See [https://builds.apache.org/job/Ambari-LogSearch-master-Commit/21/]) AMBARI-24851 - ADDENDUM Logsearch: debug mode using java 8 and 11 (#16) (github: [https://gitbox.apache.org/repos/asf?p=ambari-logsearch.git=commit=f0c35f35e56b9a8f2719d97c327413d02e3fa2ec]) * (edit) ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[
https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670319#comment-16670319
]
ASF GitHub Bot commented on AMBARI-24851:
-
kasakrisz closed pull request #16: AMBARI-24851 - ADDENDUM Logsearch: debug
mode using java 8 and 11
URL: https://github.com/apache/ambari-logsearch/pull/16
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh
b/ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh
index eaf00e130d..213e564c5d 100755
--- a/ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh
+++ b/ambari-logsearch-logfeeder/src/main/scripts/logfeeder.sh
@@ -168,7 +168,12 @@ function start() {
LOGFEEDER_DEBUG_PORT=${LOGFEEDER_DEBUG_PORT:-"5006"}
if [ "$LOGFEEDER_DEBUG" = "true" ]; then
-LOGFEEDER_JAVA_OPTS="$LOGFEEDER_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=*:$LOGFEEDER_DEBUG_PORT,server=y,suspend=$LOGFEEDER_DEBUG_SUSPEND
"
+if [ $java_version == "8" ]; then
+ LOGFEEDER_DEBUG_ADDRESS=$LOGFEEDER_DEBUG_PORT
+else
+ LOGFEEDER_DEBUG_ADDRESS="*:$LOGFEEDER_DEBUG_PORT"
+fi
+LOGFEEDER_JAVA_OPTS="$LOGFEEDER_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=$LOGFEEDER_DEBUG_ADDRESS,server=y,suspend=$LOGFEEDER_DEBUG_SUSPEND
"
fi
if [ "$LOGFEEDER_SSL" = "true" ]; then
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Logsearch: debug mode using java 8 and 11
> -
>
> Key: AMBARI-24851
> URL: https://issues.apache.org/jira/browse/AMBARI-24851
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Logsearch server can not be started in debug mode if Logsearch is running in
> an Ambari managed cluster using java 8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670311#comment-16670311 ] ASF GitHub Bot commented on AMBARI-24851: - asfgit commented on issue #16: AMBARI-24851 - ADDENDUM Logsearch: debug mode using java 8 and 11 URL: https://github.com/apache/ambari-logsearch/pull/16#issuecomment-434744613 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/26/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670305#comment-16670305 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #17: AMBARI-24833. Create cloud input/output skeleton. URL: https://github.com/apache/ambari-logsearch/pull/17#issuecomment-434743372 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/25/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670275#comment-16670275 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #17: AMBARI-24833. Create cloud input/output skeleton. URL: https://github.com/apache/ambari-logsearch/pull/17#issuecomment-434739915 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/24/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24843) Make Ambaripreupload.py more configurable
[
https://issues.apache.org/jira/browse/AMBARI-24843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670215#comment-16670215
]
Hudson commented on AMBARI-24843:
-
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10259 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/10259/])
AMBARI-24843. Make Ambaripreupload.py more configurable (#2566) (github:
[https://gitbox.apache.org/repos/asf?p=ambari.git=commit=cce16fb367cc1d0184ab0561750fc8f7757f5021])
* (edit) ambari-server/src/main/resources/scripts/Ambaripreupload.py
> Make Ambaripreupload.py more configurable
> -
>
> Key: AMBARI-24843
> URL: https://issues.apache.org/jira/browse/AMBARI-24843
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When testing {{Ambaripreupload.py}} locally, one needs to work around some
> hardcoded values (JDBC driver, DFS type). The goal of this change is to make
> the script more configurable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24841) Pause after first batch
[ https://issues.apache.org/jira/browse/AMBARI-24841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670214#comment-16670214 ] Hudson commented on AMBARI-24841: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10259 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10259/]) [AMBARI-24841] Pause after first batch (dsen) (#2554) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git=commit=3287fe267eebe49b8611a9a77ea33263262f2a2d]) * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchSettings.java * (edit) ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql * (edit) ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog280Test.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java * (edit) ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql * (edit) ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecutionImpl.java * (edit) ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql * (edit) ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql * (edit) ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog280.java * (edit) ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql * (edit) ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestScheduleEntity.java > Pause after first batch > --- > > Key: AMBARI-24841 > URL: https://issues.apache.org/jira/browse/AMBARI-24841 > Project: Ambari > Issue Type: Task > Components: ambari-server >Affects Versions: 2.8.0 >Reporter: Dmytro Sen >Assignee: Dmytro Sen >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Option to automatically pause after the first batch is completed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24732) Datanode and Nodemanagers need to check in to the respective Masters to mark successful restart
[ https://issues.apache.org/jira/browse/AMBARI-24732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670216#comment-16670216 ] Hudson commented on AMBARI-24732: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10259 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10259/]) AMBARI-24732. Datanode and Nodemanagers need to check in to the (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git=commit=ffaeaed70dceaf0803a039664601275a8020682c]) * (edit) ambari-common/src/main/python/resource_management/libraries/script/script.py > Datanode and Nodemanagers need to check in to the respective Masters to mark > successful restart > --- > > Key: AMBARI-24732 > URL: https://issues.apache.org/jira/browse/AMBARI-24732 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24732.patch > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24814) Add a rolling_restart_supported flag at the stack service endpoint
[ https://issues.apache.org/jira/browse/AMBARI-24814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670213#comment-16670213 ] Hudson commented on AMBARI-24814: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10259 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10259/]) [AMBARI-24814] Add a rolling_restart_supported flag at the stack service (github: [https://gitbox.apache.org/repos/asf?p=ambari.git=commit=a2c6fd99a41a3f2a3f88ca72fb71eddf86babf1f]) * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java > Add a rolling_restart_supported flag at the stack service endpoint > -- > > Key: AMBARI-24814 > URL: https://issues.apache.org/jira/browse/AMBARI-24814 > Project: Ambari > Issue Type: Task > Components: ambari-server >Affects Versions: 2.8.0 >Reporter: Dmytro Sen >Assignee: Dmytro Sen >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Similar to the one at stack service component level we need a flag for HDFS, > YARN and Zookeeper > at api/v1/stacks/HDP/versions//services/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670177#comment-16670177 ] Hudson commented on AMBARI-24851: - SUCCESS: Integrated in Jenkins build Ambari-LogSearch-master-Commit #20 (See [https://builds.apache.org/job/Ambari-LogSearch-master-Commit/20/]) AMBARI-24851 - Logsearch: debug mode using java 8 and 11 (#15) (github: [https://gitbox.apache.org/repos/asf?p=ambari-logsearch.git=commit=845e0c64e061d24a7e0c016a954c2ace502f4e47]) * (edit) ambari-logsearch-server/src/main/scripts/logsearch.sh > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670164#comment-16670164
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229713010
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/manager/operations/impl/DefaultInputConfigHandler.java
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.manager.operations.impl;
+
+import org.apache.ambari.logfeeder.manager.operations.InputConfigHandler;
+import org.apache.ambari.logfeeder.input.InputSimulate;
+import org.apache.ambari.logfeeder.manager.InputConfigHolder;
+import org.apache.ambari.logfeeder.plugin.common.AliasUtil;
+import org.apache.ambari.logfeeder.plugin.filter.Filter;
+import org.apache.ambari.logfeeder.plugin.input.Input;
+import org.apache.ambari.logfeeder.plugin.output.Output;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.FilterDescriptor;
+import org.apache.ambari.logsearch.config.api.model.inputconfig.InputConfig;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.InputDescriptor;
+import org.apache.commons.lang.BooleanUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Holds input/filter/output operations in default Log Feeder mode.
+ */
+public class DefaultInputConfigHandler implements InputConfigHandler {
+
+ private static final Logger logger =
LogManager.getLogger(DefaultInputConfigHandler.class);
+
+ @Override
+ public void init(InputConfigHolder inputConfigHolder) throws Exception {
+ }
+
+ @Override
+ public void loadInputs(String serviceName, InputConfigHolder
inputConfigHolder, InputConfig inputConfig) {
+loadInputs(serviceName, inputConfigHolder);
+loadFilters(serviceName, inputConfigHolder);
+ }
+
+ @Override
+ public void assignInputsToOutputs(String serviceName, InputConfigHolder
inputConfigHolder, InputConfig config) {
+for (Input input :
inputConfigHolder.getInputManager().getInputList(serviceName)) {
+ for (Output output : inputConfigHolder.getOutputManager().getOutputs()) {
+if (input.isOutputRequired(output)) {
+ input.addOutput(output);
+}
+ }
+}
+
+// In case of simulation copies of the output are added for each
simulation instance, these must be added to the manager
+for (Output output : InputSimulate.getSimulateOutputs()) {
+ output.setLogSearchConfig(inputConfigHolder.getConfig());
+ inputConfigHolder.getOutputManager().add(output);
+}
+ }
+
+ private void loadInputs(String serviceName, InputConfigHolder
inputConfigHolder) {
+for (InputDescriptor inputDescriptor :
inputConfigHolder.getInputConfigList()) {
+ if (inputDescriptor == null) {
+continue;
+ }
+
+ String source = inputDescriptor.getSource();
+ if (StringUtils.isEmpty(source)) {
+logger.error("Input block doesn't have source element");
+continue;
+ }
+ Input input = (Input) AliasUtil.getClassInstance(source,
AliasUtil.AliasType.INPUT);
+ if (input == null) {
+logger.error("Input object could not be found");
+continue;
+ }
+ input.setType(source);
+ input.setLogType(inputDescriptor.getType());
+ input.loadConfig(inputDescriptor);
+
+ if (input.isEnabled()) {
+input.setOutputManager(inputConfigHolder.getOutputManager());
+input.setInputManager(inputConfigHolder.getInputManager());
+inputConfigHolder.getInputManager().add(serviceName, input);
+logger.info("New input object registered for service '{}': '{}'",
serviceName, input.getLogType());
+input.logConfigs();
+ } else {
+logger.info("Input is disabled. So ignoring it. " +
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670163#comment-16670163
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229712754
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/manager/operations/impl/DefaultInputConfigHandler.java
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.manager.operations.impl;
+
+import org.apache.ambari.logfeeder.manager.operations.InputConfigHandler;
+import org.apache.ambari.logfeeder.input.InputSimulate;
+import org.apache.ambari.logfeeder.manager.InputConfigHolder;
+import org.apache.ambari.logfeeder.plugin.common.AliasUtil;
+import org.apache.ambari.logfeeder.plugin.filter.Filter;
+import org.apache.ambari.logfeeder.plugin.input.Input;
+import org.apache.ambari.logfeeder.plugin.output.Output;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.FilterDescriptor;
+import org.apache.ambari.logsearch.config.api.model.inputconfig.InputConfig;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.InputDescriptor;
+import org.apache.commons.lang.BooleanUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Holds input/filter/output operations in default Log Feeder mode.
+ */
+public class DefaultInputConfigHandler implements InputConfigHandler {
+
+ private static final Logger logger =
LogManager.getLogger(DefaultInputConfigHandler.class);
+
+ @Override
+ public void init(InputConfigHolder inputConfigHolder) throws Exception {
+ }
+
+ @Override
+ public void loadInputs(String serviceName, InputConfigHolder
inputConfigHolder, InputConfig inputConfig) {
+loadInputs(serviceName, inputConfigHolder);
+loadFilters(serviceName, inputConfigHolder);
+ }
+
+ @Override
+ public void assignInputsToOutputs(String serviceName, InputConfigHolder
inputConfigHolder, InputConfig config) {
+for (Input input :
inputConfigHolder.getInputManager().getInputList(serviceName)) {
+ for (Output output : inputConfigHolder.getOutputManager().getOutputs()) {
+if (input.isOutputRequired(output)) {
+ input.addOutput(output);
+}
+ }
+}
+
+// In case of simulation copies of the output are added for each
simulation instance, these must be added to the manager
+for (Output output : InputSimulate.getSimulateOutputs()) {
+ output.setLogSearchConfig(inputConfigHolder.getConfig());
+ inputConfigHolder.getOutputManager().add(output);
+}
+ }
+
+ private void loadInputs(String serviceName, InputConfigHolder
inputConfigHolder) {
+for (InputDescriptor inputDescriptor :
inputConfigHolder.getInputConfigList()) {
+ if (inputDescriptor == null) {
+continue;
Review comment:
Should we log an Error or throw an exception when `inputDescriptor` is
`null`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670155#comment-16670155
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229709887
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/manager/operations/impl/CloudStorageInputConfigHandler.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.manager.operations.impl;
+
+import org.apache.ambari.logfeeder.common.LogFeederConstants;
+import org.apache.ambari.logfeeder.conf.LogFeederMode;
+import org.apache.ambari.logfeeder.filter.FilterDummy;
+import org.apache.ambari.logfeeder.manager.operations.InputConfigHandler;
+import org.apache.ambari.logfeeder.manager.InputConfigHolder;
+import org.apache.ambari.logfeeder.plugin.common.AliasUtil;
+import org.apache.ambari.logfeeder.plugin.input.Input;
+import org.apache.ambari.logfeeder.plugin.output.Output;
+import org.apache.ambari.logsearch.config.api.model.inputconfig.InputConfig;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.InputDescriptor;
+import
org.apache.ambari.logsearch.config.api.model.inputconfig.InputSocketDescriptor;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+/**
+ * Holds input/filter/output operations in cloud Log Feeder mode.
+ */
+public class CloudStorageInputConfigHandler implements InputConfigHandler {
+
+ private static final Logger logger =
LogManager.getLogger(CloudStorageInputConfigHandler.class);
+
+ @Override
+ public void init(InputConfigHolder inputConfigHolder) {
+logger.info("Call init of cloud input config handler...");
+ }
+
+ @Override
+ public void loadInputs(String serviceName, InputConfigHolder
inputConfigHolder, InputConfig inputConfig) {
+for (InputDescriptor inputDescriptor :
inputConfigHolder.getInputConfigList()) {
+ if (inputDescriptor == null) {
+continue;
Review comment:
Should an exception be thrown here? like
```
throw new NullPointerException("inputDescriptor can not be null!")
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670130#comment-16670130
]
ASF GitHub Bot commented on AMBARI-24833:
-
oleewere commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229701401
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
##
@@ -199,6 +199,16 @@
@Value("${" + LogFeederConstants.SOLR_URLS + ":}")
private String solrUrlsStr;
+ @LogSearchPropertyDescription(
+name = LogFeederConstants.CLOUD_STORAGE_MODE,
+description = "Option to support sending logs to cloud storage. You can
choose between supporting only cloud storage, non-cloud storage or both",
+examples = {"default", "cloud", "hybrid"},
+defaultValue = "true",
+sources = {LogFeederConstants.CLOUD_STORAGE_MODE}
+ )
+ @Value("${" + LogFeederConstants.CLOUD_STORAGE_MODE + ":default}")
+ public String cloudStorageMode;
Review comment:
it can be, note that in the Condition classes, we will need to gather that
from a string anyway
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670057#comment-16670057
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229679354
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
##
@@ -199,6 +199,16 @@
@Value("${" + LogFeederConstants.SOLR_URLS + ":}")
private String solrUrlsStr;
+ @LogSearchPropertyDescription(
+name = LogFeederConstants.CLOUD_STORAGE_MODE,
+description = "Option to support sending logs to cloud storage. You can
choose between supporting only cloud storage, non-cloud storage or both",
+examples = {"default", "cloud", "hybrid"},
+defaultValue = "true",
+sources = {LogFeederConstants.CLOUD_STORAGE_MODE}
+ )
+ @Value("${" + LogFeederConstants.CLOUD_STORAGE_MODE + ":default}")
+ public String cloudStorageMode;
Review comment:
Can `cloudStorageMode` have a type of `LogFeederMode` instead of `String`?
Or `LogFeederMode.fromString(mode)` should throw an informative exception in
case of an invalid value instead of falling back to `LogFeederMode.DEFAULT` like
```
throw new IllegalArgumentException("The value '" + mode + "'is not a valid
LogFeederMode!");
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670052#comment-16670052
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229679354
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
##
@@ -199,6 +199,16 @@
@Value("${" + LogFeederConstants.SOLR_URLS + ":}")
private String solrUrlsStr;
+ @LogSearchPropertyDescription(
+name = LogFeederConstants.CLOUD_STORAGE_MODE,
+description = "Option to support sending logs to cloud storage. You can
choose between supporting only cloud storage, non-cloud storage or both",
+examples = {"default", "cloud", "hybrid"},
+defaultValue = "true",
+sources = {LogFeederConstants.CLOUD_STORAGE_MODE}
+ )
+ @Value("${" + LogFeederConstants.CLOUD_STORAGE_MODE + ":default}")
+ public String cloudStorageMode;
Review comment:
Can `cloudStorageMode` have a type of `LogFeederMode` instead of `String`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670053#comment-16670053
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229679354
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
##
@@ -199,6 +199,16 @@
@Value("${" + LogFeederConstants.SOLR_URLS + ":}")
private String solrUrlsStr;
+ @LogSearchPropertyDescription(
+name = LogFeederConstants.CLOUD_STORAGE_MODE,
+description = "Option to support sending logs to cloud storage. You can
choose between supporting only cloud storage, non-cloud storage or both",
+examples = {"default", "cloud", "hybrid"},
+defaultValue = "true",
+sources = {LogFeederConstants.CLOUD_STORAGE_MODE}
+ )
+ @Value("${" + LogFeederConstants.CLOUD_STORAGE_MODE + ":default}")
+ public String cloudStorageMode;
Review comment:
Can `cloudStorageMode` have a type of `LogFeederMode` instead of `String`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670049#comment-16670049
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229678607
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
##
@@ -199,6 +199,16 @@
@Value("${" + LogFeederConstants.SOLR_URLS + ":}")
private String solrUrlsStr;
+ @LogSearchPropertyDescription(
+name = LogFeederConstants.CLOUD_STORAGE_MODE,
+description = "Option to support sending logs to cloud storage. You can
choose between supporting only cloud storage, non-cloud storage or both",
+examples = {"default", "cloud", "hybrid"},
+defaultValue = "true",
Review comment:
Is `true` a valid value for `cloudStorageMode`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670045#comment-16670045
]
ASF GitHub Bot commented on AMBARI-24833:
-
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud
input/output skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229677987
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederMode.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.logfeeder.conf;
+
+/**
+ * Global Log Feeder modes:
+ *
+ * - default: process logs based on input / filter / output JSON configurations
+ * - cloud: process logs based on input JSON configurations and send them
directly into cloud storage (without filters)
+ * - hybrid: use both 2 above (together)
+ *
+ */
+public enum LogFeederMode {
+ DEFAULT("default"), CLOUD("cloud"), HYBRID("hybrid");
+
+ private String text;
+
+ LogFeederMode(String text) {
+this.text = text;
+ }
+
+ public String getText() {
+return this.text;
+ }
+
+ public static LogFeederMode fromString(String text) {
+for (LogFeederMode mode : LogFeederMode.values()) {
+ if (mode.text.equalsIgnoreCase(text)) {
+return mode;
+ }
+}
+return LogFeederMode.DEFAULT;
+ }
+
+ public static boolean isCloudStorage(LogFeederMode mode) {
+return mode.equals(LogFeederMode.HYBRID) ||
mode.equals(LogFeederMode.CLOUD);
Review comment:
If would be safer to check equality this way because `mode` can be null:
```
LogFeederMode.HYBRID.equals(mode)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24833: Labels: pull-request-available (was: ) > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670023#comment-16670023 ] ASF GitHub Bot commented on AMBARI-24833: - oleewere opened a new pull request #17: AMBARI-24833. Create cloud input/output skeleton. URL: https://github.com/apache/ambari-logsearch/pull/17 # What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670020#comment-16670020 ] ASF GitHub Bot commented on AMBARI-24851: - kasakrisz opened a new pull request #16: AMBARI-24851 - ADDENDUM Logsearch: debug mode using java 8 and 11 URL: https://github.com/apache/ambari-logsearch/pull/16 # What changes were proposed in this pull request? like #15 for Logfeeder ## How was this patch tested? manually: adding the following line to `logfeeder-env` template ``` export LOGFEEDER_DEBUG=true ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[
https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1666#comment-1666
]
ASF GitHub Bot commented on AMBARI-24851:
-
kasakrisz closed pull request #15: AMBARI-24851 - Logsearch: debug mode using
java 8 and 11
URL: https://github.com/apache/ambari-logsearch/pull/15
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ambari-logsearch-server/src/main/scripts/logsearch.sh
b/ambari-logsearch-server/src/main/scripts/logsearch.sh
index 1b64832995..a8211685e9 100755
--- a/ambari-logsearch-server/src/main/scripts/logsearch.sh
+++ b/ambari-logsearch-server/src/main/scripts/logsearch.sh
@@ -149,7 +149,12 @@ function start() {
LOGSEARCH_DEBUG_PORT=${LOGSEARCH_DEBUG_PORT:-"5005"}
if [ "$LOGSEARCH_DEBUG" = "true" ]; then
-LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=*:$LOGSEARCH_DEBUG_PORT,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
+if [ $java_version == "8" ]; then
+ LOGSEARCH_DEBUG_ADDRESS=$LOGSEARCH_DEBUG_PORT
+else
+ LOGSEARCH_DEBUG_ADDRESS="*:$LOGSEARCH_DEBUG_PORT"
+fi
+LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=$LOGSEARCH_DEBUG_ADDRESS,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
fi
if [ "$LOGSEARCH_SSL" = "true" ]; then
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Logsearch: debug mode using java 8 and 11
> -
>
> Key: AMBARI-24851
> URL: https://issues.apache.org/jira/browse/AMBARI-24851
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Logsearch server can not be started in debug mode if Logsearch is running in
> an Ambari managed cluster using java 8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24846) Ambari-agent stop hangs if ambari-server is stopped.
[ https://issues.apache.org/jira/browse/AMBARI-24846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669983#comment-16669983 ] Hudson commented on AMBARI-24846: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10258 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10258/]) AMBARI-24846. Ambari-agent stop hangs if ambari-server is stopped. (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git=commit=0f0bc6b39eda33e3990b1c34a272dbad80f37784]) * (edit) ambari-agent/src/main/python/ambari_agent/main.py > Ambari-agent stop hangs if ambari-server is stopped. > > > Key: AMBARI-24846 > URL: https://issues.apache.org/jira/browse/AMBARI-24846 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24846.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > [root@gc7001 ~]# ambari-agent stop > Verifying Python version compatibility... > Using python /usr/bin/python > Found ambari-agent PID: 7391 > Stopping ambari-agent > ^C^C^X^Z > [2]+ Stopped ambari-agent stop > [root@gc7001 ~]# ^C > [root@gc7001 ~]# kill -9 7391 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669980#comment-16669980 ] ASF GitHub Bot commented on AMBARI-24851: - asfgit commented on issue #15: AMBARI-24851 - Logsearch: debug mode using java 8 and 11 URL: https://github.com/apache/ambari-logsearch/pull/15#issuecomment-434653394 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/23/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669977#comment-16669977 ] ASF GitHub Bot commented on AMBARI-24851: - asfgit commented on issue #15: AMBARI-24851 - Logsearch: debug mode using java 8 and 11 URL: https://github.com/apache/ambari-logsearch/pull/15#issuecomment-434652987 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/22/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24850) Use the proper stack root for Hive pre upgrade
[ https://issues.apache.org/jira/browse/AMBARI-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669914#comment-16669914 ] Hudson commented on AMBARI-24850: - SUCCESS: Integrated in Jenkins build Ambari-branch-2.7 #396 (See [https://builds.apache.org/job/Ambari-branch-2.7/396/]) AMBARI-24850 Use the proper stack root for Hive pre upgrade (mgergely: [https://gitbox.apache.org/repos/asf?p=ambari.git=commit=88bfec4fb4043f75b41a16b50eeb61ac181de216]) * (edit) ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/pre_upgrade.py > Use the proper stack root for Hive pre upgrade > -- > > Key: AMBARI-24850 > URL: https://issues.apache.org/jira/browse/AMBARI-24850 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Affects Versions: 2.7.0 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > /usr/hdp was hard coded, need to use Script.get_stack_root() instead -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24837) Make Grafana connection attempts and retry delay configurable
[ https://issues.apache.org/jira/browse/AMBARI-24837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doroszlai, Attila updated AMBARI-24837: --- Fix Version/s: 2.7.3 > Make Grafana connection attempts and retry delay configurable > - > > Key: AMBARI-24837 > URL: https://issues.apache.org/jira/browse/AMBARI-24837 > Project: Ambari > Issue Type: Improvement > Components: ambari-metrics >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Fix For: 2.7.3 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Metrics Grafana HTTP requests are attempted at most 15 times in case of > failure, with 20 seconds delay each time. The goal of this change is to make > both the number of attempts and length of the delay configurable. Shorter > retry delay could be useful to reduce overall startup time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AMBARI-24837) Make Grafana connection attempts and retry delay configurable
[ https://issues.apache.org/jira/browse/AMBARI-24837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doroszlai, Attila resolved AMBARI-24837. Resolution: Fixed > Make Grafana connection attempts and retry delay configurable > - > > Key: AMBARI-24837 > URL: https://issues.apache.org/jira/browse/AMBARI-24837 > Project: Ambari > Issue Type: Improvement > Components: ambari-metrics >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Fix For: 2.7.3 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Metrics Grafana HTTP requests are attempted at most 15 times in case of > failure, with 20 seconds delay each time. The goal of this change is to make > both the number of attempts and length of the delay configurable. Shorter > retry delay could be useful to reduce overall startup time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[
https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669731#comment-16669731
]
ASF GitHub Bot commented on AMBARI-24851:
-
adoroszlai commented on a change in pull request #15: AMBARI-24851 - Logsearch:
debug mode using java 8 and 11
URL: https://github.com/apache/ambari-logsearch/pull/15#discussion_r229597012
##
File path: ambari-logsearch-server/src/main/scripts/logsearch.sh
##
@@ -149,7 +149,11 @@ function start() {
LOGSEARCH_DEBUG_PORT=${LOGSEARCH_DEBUG_PORT:-"5005"}
if [ "$LOGSEARCH_DEBUG" = "true" ]; then
-LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=*:$LOGSEARCH_DEBUG_PORT,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
+if [ $java_version == "8" ]; then
+ LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=$LOGSEARCH_DEBUG_PORT,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
+else
+ LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=*:$LOGSEARCH_DEBUG_PORT,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
Review comment:
Sorry for nitpicking, but please consider a more DRY version, like this:
```
if [ $java_version == "8" ]; then
LOGSEARCH_DEBUG_ADDRESS=$LOGSEARCH_DEBUG_PORT
else
LOGSEARCH_DEBUG_ADDRESS="*:$LOGSEARCH_DEBUG_PORT"
fi
LOGSEARCH_JAVA_OPTS="$LOGSEARCH_JAVA_OPTS -Xdebug
-Xrunjdwp:transport=dt_socket,address=$LOGSEARCH_DEBUG_ADDRESS,server=y,suspend=$LOGSEARCH_DEBUG_SUSPEND
"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Logsearch: debug mode using java 8 and 11
> -
>
> Key: AMBARI-24851
> URL: https://issues.apache.org/jira/browse/AMBARI-24851
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Logsearch server can not be started in debug mode if Logsearch is running in
> an Ambari managed cluster using java 8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669714#comment-16669714 ] ASF GitHub Bot commented on AMBARI-24851: - kasakrisz opened a new pull request #15: AMBARI-24851 - Logsearch: debug mode using java 8 and 11 URL: https://github.com/apache/ambari-logsearch/pull/15 # What changes were proposed in this pull request? Logsearch server can not be started in debug mode if Logsearch is running in an Ambari managed cluster using java 8 ## How was this patch tested? manually: 1. Start Logsearch using the docker env and attach a debugger 2. Deploy Ambari and Logsearch, enable debug mode in logsearch-env and attach a debugger This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
[ https://issues.apache.org/jira/browse/AMBARI-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24851: Labels: pull-request-available (was: ) > Logsearch: debug mode using java 8 and 11 > - > > Key: AMBARI-24851 > URL: https://issues.apache.org/jira/browse/AMBARI-24851 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > Logsearch server can not be started in debug mode if Logsearch is running in > an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24851) Logsearch: debug mode using java 8 and 11
Krisztian Kasa created AMBARI-24851: --- Summary: Logsearch: debug mode using java 8 and 11 Key: AMBARI-24851 URL: https://issues.apache.org/jira/browse/AMBARI-24851 Project: Ambari Issue Type: Bug Components: ambari-logsearch Affects Versions: 2.8.0 Reporter: Krisztian Kasa Assignee: Krisztian Kasa Fix For: 2.8.0 Logsearch server can not be started in debug mode if Logsearch is running in an Ambari managed cluster using java 8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
