[jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
[
https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133173#comment-16133173
]
Hudson commented on AMBARI-21744:
-
FAILURE: Integrated in Jenkins build Ambari-branch-2.6 #30 (See
[https://builds.apache.org/job/Ambari-branch-2.6/30/])
Revert "AMBARI-21744. package_regex in get_package_from_available() can
(dlysnichenko:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=5d0914c3a0f61f136231e59e20804bfd8bc5aa56])
* (edit)
ambari-common/src/main/python/resource_management/libraries/script/script.py
> package_regex in get_package_from_available() can match wrong pkg
> -
>
> Key: AMBARI-21744
> URL: https://issues.apache.org/jira/browse/AMBARI-21744
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.5.2
>Reporter: Dmitry Lysnichenko
>Assignee: Dmitry Lysnichenko
>Priority: Critical
> Fix For: 2.6.0
>
> Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
[
https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133168#comment-16133168
]
Hudson commented on AMBARI-21744:
-
FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7904 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7904/])
Revert "AMBARI-21744. package_regex in get_package_from_available() can
(dlysnichenko:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=ca8ae51afeff209657c19182d77e59a34cf6c0ae])
* (edit)
ambari-common/src/main/python/resource_management/libraries/script/script.py
> package_regex in get_package_from_available() can match wrong pkg
> -
>
> Key: AMBARI-21744
> URL: https://issues.apache.org/jira/browse/AMBARI-21744
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.5.2
>Reporter: Dmitry Lysnichenko
>Assignee: Dmitry Lysnichenko
>Priority: Critical
> Fix For: 2.6.0
>
> Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
[
https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133116#comment-16133116
]
Dmitry Lysnichenko commented on AMBARI-21744:
-
Reverted for now because it covers not all cases
To https://git-wip-us.apache.org/repos/asf/ambari.git
2f4fe911b8..5d0914c3a0 branch-2.6 -> branch-2.6
5f6ce4ea53..ca8ae51afe trunk -> trunk
> package_regex in get_package_from_available() can match wrong pkg
> -
>
> Key: AMBARI-21744
> URL: https://issues.apache.org/jira/browse/AMBARI-21744
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Reporter: Dmitry Lysnichenko
>Assignee: Dmitry Lysnichenko
>Priority: Critical
> Fix For: 2.6.0
>
> Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
[
https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130789#comment-16130789
]
Hudson commented on AMBARI-21744:
-
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #7898 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7898/])
AMBARI-21744. package_regex in get_package_from_available() can match
(dlysnichenko:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=f2cc609b0033d59130cb00d14ff8d2c8db6e1392])
* (edit)
ambari-common/src/main/python/resource_management/libraries/script/script.py
> package_regex in get_package_from_available() can match wrong pkg
> -
>
> Key: AMBARI-21744
> URL: https://issues.apache.org/jira/browse/AMBARI-21744
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Reporter: Dmitry Lysnichenko
>Assignee: Dmitry Lysnichenko
>Priority: Critical
> Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
[
https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130720#comment-16130720
]
Hudson commented on AMBARI-21744:
-
FAILURE: Integrated in Jenkins build Ambari-branch-2.6 #21 (See
[https://builds.apache.org/job/Ambari-branch-2.6/21/])
AMBARI-21744. package_regex in get_package_from_available() can match
(dlysnichenko:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=aa4807ca3a850d3275b11c9ee41a0cb6c5328b9c])
* (edit)
ambari-common/src/main/python/resource_management/libraries/script/script.py
> package_regex in get_package_from_available() can match wrong pkg
> -
>
> Key: AMBARI-21744
> URL: https://issues.apache.org/jira/browse/AMBARI-21744
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Reporter: Dmitry Lysnichenko
>Assignee: Dmitry Lysnichenko
>Priority: Critical
> Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries),
> resource_management.libraries.script.script.Script#get_package_from_available
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary
> named and goes first at list. Patch is a single-line fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
