[jira] [Commented] (AMBARI-22418) Make Ambari configuration API consistent with existing API.
[ https://issues.apache.org/jira/browse/AMBARI-22418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254009#comment-16254009 ] Hudson commented on AMBARI-22418: - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8396 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8396/]) AMBARI-22418. Make Ambari configuration API consistent with existing (rlevas: [http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=3f2743b58ba65c4bdc7d37df5348d17124bf305a]) * (edit) ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/ldap/LdapModuleFunctionalTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationServiceTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java * (delete) ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/metadata/AmbariServiceAlertDefinitions.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java * (add) ambari-server/src/main/java/org/apache/ambari/server/controller/RootComponent.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentPropertyProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java * (add) ambari-server/src/main/java/org/apache/ambari/server/controller/RootService.java * (delete) ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceService.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionServiceTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java * (delete) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentPropertyProviderTest.java * (add) ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationRequestSwagger.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java * (delete) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java * (add) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProviderTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/ldap/domain/TestAmbariLdapConfigurationFactory.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java * (add)
[jira] [Commented] (AMBARI-22418) Make Ambari configuration API consistent with existing API.
[
https://issues.apache.org/jira/browse/AMBARI-22418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252177#comment-16252177
]
Hadoop QA commented on AMBARI-22418:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12897615/AMBARI-22418_trunk_01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 core tests{color}. The test build failed in
[ambari-server|https://builds.apache.org/job/Ambari-trunk-test-patch/12669//artifact/patch-work/testrun_ambari-server.txt]
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12669//console
This message is automatically generated.
> Make Ambari configuration API consistent with existing API.
> ---
>
> Key: AMBARI-22418
> URL: https://issues.apache.org/jira/browse/AMBARI-22418
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 3.0.0
>Reporter: Robert Levas
>Assignee: Robert Levas
> Fix For: 3.0.0
>
> Attachments: AMBARI-22418_trunk_01.patch
>
>
> Make Ambari configuration API consistent with existing API.
> The current API entry point (as of AMBARI-21307) is
> {{/api/v1/ambariconfigs}}. This should be more inline with the existing entry
> point for Ambari server related data...
> {{/api/v1/services/AMBARI/components/AMBARI_SERVER}}.
> The new API entry point for Ambari server related configuration data should
> be {{/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations}}.
> Example Rest API calls:
> *Create/Set configuration*
> Used to create a new or explicitly set properties an existing Ambari Server
> configuration
> {noformat:title=URL}
> POST /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations
> {noformat}
> {code:title=Payload}
> {
> "Configuration": {
> "category" : "ldap-configuration",
> "properties": {
> "ambari.ldap.bindanonymously": "true",
> "ambari.ldap.server.port": "389",
> "ambari.ldap.base.dn": "dc=example,dc=com",
> "ambari.ldap.user.object.class":"person",
> "ambari.ldap.user.name.attribute":"uid",
> "ambari.ldap.user.search.base": "dc=example,dc=com",
> "ambari.ldap.group.object.class":"groupOfUniqueNames",
> "ambari.ldap.group.name.attribute":"cn",
> "ambari.ldap.group.member.attribute":"uniqueMember",
> "ambari.ldap.group.search.base": "dc=example,dc=com"
> }
> }
> }
> {code}
> *Update configuration*
> Used to update existing properties or add new properties to an existing
> Ambari Server configuration
> {noformat:title=URL}
> PUT
> /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration
> {noformat}
> {code:title=Payload}
> {
> "Configuration": {
> "properties": {
> "ambari.ldap.bindanonymously": "true",
> "ambari.ldap.server.port": "389",
> "ambari.ldap.base.dn": "dc=example,dc=com",
> "ambari.ldap.user.object.class":"person",
> "ambari.ldap.user.name.attribute":"uid",
> "ambari.ldap.user.search.base": "dc=example,dc=com",
> "ambari.ldap.group.object.class":"groupOfUniqueNames",
> "ambari.ldap.group.name.attribute":"cn",
> "ambari.ldap.group.member.attribute":"uniqueMember",
> "ambari.ldap.group.search.base": "dc=example,dc=com"
> }
> }
> }
> {code}
> *Delete configuration*
> Deletes an existing Ambari Server configuration
> {noformat:title=URL}
> DELETE
> /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration
> {noformat}
> *Get configurations*
> Used to retrieve a list of the existing Ambari Server configurations
> {noformat:title=URL}
> GET /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations
> {noformat}
> {code:title=Response}
> {
> "href" :
> "http://c6401.ambari.apache.org:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations;,
> "items" : [
> {
> "href" :
> "http://c6401.ambari.apache.org:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration;,
> "Configuration" : {
> "category" : "ldap-configuration",
> "component_name" : "AMBARI_SERVER",
> "service_name" : "AMBARI"
> }
> }
> ]
> }
> {code}
> *Get configuration*
> Used to retrieve a the details
[jira] [Commented] (AMBARI-22418) Make Ambari configuration API consistent with existing API.
[
https://issues.apache.org/jira/browse/AMBARI-22418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252041#comment-16252041
]
Robert Levas commented on AMBARI-22418:
---
Note: [^AMBARI-22418_trunk_01.patch] fixes a stack advisor issue introduced
with the patch for AMBARI-2234.
> Make Ambari configuration API consistent with existing API.
> ---
>
> Key: AMBARI-22418
> URL: https://issues.apache.org/jira/browse/AMBARI-22418
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 3.0.0
>Reporter: Robert Levas
>Assignee: Robert Levas
> Fix For: 3.0.0
>
> Attachments: AMBARI-22418_trunk_01.patch
>
>
> Make Ambari configuration API consistent with existing API.
> The current API entry point (as of AMBARI-21307) is
> {{/api/v1/ambariconfigs}}. This should be more inline with the existing entry
> point for Ambari server related data...
> {{/api/v1/services/AMBARI/components/AMBARI_SERVER}}.
> The new API entry point for Ambari server related configuration data should
> be {{/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations}}.
> Example Rest API calls:
> *Create/Set configuration*
> Used to create a new or explicitly set properties an existing Ambari Server
> configuration
> {noformat:title=URL}
> POST /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations
> {noformat}
> {code:title=Payload}
> {
> "Configuration": {
> "category" : "ldap-configuration",
> "properties": {
> "ambari.ldap.bindanonymously": "true",
> "ambari.ldap.server.port": "389",
> "ambari.ldap.base.dn": "dc=example,dc=com",
> "ambari.ldap.user.object.class":"person",
> "ambari.ldap.user.name.attribute":"uid",
> "ambari.ldap.user.search.base": "dc=example,dc=com",
> "ambari.ldap.group.object.class":"groupOfUniqueNames",
> "ambari.ldap.group.name.attribute":"cn",
> "ambari.ldap.group.member.attribute":"uniqueMember",
> "ambari.ldap.group.search.base": "dc=example,dc=com"
> }
> }
> }
> {code}
> *Update configuration*
> Used to update existing properties or add new properties to an existing
> Ambari Server configuration
> {noformat:title=URL}
> PUT
> /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration
> {noformat}
> {code:title=Payload}
> {
> "Configuration": {
> "properties": {
> "ambari.ldap.bindanonymously": "true",
> "ambari.ldap.server.port": "389",
> "ambari.ldap.base.dn": "dc=example,dc=com",
> "ambari.ldap.user.object.class":"person",
> "ambari.ldap.user.name.attribute":"uid",
> "ambari.ldap.user.search.base": "dc=example,dc=com",
> "ambari.ldap.group.object.class":"groupOfUniqueNames",
> "ambari.ldap.group.name.attribute":"cn",
> "ambari.ldap.group.member.attribute":"uniqueMember",
> "ambari.ldap.group.search.base": "dc=example,dc=com"
> }
> }
> }
> {code}
> *Delete configuration*
> Deletes an existing Ambari Server configuration
> {noformat:title=URL}
> DELETE
> /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration
> {noformat}
> *Get configurations*
> Used to retrieve a list of the existing Ambari Server configurations
> {noformat:title=URL}
> GET /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations
> {noformat}
> {code:title=Response}
> {
> "href" :
> "http://c6401.ambari.apache.org:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations;,
> "items" : [
> {
> "href" :
> "http://c6401.ambari.apache.org:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration;,
> "Configuration" : {
> "category" : "ldap-configuration",
> "component_name" : "AMBARI_SERVER",
> "service_name" : "AMBARI"
> }
> }
> ]
> }
> {code}
> *Get configuration*
> Used to retrieve a the details about an existing Ambari Server configuration
> {noformat:title=URL}
> GET
> /api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration
> {noformat}
> {code:title=Response}
> {
> "href" :
> "http://c6401.ambari.apache.org:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations/ldap-configuration;,
> "Configuration" : {
> "category" : "ldap-configuration",
> "component_name" : "AMBARI_SERVER",
> "service_name" : "AMBARI",
> "properties" : {
> "ambari.ldap.base.dn" : "dc=example,dc=com",
> "ambari.ldap.bindanonymously" : "true",
> "ambari.ldap.group.member.attribute" : "uniqueMember",
> "ambari.ldap.group.name.attribute" : "cn",
> "ambari.ldap.group.object.class" : "groupOfUniqueNames",
> "ambari.ldap.group.search.base" :
