[jira] [Commented] (ARROW-7804) [C++][R] Compile error on macOS 10.11

2020-02-08 Thread Gawain BOLTON (Jira) 


[ 
https://issues.apache.org/jira/browse/ARROW-7804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032935#comment-17032935
 ] 

Gawain BOLTON commented on ARROW-7804:
--

[~npr]: Sorry didn't see the PR, it looks fine to me!

> [C++][R] Compile error on macOS 10.11
> -
>
> Key: ARROW-7804
> URL: https://issues.apache.org/jira/browse/ARROW-7804
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++, Continuous Integration, R
>Reporter: Neal Richardson
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> So, yeah, macOS 10.11 is from 2015, but that's what CRAN (R) builds on. 
> [~jeroenooms] found this error when building binaries for 0.16:
> {code}
> ==> cmake ../cpp -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG 
> -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG 
> -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/apache-arrow/
> ==> make
> Last 15 lines from /Users/builder/Library/Logs/Homebrew/apache-arrow/02.make:
> /tmp/apache-arrow-20200208-1254-r2avjm/apache-arrow-0.16.0/cpp/src/parquet/stream_writer.h:233:22:
>  error: default initialization of an object of const type 'const 
> parquet::EndRowType' without a user-provided default constructor
> constexpr EndRowType EndRow;
>  ^
>{}
> /tmp/apache-arrow-20200208-1254-r2avjm/apache-arrow-0.16.0/cpp/src/parquet/stream_writer.h:236:27:
>  error: default initialization of an object of const type 'const 
> parquet::EndRowGroupType' without a user-provided default constructor
> constexpr EndRowGroupType EndRowGroup;
>   ^
>  {}
> 2 errors generated.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ARROW-7804) [C++][R] Compile error on macOS 10.11

2020-02-08 Thread Gawain BOLTON (Jira) 


[ 
https://issues.apache.org/jira/browse/ARROW-7804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032928#comment-17032928
 ] 

Gawain BOLTON commented on ARROW-7804:
--

It seems that clang versions < v3.9 have  a bug regarding "const" and 
"constexpr" as can be seen with the following two line code snipet:
{code:java}
struct EndRowType {};
constexpr EndRowType EndRow;{code}
The simplest change I have found is to replace "constexpr" with "extern const" 
but this will require the implementation file to define the constant.

It is not clear to me which compiler versions must be supported so please let 
me know if clang < v3.9 must indeed work with arrow >= v1.0.0

> [C++][R] Compile error on macOS 10.11
> -
>
> Key: ARROW-7804
> URL: https://issues.apache.org/jira/browse/ARROW-7804
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++, Continuous Integration, R
>Reporter: Neal Richardson
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> So, yeah, macOS 10.11 is from 2015, but that's what CRAN (R) builds on. 
> [~jeroenooms] found this error when building binaries for 0.16:
> {code}
> ==> cmake ../cpp -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG 
> -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG 
> -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/apache-arrow/
> ==> make
> Last 15 lines from /Users/builder/Library/Logs/Homebrew/apache-arrow/02.make:
> /tmp/apache-arrow-20200208-1254-r2avjm/apache-arrow-0.16.0/cpp/src/parquet/stream_writer.h:233:22:
>  error: default initialization of an object of const type 'const 
> parquet::EndRowType' without a user-provided default constructor
> constexpr EndRowType EndRow;
>  ^
>{}
> /tmp/apache-arrow-20200208-1254-r2avjm/apache-arrow-0.16.0/cpp/src/parquet/stream_writer.h:236:27:
>  error: default initialization of an object of const type 'const 
> parquet::EndRowGroupType' without a user-provided default constructor
> constexpr EndRowGroupType EndRowGroup;
>   ^
>  {}
> 2 errors generated.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ARROW-7745) [Doc] [C++] Update Parquet documentation

2020-02-02 Thread Gawain BOLTON (Jira) 
Gawain BOLTON created ARROW-7745:


 Summary: [Doc] [C++] Update Parquet documentation
 Key: ARROW-7745
 URL: https://issues.apache.org/jira/browse/ARROW-7745
 Project: Apache Arrow
  Issue Type: Improvement
Reporter: Gawain BOLTON
Assignee: Gawain BOLTON






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ARROW-7294) [Python] converted_type_name_from_enum(): Incorrect name for INT_64

2019-12-02 Thread Gawain BOLTON (Jira) 
Gawain BOLTON created ARROW-7294:


 Summary: [Python] converted_type_name_from_enum(): Incorrect name 
for INT_64
 Key: ARROW-7294
 URL: https://issues.apache.org/jira/browse/ARROW-7294
 Project: Apache Arrow
  Issue Type: Bug
Reporter: Gawain BOLTON
Assignee: Gawain BOLTON


The INT_64 type is converted to "UINT_64"

It should be converted to "INT_64"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ARROW-7178) [C++] Vendor forward compatible std::optional

2019-11-18 Thread Gawain BOLTON (Jira) 


[ 
https://issues.apache.org/jira/browse/ARROW-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976815#comment-16976815
 ] 

Gawain BOLTON commented on ARROW-7178:
--

I would have liked to assign myself this ticket, but it seems I do not have 
permission to do so.

> [C++] Vendor forward compatible std::optional
> -
>
> Key: ARROW-7178
> URL: https://issues.apache.org/jira/browse/ARROW-7178
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Francois Saint-Jacques
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Having std::optional was mentioned a few time, [~emkornfi...@gmail.com] 
> suggested https://github.com/martinmoene/optional-lite



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ARROW-6992) [C++]: Undefined Behavior sanitizer build option fails with GCC

2019-10-25 Thread Gawain BOLTON (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARROW-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gawain BOLTON updated ARROW-6992:
-
Priority: Minor  (was: Major)

> [C++]: Undefined Behavior sanitizer build option fails with GCC
> ---
>
> Key: ARROW-6992
> URL: https://issues.apache.org/jira/browse/ARROW-6992
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Gawain BOLTON
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Then build with the "undefined behaviour sanitizer" option 
> (-DARROW_USE_UBSAN=ON) the compilation fails with GCC:
> {noformat}
> c++: error: unrecognized argument to ‘-fno-sanitize=’ option: 
> ‘function’{noformat}
> It appears that GCC has never had a "-fsanitize=function" option.
> I have fixed this issue and will submit a PR. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ARROW-6992) [C++]: Undefined Behavior sanitizer build option fails with GCC

2019-10-25 Thread Gawain BOLTON (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARROW-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gawain BOLTON updated ARROW-6992:
-
Issue Type: Bug  (was: Improvement)

> [C++]: Undefined Behavior sanitizer build option fails with GCC
> ---
>
> Key: ARROW-6992
> URL: https://issues.apache.org/jira/browse/ARROW-6992
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Gawain BOLTON
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Then build with the "undefined behaviour sanitizer" option 
> (-DARROW_USE_UBSAN=ON) the compilation fails with GCC:
> {noformat}
> c++: error: unrecognized argument to ‘-fno-sanitize=’ option: 
> ‘function’{noformat}
> It appears that GCC has never had a "-fsanitize=function" option.
> I have fixed this issue and will submit a PR. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ARROW-6992) [C++]: Undefined Behavior sanitizer build option fails with GCC

2019-10-25 Thread Gawain BOLTON (Jira) 
Gawain BOLTON created ARROW-6992:


 Summary: [C++]: Undefined Behavior sanitizer build option fails 
with GCC
 Key: ARROW-6992
 URL: https://issues.apache.org/jira/browse/ARROW-6992
 Project: Apache Arrow
  Issue Type: Improvement
  Components: C++
Reporter: Gawain BOLTON


Then build with the "undefined behaviour sanitizer" option 
(-DARROW_USE_UBSAN=ON) the compilation fails with GCC:
{noformat}
c++: error: unrecognized argument to ‘-fno-sanitize=’ option: 
‘function’{noformat}
It appears that GCC has never had a "-fsanitize=function" option.

I have fixed this issue and will submit a PR. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)