[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446829#comment-16446829
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

xhochy commented on issue #1815: ARROW-1325: [R] Bootstrapping R bindings 
subproject
URL: https://github.com/apache/arrow/pull/1815#issuecomment-383301576
 
 
   How's the state of this? Should we do a more in-depth review? Maybe do we 
have a reviewer other than me that has some more R experience?
   
   @romainfrancois If you need any pointers feel free to ask here on the 
mailing list.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425449#comment-16425449
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r179125603
 
 

 ##
 File path: dev/release/rat_exclude_files.txt
 ##
 @@ -52,6 +52,16 @@ python/MANIFEST.in
 python/pyarrow/includes/__init__.pxd
 python/pyarrow/tests/__init__.py
 python/requirements.txt
+r/DESCRIPTION
+r/NAMESPACE
+r/.Rbuildignore
+r/arrow.Rproj
+r/README.Rmd
+r/README.md
 
 Review comment:
   Thanks. ✅


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425401#comment-16425401
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

xhochy commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r179117641
 
 

 ##
 File path: dev/release/rat_exclude_files.txt
 ##
 @@ -52,6 +52,16 @@ python/MANIFEST.in
 python/pyarrow/includes/__init__.pxd
 python/pyarrow/tests/__init__.py
 python/requirements.txt
+r/DESCRIPTION
+r/NAMESPACE
+r/.Rbuildignore
+r/arrow.Rproj
+r/README.Rmd
+r/README.md
 
 Review comment:
   Markdown files support license headers as comments, so there is no need to 
exclude them


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421821#comment-16421821
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178469306
 
 

 ##
 File path: r/src/metadata.cpp
 ##
 @@ -0,0 +1,215 @@
+#include 
+#include "rrrow_types.h"
+
+// [[Rcpp::plugins(cpp11)]]
+
+using namespace Rcpp ;
+
+template 
+xptr_DataType metadata( const std::shared_ptr& ptr, String... 
strings ){
+  xptr_DataType res( new std::shared_ptr(ptr) ) ;
+  res.attr("class") = CharacterVector::create( ptr->name(), strings... ) ;
+  return res ;
+}
+
+xptr_DataType metadata_integer( const std::shared_ptr& ptr ){
+  return metadata( ptr, "arrow::Integer", "arrow::Number", 
"arrow::PrimitiveCType", "arrow::FixedWidthType", "arrow::DataType" ) ;
 
 Review comment:
   See https://github.com/apache/arrow/blob/master/cpp/.clang-format. These 
files do not conform to the C++ code formatting used in the rest of the project


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421715#comment-16421715
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178462473
 
 

 ##
 File path: r/src/metadata.cpp
 ##
 @@ -0,0 +1,215 @@
+#include 
+#include "rrrow_types.h"
+
+// [[Rcpp::plugins(cpp11)]]
+
+using namespace Rcpp ;
+
+template 
+xptr_DataType metadata( const std::shared_ptr& ptr, String... 
strings ){
+  xptr_DataType res( new std::shared_ptr(ptr) ) ;
+  res.attr("class") = CharacterVector::create( ptr->name(), strings... ) ;
+  return res ;
+}
+
+xptr_DataType metadata_integer( const std::shared_ptr& ptr ){
+  return metadata( ptr, "arrow::Integer", "arrow::Number", 
"arrow::PrimitiveCType", "arrow::FixedWidthType", "arrow::DataType" ) ;
 
 Review comment:
   Not sure what you mean


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421712#comment-16421712
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178462392
 
 

 ##
 File path: r/README.Rmd
 ##
 @@ -0,0 +1,69 @@
+---
+output: github_document
+---
+
+
+
+```{r setup, include = FALSE}
+knitr::opts_chunk$set(
+  collapse = TRUE,
+  comment = "#>",
+  fig.path = "man/figures/README-",
+  out.width = "100%"
+)
+```
+# rrrow
+
+rrrow is an R front end to Apache Arrow. 
+
+## Installation
+
+I've only tested this locally for now, here is how I install it, borrowed
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421711#comment-16421711
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178462391
 
 

 ##
 File path: r/README.Rmd
 ##
 @@ -0,0 +1,69 @@
+---
+output: github_document
+---
+
+
+
+```{r setup, include = FALSE}
+knitr::opts_chunk$set(
+  collapse = TRUE,
+  comment = "#>",
+  fig.path = "man/figures/README-",
+  out.width = "100%"
+)
+```
+# rrrow
+
+rrrow is an R front end to Apache Arrow. 
+
+## Installation
+
+I've only tested this locally for now, here is how I install it, borrowed
+from [rarrow](https://github.com/jimhester/rarrow). 
+
+First you need the Arrow C++ library installed
+
+```
+git clone https://github.com/apache/arrow.git
+cd arrow/cpp && mkdir release && cd release
+
+# It is important to statically link to boost libraries
+cmake .. -DCMAKE_BUILD_TYPE=Release -DARROW_BOOST_USE_SHARED:BOOL=Off
 
 Review comment:
   yes definitely. This is wip, I preferred having something that "worked for 
me" first to get started. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421710#comment-16421710
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178462361
 
 

 ##
 File path: r/LICENSE.md
 ##
 @@ -0,0 +1,194 @@
+Apache License
+==
+
+_Version 2.0, January 2004_
+__
+
+### Terms and Conditions for use, reproduction, and distribution
+
+ 1. Definitions
+
+“License” shall mean the terms and conditions for use, reproduction, and
+distribution as defined by Sections 1 through 9 of this document.
+
+“Licensor” shall mean the copyright owner or entity authorized by the copyright
+owner that is granting the License.
+
+“Legal Entity” shall mean the union of the acting entity and all other entities
+that control, are controlled by, or are under common control with that entity.
+For the purposes of this definition, “control” means **(i)** the power, direct 
or
+indirect, to cause the direction or management of such entity, whether by
+contract or otherwise, or **(ii)** ownership of fifty percent (50%) or more of 
the
+outstanding shares, or **(iii)** beneficial ownership of such entity.
+
+“You” (or “Your”) shall mean an individual or Legal Entity exercising
+permissions granted by this License.
+
+“Source” form shall mean the preferred form for making modifications, including
+but not limited to software source code, documentation source, and 
configuration
+files.
+
+“Object” form shall mean any form resulting from mechanical transformation or
+translation of a Source form, including but not limited to compiled object 
code,
+generated documentation, and conversions to other media types.
+
+“Work” shall mean the work of authorship, whether in Source or Object form, 
made
+available under the License, as indicated by a copyright notice that is 
included
+in or attached to the work (an example is provided in the Appendix below).
+
+“Derivative Works” shall mean any work, whether in Source or Object form, that
+is based on (or derived from) the Work and for which the editorial revisions,
+annotations, elaborations, or other modifications represent, as a whole, an
+original work of authorship. For the purposes of this License, Derivative Works
+shall not include works that remain separable from, or merely link (or bind by
+name) to the interfaces of, the Work and Derivative Works thereof.
+
+“Contribution” shall mean any work of authorship, including the original 
version
+of the Work and any modifications or additions to that Work or Derivative Works
+thereof, that is intentionally submitted to Licensor for inclusion in the Work
+by the copyright owner or by an individual or Legal Entity authorized to submit
+on behalf of the copyright owner. For the purposes of this definition,
+“submitted” means any form of electronic, verbal, or written communication sent
+to the Licensor or its representatives, including but not limited to
+communication on electronic mailing lists, source code control systems, and
+issue tracking systems that are managed by, or on behalf of, the Licensor for
+the purpose of discussing and improving the Work, but excluding communication
+that is conspicuously marked or otherwise designated in writing by the 
copyright
+owner as “Not a Contribution.”
+
+“Contributor” shall mean Licensor and any individual or Legal Entity on behalf
+of whom a Contribution has been received by Licensor and subsequently
+incorporated within the Work.
+
+ 2. Grant of Copyright License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable copyright license to reproduce, prepare Derivative Works of,
+publicly display, publicly perform, sublicense, and distribute the Work and 
such
+Derivative Works in Source or Object form.
+
+ 3. Grant of Patent License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable (except as stated in this section) patent license to make, have
+made, use, offer to sell, sell, import, and otherwise transfer the Work, where
+such license applies only to those patent claims licensable by such Contributor
+that are necessarily infringed by their Contribution(s) alone or by combination
+of their Contribution(s) with the Work to which such Contribution(s) was
+submitted. If You institute patent litigation against any entity (including a
+cross-claim or counterclaim in a lawsuit) alleging that the Work or a
+Contribution incorporated within the Work constitutes direct or contributory
+patent infringement, then any patent licenses 

[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421707#comment-16421707
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

romainfrancois commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178462290
 
 

 ##
 File path: r/DESCRIPTION
 ##
 @@ -0,0 +1,22 @@
+Package: rrrow
+Title: Bindings to 'Apache' 'Arrow'
+Version: 0.0.0.9000
+Authors@R: c(
+person("Romain", "François", email = "rom...@purrple.cat", role = c("aut", 
"cre"))
 
 Review comment:
   done, added the ASF as an author and copyright holder


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-04-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421697#comment-16421697
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

russellpierce commented on a change in pull request #1815: ARROW-1325: [R] 
Bootstrapping R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178461709
 
 

 ##
 File path: r/DESCRIPTION
 ##
 @@ -0,0 +1,22 @@
+Package: rrrow
 
 Review comment:
   As a R user in the peanut gallery, I think "arrow" seems great. Especially 
if there isn't a namespace collision on CRAN or bioconductor (I didn't notice 
any with a quick look). For example {tensorflow} and {docker} carry directly 
over from Python, so it makes them easy to remember.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421460#comment-16421460
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440486
 
 

 ##
 File path: r/README.Rmd
 ##
 @@ -0,0 +1,69 @@
+---
+output: github_document
+---
+
+
+
+```{r setup, include = FALSE}
+knitr::opts_chunk$set(
+  collapse = TRUE,
+  comment = "#>",
+  fig.path = "man/figures/README-",
+  out.width = "100%"
+)
+```
+# rrrow
+
+rrrow is an R front end to Apache Arrow. 
+
+## Installation
+
+I've only tested this locally for now, here is how I install it, borrowed
 
 Review comment:
   Remove self-references


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421459#comment-16421459
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440479
 
 

 ##
 File path: r/README.Rmd
 ##
 @@ -0,0 +1,69 @@
+---
+output: github_document
+---
+
+
+
+```{r setup, include = FALSE}
+knitr::opts_chunk$set(
+  collapse = TRUE,
+  comment = "#>",
+  fig.path = "man/figures/README-",
+  out.width = "100%"
+)
+```
+# rrrow
+
+rrrow is an R front end to Apache Arrow. 
+
+## Installation
+
+I've only tested this locally for now, here is how I install it, borrowed
+from [rarrow](https://github.com/jimhester/rarrow). 
+
+First you need the Arrow C++ library installed
+
+```
+git clone https://github.com/apache/arrow.git
+cd arrow/cpp && mkdir release && cd release
+
+# It is important to statically link to boost libraries
+cmake .. -DCMAKE_BUILD_TYPE=Release -DARROW_BOOST_USE_SHARED:BOOL=Off
 
 Review comment:
   This may vary a lot from system to system


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421464#comment-16421464
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440458
 
 

 ##
 File path: r/LICENSE.md
 ##
 @@ -0,0 +1,194 @@
+Apache License
+==
+
+_Version 2.0, January 2004_
+__
+
+### Terms and Conditions for use, reproduction, and distribution
+
+ 1. Definitions
+
+“License” shall mean the terms and conditions for use, reproduction, and
+distribution as defined by Sections 1 through 9 of this document.
+
+“Licensor” shall mean the copyright owner or entity authorized by the copyright
+owner that is granting the License.
+
+“Legal Entity” shall mean the union of the acting entity and all other entities
+that control, are controlled by, or are under common control with that entity.
+For the purposes of this definition, “control” means **(i)** the power, direct 
or
+indirect, to cause the direction or management of such entity, whether by
+contract or otherwise, or **(ii)** ownership of fifty percent (50%) or more of 
the
+outstanding shares, or **(iii)** beneficial ownership of such entity.
+
+“You” (or “Your”) shall mean an individual or Legal Entity exercising
+permissions granted by this License.
+
+“Source” form shall mean the preferred form for making modifications, including
+but not limited to software source code, documentation source, and 
configuration
+files.
+
+“Object” form shall mean any form resulting from mechanical transformation or
+translation of a Source form, including but not limited to compiled object 
code,
+generated documentation, and conversions to other media types.
+
+“Work” shall mean the work of authorship, whether in Source or Object form, 
made
+available under the License, as indicated by a copyright notice that is 
included
+in or attached to the work (an example is provided in the Appendix below).
+
+“Derivative Works” shall mean any work, whether in Source or Object form, that
+is based on (or derived from) the Work and for which the editorial revisions,
+annotations, elaborations, or other modifications represent, as a whole, an
+original work of authorship. For the purposes of this License, Derivative Works
+shall not include works that remain separable from, or merely link (or bind by
+name) to the interfaces of, the Work and Derivative Works thereof.
+
+“Contribution” shall mean any work of authorship, including the original 
version
+of the Work and any modifications or additions to that Work or Derivative Works
+thereof, that is intentionally submitted to Licensor for inclusion in the Work
+by the copyright owner or by an individual or Legal Entity authorized to submit
+on behalf of the copyright owner. For the purposes of this definition,
+“submitted” means any form of electronic, verbal, or written communication sent
+to the Licensor or its representatives, including but not limited to
+communication on electronic mailing lists, source code control systems, and
+issue tracking systems that are managed by, or on behalf of, the Licensor for
+the purpose of discussing and improving the Work, but excluding communication
+that is conspicuously marked or otherwise designated in writing by the 
copyright
+owner as “Not a Contribution.”
+
+“Contributor” shall mean Licensor and any individual or Legal Entity on behalf
+of whom a Contribution has been received by Licensor and subsequently
+incorporated within the Work.
+
+ 2. Grant of Copyright License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable copyright license to reproduce, prepare Derivative Works of,
+publicly display, publicly perform, sublicense, and distribute the Work and 
such
+Derivative Works in Source or Object form.
+
+ 3. Grant of Patent License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable (except as stated in this section) patent license to make, have
+made, use, offer to sell, sell, import, and otherwise transfer the Work, where
+such license applies only to those patent claims licensable by such Contributor
+that are necessarily infringed by their Contribution(s) alone or by combination
+of their Contribution(s) with the Work to which such Contribution(s) was
+submitted. If You institute patent litigation against any entity (including a
+cross-claim or counterclaim in a lawsuit) alleging that the Work or a
+Contribution incorporated within the Work constitutes direct or contributory
+patent infringement, then any patent licenses granted to You 

[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421463#comment-16421463
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440434
 
 

 ##
 File path: r/DESCRIPTION
 ##
 @@ -0,0 +1,22 @@
+Package: rrrow
+Title: Bindings to 'Apache' 'Arrow'
+Version: 0.0.0.9000
+Authors@R: c(
+person("Romain", "François", email = "rom...@purrple.cat", role = c("aut", 
"cre"))
 
 Review comment:
   This should have Apache Arrow / d...@arrow.apache.org in the metadata 
somewhere -- it looks like SparkR and some other projects cite authors other 
than the Apache project 
https://cran.r-project.org/web/packages/SparkR/index.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421462#comment-16421462
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440402
 
 

 ##
 File path: r/DESCRIPTION
 ##
 @@ -0,0 +1,22 @@
+Package: rrrow
 
 Review comment:
   I don't love the name. We should solicit some more feedback about what to 
call the R package (simply "arrow" seems good to me)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421461#comment-16421461
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping 
R bindings subproject
URL: https://github.com/apache/arrow/pull/1815#discussion_r178440517
 
 

 ##
 File path: r/src/metadata.cpp
 ##
 @@ -0,0 +1,215 @@
+#include 
+#include "rrrow_types.h"
+
+// [[Rcpp::plugins(cpp11)]]
+
+using namespace Rcpp ;
+
+template 
+xptr_DataType metadata( const std::shared_ptr& ptr, String... 
strings ){
+  xptr_DataType res( new std::shared_ptr(ptr) ) ;
+  res.attr("class") = CharacterVector::create( ptr->name(), strings... ) ;
+  return res ;
+}
+
+xptr_DataType metadata_integer( const std::shared_ptr& ptr ){
+  return metadata( ptr, "arrow::Integer", "arrow::Number", 
"arrow::PrimitiveCType", "arrow::FixedWidthType", "arrow::DataType" ) ;
 
 Review comment:
   Should we use common clang-format style files for both the C++ codebase and 
the Rcpp files?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-1325) [R] Bootstrap R bindings subproject

2018-03-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421465#comment-16421465
 ] 

ASF GitHub Bot commented on ARROW-1325:
---

wesm commented on issue #1815: ARROW-1325: [R] Bootstrapping R bindings 
subproject
URL: https://github.com/apache/arrow/pull/1815#issuecomment-377719005
 
 
   The build should pass once the code licensing issues are resolved, see 
https://travis-ci.org/apache/arrow/jobs/360550233#L313


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [R] Bootstrap R bindings subproject
> ---
>
> Key: ARROW-1325
> URL: https://issues.apache.org/jira/browse/ARROW-1325
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: R
>Reporter: Clark Fitzgerald
>Assignee: Romain François
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.10.0
>
>
> The R language was designed to perform "Columnar in memory analytics". R / 
> Arrow bindings would be useful for:
> * better compatibility between R and other languages / big data systems
> * chunk-based data parallelism
> * portable and efficient IO via Parquet
> R has a C++ interface so the natural way to write these bindings is to 
> leverage Arrow's C++ library as much as possible.
> Feather provides a starting point: 
> [https://github.com/wesm/feather/tree/master/R].
> This can serve as an umbrella JIRA for work on R related tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)