[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173882#comment-16173882 ] ASF GitHub Bot commented on ARROW-1500: --- Github user amirma commented on the issue: https://github.com/apache/arrow/pull/1116 Fixed lint errors. > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173082#comment-16173082 ] ASF GitHub Bot commented on ARROW-1500: --- Github user wesm commented on the issue: https://github.com/apache/arrow/pull/1116 This is failing with cpplint warnings ``` /home/travis/build/apache/arrow/cpp/src/arrow/io/file.cc:138: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] /home/travis/build/apache/arrow/cpp/src/arrow/io/file.cc:610: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] ``` you can use `make lint` to run the lint checks locally > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172769#comment-16172769 ] ASF GitHub Bot commented on ARROW-1500: --- Github user amirma commented on the issue: https://github.com/apache/arrow/pull/1116 @wesm Rebased. > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172744#comment-16172744 ] ASF GitHub Bot commented on ARROW-1500: --- Github user wesm commented on the issue: https://github.com/apache/arrow/pull/1116 Can you rebase? Not sure why there's a merge conflict now > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172525#comment-16172525 ] ASF GitHub Bot commented on ARROW-1500: --- Github user amirma commented on the issue: https://github.com/apache/arrow/pull/1116 @wesm Bah, I just noticed my patch has a bug; if truncate fails we will leak the file handle. I just resubmitted a fixed version. Thanks. > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1500) [C++] Result of ftruncate ignored in MemoryMappedFile::Create
[ https://issues.apache.org/jira/browse/ARROW-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172433#comment-16172433 ] ASF GitHub Bot commented on ARROW-1500: --- Github user wesm commented on the issue: https://github.com/apache/arrow/pull/1116 Thanks, the Travis CI tubes are a bit clogged today so I may not be able to merge until later tonight or tomorrow morning > [C++] Result of ftruncate ignored in MemoryMappedFile::Create > - > > Key: ARROW-1500 > URL: https://issues.apache.org/jira/browse/ARROW-1500 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Assignee: Amir Malekpour > Labels: pull-request-available > Fix For: 0.8.0 > > > Observed in gcc 5.4.0 release build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
