[jira] [Commented] (ARROW-1820) [C++] Create arrow_compute shared library subcomponent

2017-11-17 Thread Wes McKinney (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257115#comment-16257115
 ] 

Wes McKinney commented on ARROW-1820:
-

Sounds good to me

> [C++] Create arrow_compute shared library subcomponent
> --
>
> Key: ARROW-1820
> URL: https://issues.apache.org/jira/browse/ARROW-1820
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
> Fix For: 0.8.0
>
>
> I think it would be good to do this before we get in too deep. 
> {{libarrow_python}} will need to link to this library



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1820) [C++] Create arrow_compute shared library subcomponent

2017-11-17 Thread Uwe L. Korn (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256734#comment-16256734
 ] 

Uwe L. Korn commented on ARROW-1820:


I would prefer the {{-DARROW_COMPUTE=off}} for now. This makes packaging a bit 
simpler.

> [C++] Create arrow_compute shared library subcomponent
> --
>
> Key: ARROW-1820
> URL: https://issues.apache.org/jira/browse/ARROW-1820
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
> Fix For: 0.8.0
>
>
> I think it would be good to do this before we get in too deep. 
> {{libarrow_python}} will need to link to this library



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1820) [C++] Create arrow_compute shared library subcomponent

2017-11-16 Thread Wes McKinney (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256025#comment-16256025
 ] 

Wes McKinney commented on ARROW-1820:
-

An alternative is that the compute code can either be on or off 
({{-DARROW_COMPUTE=off}}). I would be OK with this

> [C++] Create arrow_compute shared library subcomponent
> --
>
> Key: ARROW-1820
> URL: https://issues.apache.org/jira/browse/ARROW-1820
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
> Fix For: 0.8.0
>
>
> I think it would be good to do this before we get in too deep. 
> {{libarrow_python}} will need to link to this library



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1820) [C++] Create arrow_compute shared library subcomponent

2017-11-16 Thread Uwe L. Korn (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255037#comment-16255037
 ] 

Uwe L. Korn commented on ARROW-1820:


Can we do this or will we have cyclic dependencies between builders and kernels 
in the future?

> [C++] Create arrow_compute shared library subcomponent
> --
>
> Key: ARROW-1820
> URL: https://issues.apache.org/jira/browse/ARROW-1820
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
> Fix For: 0.8.0
>
>
> I think it would be good to do this before we get in too deep. 
> {{libarrow_python}} will need to link to this library



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)