[jira] [Commented] (ARROW-2003) [Python] Do not use deprecated kwarg in pandas.core.internals.make_block
[ https://issues.apache.org/jira/browse/ARROW-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339399#comment-16339399 ] ASF GitHub Bot commented on ARROW-2003: --- wesm closed pull request #1507: ARROW-2003: [Python] Remove use of fastpath parameter to pandas.core.internals.make_block URL: https://github.com/apache/arrow/pull/1507 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/python/pyarrow/pandas_compat.py b/python/pyarrow/pandas_compat.py index f3089d2a0..4a30fb3b4 100644 --- a/python/pyarrow/pandas_compat.py +++ b/python/pyarrow/pandas_compat.py @@ -435,13 +435,12 @@ def _reconstruct_block(item): categories=item['dictionary'], ordered=item['ordered']) block = _int.make_block(cat, placement=placement, -klass=_int.CategoricalBlock, -fastpath=True) +klass=_int.CategoricalBlock) elif 'timezone' in item: dtype = _make_datetimetz(item['timezone']) block = _int.make_block(block_arr, placement=placement, klass=_int.DatetimeTZBlock, -dtype=dtype, fastpath=True) +dtype=dtype) else: block = _int.make_block(block_arr, placement=placement) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Do not use deprecated kwarg in pandas.core.internals.make_block > > > Key: ARROW-2003 > URL: https://issues.apache.org/jira/browse/ARROW-2003 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Wes McKinney >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > see bug report in [https://github.com/apache/arrow/issues/1484] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2003) [Python] Do not use deprecated kwarg in pandas.core.internals.make_block
[ https://issues.apache.org/jira/browse/ARROW-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339397#comment-16339397 ] ASF GitHub Bot commented on ARROW-2003: --- wesm commented on issue #1507: ARROW-2003: [Python] Remove use of fastpath parameter to pandas.core.internals.make_block URL: https://github.com/apache/arrow/pull/1507#issuecomment-360503746 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Do not use deprecated kwarg in pandas.core.internals.make_block > > > Key: ARROW-2003 > URL: https://issues.apache.org/jira/browse/ARROW-2003 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Wes McKinney >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > see bug report in [https://github.com/apache/arrow/issues/1484] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2003) [Python] Do not use deprecated kwarg in pandas.core.internals.make_block
[ https://issues.apache.org/jira/browse/ARROW-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338531#comment-16338531 ] ASF GitHub Bot commented on ARROW-2003: --- wesm commented on issue #1507: ARROW-2003: [Python] Remove use of fastpath parameter to pandas.core.internals.make_block URL: https://github.com/apache/arrow/pull/1507#issuecomment-360328472 cool, thanks @jreback! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Do not use deprecated kwarg in pandas.core.internals.make_block > > > Key: ARROW-2003 > URL: https://issues.apache.org/jira/browse/ARROW-2003 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Wes McKinney >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > see bug report in [https://github.com/apache/arrow/issues/1484] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2003) [Python] Do not use deprecated kwarg in pandas.core.internals.make_block
[ https://issues.apache.org/jira/browse/ARROW-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338482#comment-16338482 ] ASF GitHub Bot commented on ARROW-2003: --- jreback commented on issue #1507: ARROW-2003: [Python] Remove use of fastpath parameter to pandas.core.internals.make_block URL: https://github.com/apache/arrow/pull/1507#issuecomment-360320333 we are deprecating for back compat but it is not used anyhow This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Do not use deprecated kwarg in pandas.core.internals.make_block > > > Key: ARROW-2003 > URL: https://issues.apache.org/jira/browse/ARROW-2003 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Wes McKinney >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > see bug report in [https://github.com/apache/arrow/issues/1484] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2003) [Python] Do not use deprecated kwarg in pandas.core.internals.make_block
[ https://issues.apache.org/jira/browse/ARROW-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338466#comment-16338466 ] ASF GitHub Bot commented on ARROW-2003: --- wesm opened a new pull request #1507: ARROW-2003: [Python] Remove use of fastpath parameter to pandas.core.internals.make_block URL: https://github.com/apache/arrow/pull/1507 Apparently this argument is not used at all in pandas, and the pandas developers wish to simply remove the argument rather than go through a deprecation cycle This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Do not use deprecated kwarg in pandas.core.internals.make_block > > > Key: ARROW-2003 > URL: https://issues.apache.org/jira/browse/ARROW-2003 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Wes McKinney >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > see bug report in [https://github.com/apache/arrow/issues/1484] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
