[jira] [Commented] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu
[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580379#comment-16580379 ] Dimitri Vorona commented on ARROW-3051: --- In that case copy-elision won't work either [http://cpp.sh/3x25h] . Even worse: while using const reference with temporary gives a correct behaviour, it disables RVO, since it isn't specified to work on references (see returnNoisy[2-4]). > [C++] Status performance optimization from Impala/Kudu > -- > > Key: ARROW-3051 > URL: https://issues.apache.org/jira/browse/ARROW-3051 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.11.0 > > > Just saw this patch, worth investigating: > https://github.com/apache/impala/commit/ea615d1d8026dbe1cda3f5c2b048d210b2df435b -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu
[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580232#comment-16580232 ] Dimitri Vorona commented on ARROW-3051: --- If I understand it correctly, there is an abseil tip of the week about exact same thing: https://abseil.io/tips/101 TL;DR Modern compilers will apply RVO, so there isn't any performance difference. > [C++] Status performance optimization from Impala/Kudu > -- > > Key: ARROW-3051 > URL: https://issues.apache.org/jira/browse/ARROW-3051 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.11.0 > > > Just saw this patch, worth investigating: > https://github.com/apache/impala/commit/ea615d1d8026dbe1cda3f5c2b048d210b2df435b -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu
[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580138#comment-16580138 ] Antoine Pitrou commented on ARROW-3051: --- I don't really buy the "small optimization" - where is a copy constructor involved? At least I'd like to see some benchmark numbers. [~cpcloud] > [C++] Status performance optimization from Impala/Kudu > -- > > Key: ARROW-3051 > URL: https://issues.apache.org/jira/browse/ARROW-3051 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.11.0 > > > Just saw this patch, worth investigating: > https://github.com/apache/impala/commit/ea615d1d8026dbe1cda3f5c2b048d210b2df435b -- This message was sent by Atlassian JIRA (v7.6.3#76005)
