[jira] [Commented] (ARROW-3133) [C++] Logical boolean kernels in kernels/boolean.cc cannot write into preallocated memory
[ https://issues.apache.org/jira/browse/ARROW-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729118#comment-16729118 ] Wes McKinney commented on ARROW-3133: - It's not urgent so feel free to have a hack at it. You can also break the task into smaller pieces / PRs if you like > [C++] Logical boolean kernels in kernels/boolean.cc cannot write into > preallocated memory > - > > Key: ARROW-3133 > URL: https://issues.apache.org/jira/browse/ARROW-3133 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-3133) [C++] Logical boolean kernels in kernels/boolean.cc cannot write into preallocated memory
[ https://issues.apache.org/jira/browse/ARROW-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729111#comment-16729111 ] Micah Kornfield commented on ARROW-3133: Missed those. If this isn't urgent I can take a look at fixing this. I will have only a few hours per week to work on it so progress might be a liitle slow. On Wednesday, December 26, 2018, Wes McKinney (JIRA) > [C++] Logical boolean kernels in kernels/boolean.cc cannot write into > preallocated memory > - > > Key: ARROW-3133 > URL: https://issues.apache.org/jira/browse/ARROW-3133 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-3133) [C++] Logical boolean kernels in kernels/boolean.cc cannot write into preallocated memory
[ https://issues.apache.org/jira/browse/ARROW-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729096#comment-16729096 ] Wes McKinney commented on ARROW-3133: - No, there is unavoidable memory allocation in all of the kernels: * InvertKernel: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L64 * Binary: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L100 * And: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L116 etc. this needs to be refactored to decouple memory allocation from kernel invocation > [C++] Logical boolean kernels in kernels/boolean.cc cannot write into > preallocated memory > - > > Key: ARROW-3133 > URL: https://issues.apache.org/jira/browse/ARROW-3133 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-3133) [C++] Logical boolean kernels in kernels/boolean.cc cannot write into preallocated memory
[ https://issues.apache.org/jira/browse/ARROW-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728833#comment-16728833 ] Micah Kornfield commented on ARROW-3133: is the issue this is trying to address the hard-coded: out->value = ArrayData::Make(boolean(), right_data.length)? Is the fix to check if the output already has an array >= appropriate size and use that instead? > [C++] Logical boolean kernels in kernels/boolean.cc cannot write into > preallocated memory > - > > Key: ARROW-3133 > URL: https://issues.apache.org/jira/browse/ARROW-3133 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
