[jira] [Commented] (ARROW-3910) [Python] Set date_as_object to True in *.to_pandas as default after deduplicating logic implemented

2019-01-16 Thread Jim Crist (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744144#comment-16744144
 ] 

Jim Crist commented on ARROW-3910:
--

I'm just trying to determine if we should also output objects for dates by 
default as well, and if so it'd be easiest if `pa.date32().to_pandas_dtype()` 
returned object, as that's our current code path. It's easy for us to 
explicitly set `date_as_object=False`, but it sounds like we should be using 
objects here instead of datetime64s.

> [Python] Set date_as_object to True in *.to_pandas as default after 
> deduplicating logic implemented
> ---
>
> Key: ARROW-3910
> URL: https://issues.apache.org/jira/browse/ARROW-3910
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Python
>Reporter: Wes McKinney
>Assignee: Wes McKinney
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.12.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> See discussion in ARROW-3899



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARROW-3910) [Python] Set date_as_object to True in *.to_pandas as default after deduplicating logic implemented

2019-01-16 Thread Wes McKinney (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744139#comment-16744139
 ] 

Wes McKinney commented on ARROW-3910:
-

Yes, that should be changed (though depending on what argument is passed it 
still can be datetime64). Might consider a different code path to obtaining the 
pandas "schema" 

> [Python] Set date_as_object to True in *.to_pandas as default after 
> deduplicating logic implemented
> ---
>
> Key: ARROW-3910
> URL: https://issues.apache.org/jira/browse/ARROW-3910
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Python
>Reporter: Wes McKinney
>Assignee: Wes McKinney
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.12.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> See discussion in ARROW-3899



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARROW-3910) [Python] Set date_as_object to True in *.to_pandas as default after deduplicating logic implemented

2019-01-15 Thread Jim Crist (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743412#comment-16743412
 ] 

Jim Crist commented on ARROW-3910:
--

Should `to_pandas_dtype()` return object dtype for date types as well?

```
In [1]: import pyarrow as pa

In [2]: pa.date32().to_pandas_dtype()
Out[2]: dtype(' [Python] Set date_as_object to True in *.to_pandas as default after 
> deduplicating logic implemented
> ---
>
> Key: ARROW-3910
> URL: https://issues.apache.org/jira/browse/ARROW-3910
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Python
>Reporter: Wes McKinney
>Assignee: Wes McKinney
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.12.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> See discussion in ARROW-3899



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)