[jira] [Commented] (ARROW-5062) [Java] Shade Java Guava dependency for Flight
[ https://issues.apache.org/jira/browse/ARROW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809310#comment-16809310 ] Jacques Nadeau commented on ARROW-5062: --- Hey [~bryanc], we should have as second shaded version as opposed to adding guava to existing one. > [Java] Shade Java Guava dependency for Flight > - > > Key: ARROW-5062 > URL: https://issues.apache.org/jira/browse/ARROW-5062 > Project: Apache Arrow > Issue Type: Improvement > Components: FlightRPC, Java >Reporter: Bryan Cutler >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > The Guava dependency in the Java Flight module can interfere if using Flight > in an application that relies on an older version of Guava. We can shade the > usage in Flight to prevent this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5062) [Java] Shade Java Guava dependency for Flight
[ https://issues.apache.org/jira/browse/ARROW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805446#comment-16805446 ] Bryan Cutler commented on ARROW-5062: - [~jnadeau] so there is already a shaded jar that shades protocol buffers, do you mean add another shaded jar? flight/target/arrow-flight-0.13.0-SNAPSHOT-shaded.jar flight/target/arrow-flight-0.13.0-SNAPSHOT-jar-with-dependencies.jar flight/target/arrow-flight-0.13.0-SNAPSHOT.jar > [Java] Shade Java Guava dependency for Flight > - > > Key: ARROW-5062 > URL: https://issues.apache.org/jira/browse/ARROW-5062 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Bryan Cutler >Priority: Major > > The Guava dependency in the Java Flight module can interfere if using Flight > in an application that relies on an older version of Guava. We can shade the > usage in Flight to prevent this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5062) [Java] Shade Java Guava dependency for Flight
[ https://issues.apache.org/jira/browse/ARROW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804397#comment-16804397 ] Jacques Nadeau commented on ARROW-5062: --- Let's just add a second artifact with guava shaded as well (rather than replace the existing one). Would prefer to avoid doubling loading/storing where we don't need to with a large artifact. > [Java] Shade Java Guava dependency for Flight > - > > Key: ARROW-5062 > URL: https://issues.apache.org/jira/browse/ARROW-5062 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Bryan Cutler >Priority: Major > > The Guava dependency in the Java Flight module can interfere if using Flight > in an application that relies on an older version of Guava. We can shade the > usage in Flight to prevent this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5062) [Java] Shade Java Guava dependency for Flight
[ https://issues.apache.org/jira/browse/ARROW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804376#comment-16804376 ] Bryan Cutler commented on ARROW-5062: - I ran into an issue when trying Flight with Apache Spark, which uses an old version of Guava. Spark can be built with Guava shaded using mvn but not sbt, so it's not a blocker but still kind of a pain. [~jacq...@dremio.com] does this sound ok with you? > [Java] Shade Java Guava dependency for Flight > - > > Key: ARROW-5062 > URL: https://issues.apache.org/jira/browse/ARROW-5062 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Bryan Cutler >Priority: Major > > The Guava dependency in the Java Flight module can interfere if using Flight > in an application that relies on an older version of Guava. We can shade the > usage in Flight to prevent this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
