[jira] [Commented] (ARROW-5192) [C++] Bundled gRPC fails building (cannot find c-ares)

2019-04-25 Thread Wes McKinney (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826520#comment-16826520
 ] 

Wes McKinney commented on ARROW-5192:
-

The workaround doesn't work so it will have to be patched in gRPC. Here's my 
attempt

https://github.com/wesm/arrow/tree/ARROW-5192

> [C++] Bundled gRPC fails building (cannot find c-ares)
> --
>
> Key: ARROW-5192
> URL: https://issues.apache.org/jira/browse/ARROW-5192
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Antoine Pitrou
>Assignee: Wes McKinney
>Priority: Major
>
> If I try to build Arrow C++ without a conda toolchain, I get the following 
> error when gRPC is being built by the cmake files:
> {code}
> CMake Error at cmake/cares.cmake:38 (find_package):
>   Could not find a package configuration file provided by "c-ares" with any
>   of the following names:
> c-aresConfig.cmake
> c-ares-config.cmake
>   Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
>   "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
>   provides a separate development package or SDK, be sure it has been
>   installed.
> Call Stack (most recent call first):
>   CMakeLists.txt:139 (include)
> {code}
> It seems c-ares is found by the following line in ThirdPartyToolchain.cmake:
> {code}
> find_package(c-aresAlt)
> {code}
> But gRPC doesn't pick it up...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-5192) [C++] Bundled gRPC fails building (cannot find c-ares)

2019-04-25 Thread Wes McKinney (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826509#comment-16826509
 ] 

Wes McKinney commented on ARROW-5192:
-

here's the offending line in gRPC

https://github.com/grpc/grpc/blob/master/cmake/cares.cmake#L38

> [C++] Bundled gRPC fails building (cannot find c-ares)
> --
>
> Key: ARROW-5192
> URL: https://issues.apache.org/jira/browse/ARROW-5192
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Antoine Pitrou
>Assignee: Wes McKinney
>Priority: Major
>
> If I try to build Arrow C++ without a conda toolchain, I get the following 
> error when gRPC is being built by the cmake files:
> {code}
> CMake Error at cmake/cares.cmake:38 (find_package):
>   Could not find a package configuration file provided by "c-ares" with any
>   of the following names:
> c-aresConfig.cmake
> c-ares-config.cmake
>   Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
>   "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
>   provides a separate development package or SDK, be sure it has been
>   installed.
> Call Stack (most recent call first):
>   CMakeLists.txt:139 (include)
> {code}
> It seems c-ares is found by the following line in ThirdPartyToolchain.cmake:
> {code}
> find_package(c-aresAlt)
> {code}
> But gRPC doesn't pick it up...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-5192) [C++] Bundled gRPC fails building (cannot find c-ares)

2019-04-25 Thread Wes McKinney (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826508#comment-16826508
 ] 

Wes McKinney commented on ARROW-5192:
-

So the gRPC build system can't find the pkgconfig file produced by the c-ares 
autotools build, because it's called "libcares.pc"

{code}
17:18 ~/code/arrow/cpp/flight-scratch  (ARROW-5219)$ pkg-config --libs 
c-aresPackage c-ares was not found in the pkg-config search path.
Perhaps you should add the directory containing `c-ares.pc'
to the PKG_CONFIG_PATH environment variable
No package 'c-ares' found
17:18 ~/code/arrow/cpp/flight-scratch  (ARROW-5219)$ pkg-config --libs libcares
-lcares  
{code}

This problem confirmed by https://stackoverflow.com/a/54819108/776560

gRPC should really fix this, but it seems like kludging by passing 

{{-D_gRPC_CARES_LIBRARIES=something -D_gRPC_CARES_INCLUDE_DIR=something}}

will solve the problem for now

> [C++] Bundled gRPC fails building (cannot find c-ares)
> --
>
> Key: ARROW-5192
> URL: https://issues.apache.org/jira/browse/ARROW-5192
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Antoine Pitrou
>Assignee: Wes McKinney
>Priority: Major
>
> If I try to build Arrow C++ without a conda toolchain, I get the following 
> error when gRPC is being built by the cmake files:
> {code}
> CMake Error at cmake/cares.cmake:38 (find_package):
>   Could not find a package configuration file provided by "c-ares" with any
>   of the following names:
> c-aresConfig.cmake
> c-ares-config.cmake
>   Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
>   "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
>   provides a separate development package or SDK, be sure it has been
>   installed.
> Call Stack (most recent call first):
>   CMakeLists.txt:139 (include)
> {code}
> It seems c-ares is found by the following line in ThirdPartyToolchain.cmake:
> {code}
> find_package(c-aresAlt)
> {code}
> But gRPC doesn't pick it up...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-5192) [C++] Bundled gRPC fails building (cannot find c-ares)

2019-04-25 Thread Antoine Pitrou (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826505#comment-16826505
 ] 

Antoine Pitrou commented on ARROW-5192:
---

You probably mean "{{-Dc-ares_SOURCE=BUNDLED".}}

> [C++] Bundled gRPC fails building (cannot find c-ares)
> --
>
> Key: ARROW-5192
> URL: https://issues.apache.org/jira/browse/ARROW-5192
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Antoine Pitrou
>Assignee: Wes McKinney
>Priority: Major
>
> If I try to build Arrow C++ without a conda toolchain, I get the following 
> error when gRPC is being built by the cmake files:
> {code}
> CMake Error at cmake/cares.cmake:38 (find_package):
>   Could not find a package configuration file provided by "c-ares" with any
>   of the following names:
> c-aresConfig.cmake
> c-ares-config.cmake
>   Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
>   "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
>   provides a separate development package or SDK, be sure it has been
>   installed.
> Call Stack (most recent call first):
>   CMakeLists.txt:139 (include)
> {code}
> It seems c-ares is found by the following line in ThirdPartyToolchain.cmake:
> {code}
> find_package(c-aresAlt)
> {code}
> But gRPC doesn't pick it up...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-5192) [C++] Bundled gRPC fails building (cannot find c-ares)

2019-04-25 Thread Wes McKinney (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826500#comment-16826500
 ] 

Wes McKinney commented on ARROW-5192:
-

I'm able to reproduce this; it's only a problem when {{libc-ares-dev}} is 
installed in the system (on Ubuntu 14.04 here). If c-ares is also bundled then 
there is no problem

{{cmake .. -GNinja -DgRPC_SOURCE=BUNDLED -DARROW_FLIGHT=ON}}

> [C++] Bundled gRPC fails building (cannot find c-ares)
> --
>
> Key: ARROW-5192
> URL: https://issues.apache.org/jira/browse/ARROW-5192
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Antoine Pitrou
>Assignee: Wes McKinney
>Priority: Major
>
> If I try to build Arrow C++ without a conda toolchain, I get the following 
> error when gRPC is being built by the cmake files:
> {code}
> CMake Error at cmake/cares.cmake:38 (find_package):
>   Could not find a package configuration file provided by "c-ares" with any
>   of the following names:
> c-aresConfig.cmake
> c-ares-config.cmake
>   Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
>   "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
>   provides a separate development package or SDK, be sure it has been
>   installed.
> Call Stack (most recent call first):
>   CMakeLists.txt:139 (include)
> {code}
> It seems c-ares is found by the following line in ThirdPartyToolchain.cmake:
> {code}
> find_package(c-aresAlt)
> {code}
> But gRPC doesn't pick it up...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)