[jira] [Commented] (ARROW-5194) [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing
[ https://issues.apache.org/jira/browse/ARROW-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826137#comment-16826137 ] Guillaume Horel commented on ARROW-5194: Sure, I'll send it to github? > [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing > > > Key: ARROW-5194 > URL: https://issues.apache.org/jira/browse/ARROW-5194 > Project: Apache Arrow > Issue Type: Test > Components: C++ - Plasma >Affects Versions: 0.13.0 >Reporter: Guillaume Horel >Priority: Critical > > I believe the > [assertions|https://github.com/apache/arrow/blob/master/cpp/src/plasma/test/serialization_tests.cc#L191] > here are incorrect. You can't use memcmp to compare structs > On my machine (64bits linux) int are 4 bytes, but the struct fields are 8 > bytes aligned, so this line fails: > ASSERT_EQ(memcmp(_objects[object_ids[0]], _objects_return[0], > sizeof(PlasmaObject)), > 0); > even though the struct contents are the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5194) [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing
[ https://issues.apache.org/jira/browse/ARROW-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826138#comment-16826138 ] Wes McKinney commented on ARROW-5194: - Yep https://github.com/apache/arrow/blob/master/docs/source/developers/contributing.rst > [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing > > > Key: ARROW-5194 > URL: https://issues.apache.org/jira/browse/ARROW-5194 > Project: Apache Arrow > Issue Type: Test > Components: C++ - Plasma >Affects Versions: 0.13.0 >Reporter: Guillaume Horel >Priority: Critical > > I believe the > [assertions|https://github.com/apache/arrow/blob/master/cpp/src/plasma/test/serialization_tests.cc#L191] > here are incorrect. You can't use memcmp to compare structs > On my machine (64bits linux) int are 4 bytes, but the struct fields are 8 > bytes aligned, so this line fails: > ASSERT_EQ(memcmp(_objects[object_ids[0]], _objects_return[0], > sizeof(PlasmaObject)), > 0); > even though the struct contents are the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5194) [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing
[ https://issues.apache.org/jira/browse/ARROW-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826064#comment-16826064 ] Wes McKinney commented on ARROW-5194: - Would you like to submit a pull request? > [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing > > > Key: ARROW-5194 > URL: https://issues.apache.org/jira/browse/ARROW-5194 > Project: Apache Arrow > Issue Type: Test > Components: C++ - Plasma >Affects Versions: 0.13.0 >Reporter: Guillaume Horel >Priority: Critical > > I believe the > [assertions|https://github.com/apache/arrow/blob/master/cpp/src/plasma/test/serialization_tests.cc#L191] > here are incorrect. You can't use memcmp to compare structs > On my machine (64bits linux) int are 4 bytes, but the struct fields are 8 > bytes aligned, so this line fails: > ASSERT_EQ(memcmp(_objects[object_ids[0]], _objects_return[0], > sizeof(PlasmaObject)), > 0); > even though the struct contents are the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
