[jira] [Commented] (ARROW-5196) [C++] Uniform usage of Google cpu_features library accross the codebase
[ https://issues.apache.org/jira/browse/ARROW-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826263#comment-16826263 ] Antoine Pitrou commented on ARROW-5196: --- No, AppVeyor builds normally succeed. > [C++] Uniform usage of Google cpu_features library accross the codebase > --- > > Key: ARROW-5196 > URL: https://issues.apache.org/jira/browse/ARROW-5196 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Areg Melik-Adamyan >Assignee: Areg Melik-Adamyan >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.0 > > Original Estimate: 2h > Time Spent: 1h 10m > Remaining Estimate: 50m > > Is there any objection to use the Google's standard cpu_features library > [https://github.com/google/cpu_features] instead of > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h]. > So far it has been used in 3 place only which can be easily changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5196) [C++] Uniform usage of Google cpu_features library accross the codebase
[ https://issues.apache.org/jira/browse/ARROW-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826253#comment-16826253 ] Areg Melik-Adamyan commented on ARROW-5196: --- Ok, I'll add to third_party, and re-engineer the PR. BTW, [~pitrou] AppVeyor fails to build due to some problem with doubel_conversion library, I don't see it locally neither on Windows nor on Linux, is this a glitch on AppVeyor? > [C++] Uniform usage of Google cpu_features library accross the codebase > --- > > Key: ARROW-5196 > URL: https://issues.apache.org/jira/browse/ARROW-5196 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Areg Melik-Adamyan >Assignee: Areg Melik-Adamyan >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.0 > > Original Estimate: 2h > Time Spent: 1h > Remaining Estimate: 1h > > Is there any objection to use the Google's standard cpu_features library > [https://github.com/google/cpu_features] instead of > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h]. > So far it has been used in 3 place only which can be easily changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5196) [C++] Uniform usage of Google cpu_features library accross the codebase
[ https://issues.apache.org/jira/browse/ARROW-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826025#comment-16826025 ] Wes McKinney commented on ARROW-5196: - It's not necessary to preserve the API. IIRC it originated from Apache Impala https://github.com/apache/impala/blob/master/be/src/util/cpu-info.h > [C++] Uniform usage of Google cpu_features library accross the codebase > --- > > Key: ARROW-5196 > URL: https://issues.apache.org/jira/browse/ARROW-5196 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Areg Melik-Adamyan >Assignee: Areg Melik-Adamyan >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.0 > > Original Estimate: 2h > Time Spent: 10m > Remaining Estimate: 1h 50m > > Is there any objection to use the Google's standard cpu_features library > [https://github.com/google/cpu_features] instead of > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h]. > So far it has been used in 3 place only which can be easily changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5196) [C++] Uniform usage of Google cpu_features library accross the codebase
[ https://issues.apache.org/jira/browse/ARROW-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825775#comment-16825775 ] Areg Melik-Adamyan commented on ARROW-5196: --- I started to clean up the CpuInfo, which seems overdesigned - do you want to preserve the existing API, which is not used anywhere, or we can move to cpu_features API wrappers? > [C++] Uniform usage of Google cpu_features library accross the codebase > --- > > Key: ARROW-5196 > URL: https://issues.apache.org/jira/browse/ARROW-5196 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Areg Melik-Adamyan >Assignee: Areg Melik-Adamyan >Priority: Minor > Fix For: 0.14.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > Is there any objection to use the Google's standard cpu_features library > [https://github.com/google/cpu_features] instead of > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h]. > So far it has been used in 3 place only which can be easily changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5196) [C++] Uniform usage of Google cpu_features library accross the codebase
[ https://issues.apache.org/jira/browse/ARROW-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824101#comment-16824101 ] Wes McKinney commented on ARROW-5196: - It seems small enough that we may add it to arrow/vendored rather than introducing another thirdparty library to manage > [C++] Uniform usage of Google cpu_features library accross the codebase > --- > > Key: ARROW-5196 > URL: https://issues.apache.org/jira/browse/ARROW-5196 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Areg Melik-Adamyan >Assignee: Areg Melik-Adamyan >Priority: Minor > Fix For: 0.14.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > Is there any objection to use the Google's standard cpu_features library > [https://github.com/google/cpu_features] instead of > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h]. > So far it has been used in 3 place only which can be easily changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
