[jira] [Commented] (ARROW-6633) [C++] Do not require double-conversion for default build
[ https://issues.apache.org/jira/browse/ARROW-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948879#comment-16948879 ] Wes McKinney commented on ARROW-6633: - (for the record, I was **not** proposing to parse string to double without the assistance of double-conversion) > [C++] Do not require double-conversion for default build > > > Key: ARROW-6633 > URL: https://issues.apache.org/jira/browse/ARROW-6633 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 1.0.0 > > > This library is only needed in core builds if > * ARROW_JSON=on or > * ARROW_CSV=on (option to be added) or > * ARROW_BUILD_TESTS=on > The double conversion headers leak into > * arrow/util/decimal.h -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6633) [C++] Do not require double-conversion for default build
[ https://issues.apache.org/jira/browse/ARROW-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948878#comment-16948878 ] Wes McKinney commented on ARROW-6633: - double-conversion is small and simple enough that we might consider putting it in arrow/vendored to avoid the transitive toolchain dependency. > [C++] Do not require double-conversion for default build > > > Key: ARROW-6633 > URL: https://issues.apache.org/jira/browse/ARROW-6633 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 1.0.0 > > > This library is only needed in core builds if > * ARROW_JSON=on or > * ARROW_CSV=on (option to be added) or > * ARROW_BUILD_TESTS=on > The double conversion headers leak into > * arrow/util/decimal.h -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6633) [C++] Do not require double-conversion for default build
[ https://issues.apache.org/jira/browse/ARROW-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948363#comment-16948363 ] Antoine Pitrou commented on ARROW-6633: --- Uh, not being able to parse doubles in a locale-agnostic way is quite restrictive. double-conversion is now used for casting double to string, by the way, so ARROW_COMPUTE=on requires it. > [C++] Do not require double-conversion for default build > > > Key: ARROW-6633 > URL: https://issues.apache.org/jira/browse/ARROW-6633 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Priority: Major > Fix For: 1.0.0 > > > This library is only needed in core builds if > * ARROW_JSON=on or > * ARROW_CSV=on (option to be added) or > * ARROW_BUILD_TESTS=on > The double conversion headers leak into > * arrow/util/decimal.h -- This message was sent by Atlassian Jira (v8.3.4#803005)
