[jira] [Commented] (ARROW-6821) [C++][Parquet] Do not require Thrift compiler when building (but still require library)

2020-01-08 Thread Neal Richardson (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010830#comment-17010830
 ] 

Neal Richardson commented on ARROW-6821:


Yes please. I'm happy to help with this, though I'd need a little direction for 
what to put where (and then presumably there's a {{THRIFT_CMAKE_ARGS}} to add 
or remove).

> [C++][Parquet] Do not require Thrift compiler when building (but still 
> require library)
> ---
>
> Key: ARROW-6821
> URL: https://issues.apache.org/jira/browse/ARROW-6821
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.16.0
>
>
> Building Thrift from source carries extra toolchain dependencies (bison and 
> flex). If we check in the files produced by compiling parquet.thrift, then 
> the EP can be simplified to only build the Thrift C++ library and not the 
> compiler. This also results in a simpler build for third parties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6821) [C++][Parquet] Do not require Thrift compiler when building (but still require library)

2020-01-07 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010197#comment-17010197
 ] 

Wes McKinney commented on ARROW-6821:
-

cc [~npr]

> [C++][Parquet] Do not require Thrift compiler when building (but still 
> require library)
> ---
>
> Key: ARROW-6821
> URL: https://issues.apache.org/jira/browse/ARROW-6821
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.16.0
>
>
> Building Thrift from source carries extra toolchain dependencies (bison and 
> flex). If we check in the files produced by compiling parquet.thrift, then 
> the EP can be simplified to only build the Thrift C++ library and not the 
> compiler. This also results in a simpler build for third parties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)