[jira] [Commented] (ARROW-6871) [Java] Enhance TransferPair related parameters check and tests
[
https://issues.apache.org/jira/browse/ARROW-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950754#comment-16950754
]
Ji Liu commented on ARROW-6871:
---
Thanks for your reminder, I will also add a benchmark, if there's no much
regression, params check is needed/corrected to avoid potential problems.
> [Java] Enhance TransferPair related parameters check and tests
> --
>
> Key: ARROW-6871
> URL: https://issues.apache.org/jira/browse/ARROW-6871
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Major
>
> {{TransferPair}} related param checks in different classes have potential
> problems:
> i. {{copyValueSafe}} do not check from index, if from > valueCount, no error
> is shown.
> ii. {{splitAndTansfer}} has no indices check in classes like {{VarcharVector}}
> iii. {{splitAndTranser}} indices check in classes like UnionVector is not
> correct (Preconditions.checkArgument(startIndex + length <= valueCount)),
> should check params separately.
> iv. some assert usages should be replaced with {{Preconditions}}.
> v. should add more UT to cover corner cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-6871) [Java] Enhance TransferPair related parameters check and tests
[
https://issues.apache.org/jira/browse/ARROW-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950711#comment-16950711
]
Liya Fan commented on ARROW-6871:
-
+1 for adding more UT to test corner cases.
Please note that some of the operations are performance critical, so please pay
attention to the performance impacts.
> [Java] Enhance TransferPair related parameters check and tests
> --
>
> Key: ARROW-6871
> URL: https://issues.apache.org/jira/browse/ARROW-6871
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Major
>
> {{TransferPair}} related param checks in different classes have potential
> problems:
> i. {{copyValueSafe}} do not check from index, if from > valueCount, no error
> is shown.
> ii. {{splitAndTansfer}} has no indices check in classes like {{VarcharVector}}
> iii. {{splitAndTranser}} indices check in classes like UnionVector is not
> correct (Preconditions.checkArgument(startIndex + length <= valueCount)),
> should check params separately.
> iv. some assert usages should be replaced with {{Preconditions}}.
> v. should add more UT to cover corner cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
