[jira] [Commented] (ARROW-7056) [Python] test errors without S3

2019-11-04 Thread Antoine Pitrou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966926#comment-16966926
 ] 

Antoine Pitrou commented on ARROW-7056:
---

The problem seems to be that a function like 
{{test_non_path_like_input_raises}} has an empty markers dict, even when it's 
parametered with {{S3FileSystem}}.

> [Python] test errors without S3
> ---
>
> Key: ARROW-7056
> URL: https://issues.apache.org/jira/browse/ARROW-7056
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Python
>Affects Versions: 0.15.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> When running the tests I get errors like this:
> {code}
> ___ ERROR at setup of 
> test_non_path_like_input_raises[S3FileSystem] 
> 
> Traceback (most recent call last):
>   File "/home/antoine/arrow/dev/python/pyarrow/tests/test_fs.py", line 57, in 
> s3fs
> from pyarrow.s3fs import S3Options, S3FileSystem
>   File "/home/antoine/arrow/dev/python/pyarrow/s3fs.py", line 20, in 
> from pyarrow._s3fs import (  # noqa
> ModuleNotFoundError: No module named 'pyarrow._s3fs'
> {code}
> It seems that those tests should be automatically skipped if S3 support isn't 
> enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-7056) [Python] test errors without S3

2019-11-04 Thread Antoine Pitrou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966927#comment-16966927
 ] 

Antoine Pitrou commented on ARROW-7056:
---

I think we should ditch the pytest magic and use regular Python.

> [Python] test errors without S3
> ---
>
> Key: ARROW-7056
> URL: https://issues.apache.org/jira/browse/ARROW-7056
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Python
>Affects Versions: 0.15.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> When running the tests I get errors like this:
> {code}
> ___ ERROR at setup of 
> test_non_path_like_input_raises[S3FileSystem] 
> 
> Traceback (most recent call last):
>   File "/home/antoine/arrow/dev/python/pyarrow/tests/test_fs.py", line 57, in 
> s3fs
> from pyarrow.s3fs import S3Options, S3FileSystem
>   File "/home/antoine/arrow/dev/python/pyarrow/s3fs.py", line 20, in 
> from pyarrow._s3fs import (  # noqa
> ModuleNotFoundError: No module named 'pyarrow._s3fs'
> {code}
> It seems that those tests should be automatically skipped if S3 support isn't 
> enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-7056) [Python] test errors without S3

2019-11-04 Thread Antoine Pitrou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966838#comment-16966838
 ] 

Antoine Pitrou commented on ARROW-7056:
---

After a cleanup, I'm not seeing any failures anymore. Probably something had 
got cached along the way...

> [Python] test errors without S3
> ---
>
> Key: ARROW-7056
> URL: https://issues.apache.org/jira/browse/ARROW-7056
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Python
>Affects Versions: 0.15.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> When running the tests I get errors like this:
> {code}
> ___ ERROR at setup of 
> test_non_path_like_input_raises[S3FileSystem] 
> 
> Traceback (most recent call last):
>   File "/home/antoine/arrow/dev/python/pyarrow/tests/test_fs.py", line 57, in 
> s3fs
> from pyarrow.s3fs import S3Options, S3FileSystem
>   File "/home/antoine/arrow/dev/python/pyarrow/s3fs.py", line 20, in 
> from pyarrow._s3fs import (  # noqa
> ModuleNotFoundError: No module named 'pyarrow._s3fs'
> {code}
> It seems that those tests should be automatically skipped if S3 support isn't 
> enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-7056) [Python] test errors without S3

2019-11-04 Thread Krisztian Szucs (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966759#comment-16966759
 ] 

Krisztian Szucs commented on ARROW-7056:


[~apitrou] the fixture is marked with 
[S3|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_fs.py#L54]
 which is set 
[False|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/conftest.py#L77]
 by default, so it should not try to run the S3 related tests.

Could you check what is the pytest option's value?

> [Python] test errors without S3
> ---
>
> Key: ARROW-7056
> URL: https://issues.apache.org/jira/browse/ARROW-7056
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Python
>Affects Versions: 0.15.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> When running the tests I get errors like this:
> {code}
> ___ ERROR at setup of 
> test_non_path_like_input_raises[S3FileSystem] 
> 
> Traceback (most recent call last):
>   File "/home/antoine/arrow/dev/python/pyarrow/tests/test_fs.py", line 57, in 
> s3fs
> from pyarrow.s3fs import S3Options, S3FileSystem
>   File "/home/antoine/arrow/dev/python/pyarrow/s3fs.py", line 20, in 
> from pyarrow._s3fs import (  # noqa
> ModuleNotFoundError: No module named 'pyarrow._s3fs'
> {code}
> It seems that those tests should be automatically skipped if S3 support isn't 
> enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)