[jira] [Commented] (ARROW-8173) [C++] Validate ChunkedArray()'s arguments
[
https://issues.apache.org/jira/browse/ARROW-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116246#comment-17116246
]
Wes McKinney commented on ARROW-8173:
-
{{ChunkedArray::MakeSafe}}?
> [C++] Validate ChunkedArray()'s arguments
> -
>
> Key: ARROW-8173
> URL: https://issues.apache.org/jira/browse/ARROW-8173
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.16.0
>Reporter: Ben Kietzman
>Priority: Major
> Fix For: 1.0.0
>
>
> ChunkedArray has constraints on type uniformity of chunks which are currently
> only expressed in comments. At minimum debug checks should be added to ensure
> (for example) that an explicit type is shared by all chunks, at best the
> public constructor should be replaced with
> {{Result> ChunkedArray::Make(...)}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8173) [C++] Validate ChunkedArray()'s arguments
[
https://issues.apache.org/jira/browse/ARROW-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065033#comment-17065033
]
Joris Van den Bossche commented on ARROW-8173:
--
There are {{ChunkedArray::Validate}} and {{ValidateFull}} methods that check
this (eg in python this is called in some of the constructors)
> [C++] Validate ChunkedArray()'s arguments
> -
>
> Key: ARROW-8173
> URL: https://issues.apache.org/jira/browse/ARROW-8173
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.16.0
>Reporter: Ben Kietzman
>Priority: Major
> Fix For: 1.0.0
>
>
> ChunkedArray has constraints on type uniformity of chunks which are currently
> only expressed in comments. At minimum debug checks should be added to ensure
> (for example) that an explicit type is shared by all chunks, at best the
> public constructor should be replaced with
> {{Result> ChunkedArray::Make(...)}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
