[jira] [Commented] (ARROW-8283) [Python][Dataset] Non-existent files are silently dropped in pa.dataset.FileSystemDataset
[
https://issues.apache.org/jira/browse/ARROW-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133307#comment-17133307
]
Francois Saint-Jacques commented on ARROW-8283:
---
Correct, we should not touch `get_file_info` when we have a list of paths.
> [Python][Dataset] Non-existent files are silently dropped in
> pa.dataset.FileSystemDataset
> -
>
> Key: ARROW-8283
> URL: https://issues.apache.org/jira/browse/ARROW-8283
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
>Reporter: Uwe Korn
>Assignee: Joris Van den Bossche
>Priority: Critical
> Labels: dataset
> Fix For: 1.0.0
>
>
> When passing a list of files to the constructor of
> {{pyarrow.dataset.FileSystemDataset}}, all files that don't exist are
> silently dropped immediately (i.e. no fragments are created for them).
> Instead, I would expect that fragments will be created for them but an error
> is thrown when one tries to read the fragment with the non-existent file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8283) [Python][Dataset] Non-existent files are silently dropped in pa.dataset.FileSystemDataset
[
https://issues.apache.org/jira/browse/ARROW-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133064#comment-17133064
]
Joris Van den Bossche commented on ARROW-8283:
--
Ah, indeed. We maybe could still accept a list of paths, we then only to turn
them into a FileFragment without checking. In any case we should probably avoid
the filesystem interaction with {{filesystem.get_file_info(..)}}.
> [Python][Dataset] Non-existent files are silently dropped in
> pa.dataset.FileSystemDataset
> -
>
> Key: ARROW-8283
> URL: https://issues.apache.org/jira/browse/ARROW-8283
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
>Reporter: Uwe Korn
>Priority: Critical
> Labels: dataset
> Fix For: 1.0.0
>
>
> When passing a list of files to the constructor of
> {{pyarrow.dataset.FileSystemDataset}}, all files that don't exist are
> silently dropped immediately (i.e. no fragments are created for them).
> Instead, I would expect that fragments will be created for them but an error
> is thrown when one tries to read the fragment with the non-existent file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8283) [Python][Dataset] Non-existent files are silently dropped in pa.dataset.FileSystemDataset
[
https://issues.apache.org/jira/browse/ARROW-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128383#comment-17128383
]
Francois Saint-Jacques commented on ARROW-8283:
---
[~jorisvandenbossche] This filtering is done on the [python
side.|https://github.com/apache/arrow/blob/master/python/pyarrow/_dataset.pyx#L458-L478]
This is due to the fact that the FileSystemDataset constructor accepts a
path_or_selector.
> [Python][Dataset] Non-existent files are silently dropped in
> pa.dataset.FileSystemDataset
> -
>
> Key: ARROW-8283
> URL: https://issues.apache.org/jira/browse/ARROW-8283
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
>Reporter: Uwe Korn
>Assignee: Francois Saint-Jacques
>Priority: Critical
> Labels: dataset
> Fix For: 1.0.0
>
>
> When passing a list of files to the constructor of
> {{pyarrow.dataset.FileSystemDataset}}, all files that don't exist are
> silently dropped immediately (i.e. no fragments are created for them).
> Instead, I would expect that fragments will be created for them but an error
> is thrown when one tries to read the fragment with the non-existent file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
