[jira] [Updated] (ARROW-2701) [C++] Make MemoryMappedFile resizable
[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2701: -- External issue URL: https://github.com/apache/arrow/pull/2205 (was: https://github.com/apache/arrow/pull/2134) > [C++] Make MemoryMappedFile resizable > - > > Key: ARROW-2701 > URL: https://issues.apache.org/jira/browse/ARROW-2701 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Affects Versions: 0.9.0 >Reporter: Dimitri Vorona >Priority: Major > Labels: pull-request-available > Time Spent: 9h 40m > Remaining Estimate: 0h > > Hi, > I don't see any reason for the MemoryMappedFile not to be resizable, e.g. > like it is in Python stdlib. This patch changes the base class of > MemoryMappedFile to ResizableBuffer and implements mmap resizing similar to > [mmap.resize|https://github.com/python/cpython/blob/415bc46a78e785f357c8960ae70f18a6b6cccbb6/Modules/mmapmodule.c#L454] > from python stdlib. > If the change is ok, we should probably change the comment > [here|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_io.py#L577], > too. > Cheers, > Dimitri. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARROW-2701) [C++] Make MemoryMappedFile resizable
[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ARROW-2701: -- Labels: pull-request-available (was: ) > [C++] Make MemoryMappedFile resizable > - > > Key: ARROW-2701 > URL: https://issues.apache.org/jira/browse/ARROW-2701 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Affects Versions: 0.9.0 >Reporter: Dimitri Vorona >Priority: Major > Labels: pull-request-available > > Hi, > I don't see any reason for the MemoryMappedFile not to be resizable, e.g. > like it is in Python stdlib. This patch changes the base class of > MemoryMappedFile to ResizableBuffer and implements mmap resizing similar to > [mmap.resize|https://github.com/python/cpython/blob/415bc46a78e785f357c8960ae70f18a6b6cccbb6/Modules/mmapmodule.c#L454] > from python stdlib. > If the change is ok, we should probably change the comment > [here|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_io.py#L577], > too. > Cheers, > Dimitri. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARROW-2701) [C++] Make MemoryMappedFile resizable
[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2701: -- External issue URL: https://github.com/apache/arrow/pull/2134 > [C++] Make MemoryMappedFile resizable > - > > Key: ARROW-2701 > URL: https://issues.apache.org/jira/browse/ARROW-2701 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Affects Versions: 0.9.0 >Reporter: Dimitri Vorona >Priority: Major > > Hi, > I don't see any reason for the MemoryMappedFile not to be resizable, e.g. > like it is in Python stdlib. This patch changes the base class of > MemoryMappedFile to ResizableBuffer and implements mmap resizing similar to > [mmap.resize|https://github.com/python/cpython/blob/415bc46a78e785f357c8960ae70f18a6b6cccbb6/Modules/mmapmodule.c#L454] > from python stdlib. > If the change is ok, we should probably change the comment > [here|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_io.py#L577], > too. > Cheers, > Dimitri. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
