[jira] [Updated] (ARROW-5973) [Java] Variable width vectors' get methods should return null when the underlying data is null
[ https://issues.apache.org/jira/browse/ARROW-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated ARROW-5973: Labels: behavior-changes pull-request-available (was: pull-request-available) > [Java] Variable width vectors' get methods should return null when the > underlying data is null > -- > > Key: ARROW-5973 > URL: https://issues.apache.org/jira/browse/ARROW-5973 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: behavior-changes, pull-request-available > Fix For: 1.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > For variable-width vectors (VarCharVector and VarBinaryVector), when the > validity bit is not set, it means the underlying data is null, so the get > method should return null. > However, the current implementation throws an IllegalStateException when > NULL_CHECKING_ENABLED is set, or returns an empty array when the flag is > clear. > Maybe the purpose of this design is to be consistent with fixed-width > vectors. However, the scenario is different: fixed-width vectors (e.g. > IntVector) throw an IllegalStateException, simply because the primitive types > are non-nullable. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-5973) [Java] Variable width vectors' get methods should return null when the underlying data is null
[ https://issues.apache.org/jira/browse/ARROW-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ARROW-5973: -- Labels: pull-request-available (was: ) > [Java] Variable width vectors' get methods should return null when the > underlying data is null > -- > > Key: ARROW-5973 > URL: https://issues.apache.org/jira/browse/ARROW-5973 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > > For variable-width vectors (VarCharVector and VarBinaryVector), when the > validity bit is not set, it means the underlying data is null, so the get > method should return null. > However, the current implementation throws an IllegalStateException when > NULL_CHECKING_ENABLED is set, or returns an empty array when the flag is > clear. > Maybe the purpose of this design is to be consistent with fixed-width > vectors. However, the scenario is different: fixed-width vectors (e.g. > IntVector) throw an IllegalStateException, simply because the primitive types > are non-nullable. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-5973) [Java] Variable width vectors' get methods should return null when the underlying data is null
[ https://issues.apache.org/jira/browse/ARROW-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated ARROW-5973: Summary: [Java] Variable width vectors' get methods should return null when the underlying data is null (was: [Java] Variable width vectors' get methods should return return null when the underlying data is null) > [Java] Variable width vectors' get methods should return null when the > underlying data is null > -- > > Key: ARROW-5973 > URL: https://issues.apache.org/jira/browse/ARROW-5973 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > > For variable-width vectors (VarCharVector and VarBinaryVector), when the > validity bit is not set, it means the underlying data is null, so the get > method should return null. > However, the current implementation throws an IllegalStateException when > NULL_CHECKING_ENABLED is set, or returns an empty array when the flag is > clear. > Maybe the purpose of this design is to be consistent with fixed-width > vectors. However, the scenario is different: fixed-width vectors (e.g. > IntVector) throw an IllegalStateException, simply because the primitive types > are non-nullable. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
