[jira] [Updated] (ARROW-85) C++: memcmp can be avoided in Equal when comparing with the same Buffer
[ https://issues.apache.org/jira/browse/ARROW-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated ARROW-85: Component/s: C++ > C++: memcmp can be avoided in Equal when comparing with the same Buffer > --- > > Key: ARROW-85 > URL: https://issues.apache.org/jira/browse/ARROW-85 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Kai Zheng >Assignee: Kai Zheng >Priority: Major > Fix For: 0.1.0 > > > It looks too expensive to use memcmp to compare two buffers. Instead, the > starting address and length/capacity would be good enough to use. Higher > level codes relying on memcmp behaviour can be done in higher level. > Update: memcmp should be avoided in Equal when comparing with the same > Buffer. In other cases, it's still needed to know the content are the same or > not. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARROW-85) C++: memcmp can be avoided in Equal when comparing with the same Buffer
[ https://issues.apache.org/jira/browse/ARROW-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng updated ARROW-85: --- Assignee: Kai Zheng > C++: memcmp can be avoided in Equal when comparing with the same Buffer > --- > > Key: ARROW-85 > URL: https://issues.apache.org/jira/browse/ARROW-85 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Kai Zheng >Assignee: Kai Zheng > > It looks too expensive to use memcmp to compare two buffers. Instead, the > starting address and length/capacity would be good enough to use. Higher > level codes relying on memcmp behaviour can be done in higher level. > Update: memcmp should be avoided in Equal when comparing with the same > Buffer. In other cases, it's still needed to know the content are the same or > not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARROW-85) C++: memcmp can be avoided in Equal when comparing with the same Buffer
[ https://issues.apache.org/jira/browse/ARROW-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng updated ARROW-85: --- Description: It looks too expensive to use memcmp to compare two buffers. Instead, the starting address and length/capacity would be good enough to use. Higher level codes relying on memcmp behaviour can be done in higher level. Update: memcmp should be avoided in Equal when comparing with the same Buffer. In other cases, it's still needed to know the content are the same or not. was:It looks too expensive to use memcmp to compare two buffers. Instead, the starting address and length/capacity would be good enough to use. Higher level codes relying on memcmp behaviour can be done in higher level. > C++: memcmp can be avoided in Equal when comparing with the same Buffer > --- > > Key: ARROW-85 > URL: https://issues.apache.org/jira/browse/ARROW-85 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Kai Zheng > > It looks too expensive to use memcmp to compare two buffers. Instead, the > starting address and length/capacity would be good enough to use. Higher > level codes relying on memcmp behaviour can be done in higher level. > Update: memcmp should be avoided in Equal when comparing with the same > Buffer. In other cases, it's still needed to know the content are the same or > not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
