[jira] [Commented] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758709#comment-17758709
]
ASF subversion and git services commented on AVRO-3844:
---
Commit a09d3fd4419d453537c63ab030667365114bd761 in avro's branch
refs/heads/dependabot/cargo/lang/rust/master/serde-1.0.186 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a09d3fd44 ]
AVRO-3844: [Rust] Fix clippy errors with Rust 1.72.0 (#2466)
Signed-off-by: Martin Tzvetanov Grigorov
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758708#comment-17758708
]
ASF subversion and git services commented on AVRO-3844:
---
Commit 7f9bbd9d8a1c4f5d47e8d73b4c212b243c7c1b37 in avro's branch
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7f9bbd9d8 ]
AVRO-3844: [Rust] Fix clippy errors with Rust 1.72.0 (#2466)
Signed-off-by: Martin Tzvetanov Grigorov
(cherry picked from commit a09d3fd4419d453537c63ab030667365114bd761)
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Tzvetanov Grigorov resolved AVRO-3844.
-
Fix Version/s: 1.12.0
1.11.3
Resolution: Fixed
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758707#comment-17758707
]
ASF subversion and git services commented on AVRO-3844:
---
Commit a09d3fd4419d453537c63ab030667365114bd761 in avro's branch
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a09d3fd44 ]
AVRO-3844: [Rust] Fix clippy errors with Rust 1.72.0 (#2466)
Signed-off-by: Martin Tzvetanov Grigorov
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758694#comment-17758694
]
ASF subversion and git services commented on AVRO-3844:
---
Commit 99cee3003524958e21ef1bbf311b5bc47072f724 in avro's branch
refs/heads/avro-3844-fix-1.72.0-clippy-errors from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=99cee3003 ]
AVRO-3844: [Rust] Fix clippy errors with Rust 1.72.0
Signed-off-by: Martin Tzvetanov Grigorov
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AVRO-3844:
-
Labels: pull-request-available (was: )
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758683#comment-17758683
]
ASF subversion and git services commented on AVRO-3844:
---
Commit 623d09e072060eb8e9623775f5c04dcb7d5af0cc in avro's branch
refs/heads/avro-3844-fix-1.72.0-clippy-errors from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=623d09e07 ]
AVRO-3844: [Rust] Fix clippy errors with Rust 1.72.0
Signed-off-by: Martin Tzvetanov Grigorov
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (AVRO-3844) [Rust] Fix clippy errors with Rust 1.72.0
[
https://issues.apache.org/jira/browse/AVRO-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Tzvetanov Grigorov reassigned AVRO-3844:
---
> [Rust] Fix clippy errors with Rust 1.72.0
> -
>
> Key: AVRO-3844
> URL: https://issues.apache.org/jira/browse/AVRO-3844
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> The newly releases Rust 1.72.0 produces the following clippy errors:
> {code:java}
> Checking apache-avro v0.16.0 (/home/martin/git/apache/avro/lang/rust/avro)
> error: useless use of `vec!`
> --> avro/src/schema_compatibility.rs:296:16
> |
> 296 | && vec![SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]
> |
> ^ help: you can
> use an array directly: `[SchemaKind::Long, SchemaKind::Float,
> SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error:
> useless use of `vec!`
> --> avro/src/schema_compatibility.rs:304:16
> |
> 304 | && vec![SchemaKind::Float, SchemaKind::Double]
> | ^^^ help: you
> can use an array directly: `[SchemaKind::Float, SchemaKind::Double]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vecerror:
> could not compile `apache-avro` (lib) due to 2 previous errors
> warning: build failed, waiting for other jobs to finish...
> error: useless use of `vec!`
> --> avro/src/reader.rs:891:25
> |
> 891 | let to_read_1 = vec![0xC3, 0x01];
> | help: you can use an array
> directly: `[0xC3, 0x01]`
> |
>
> error: useless use of `vec!`
> --> avro/tests/io.rs:151:30
> |
> 151 | let promotable_schemas = vec![r#""int""#, r#""long""#,
> r#""float""#, r#""double""#];
> |
> ^^ help: you can use
> an array directly: `[r#""int""#, r#""long""#, r#""float""#, r#""double""#]`
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
> = note: `-D clippy::useless-vec` implied by `-D clippy::all`error: could
> not compile `apache-avro` (test "io") due to previous error
> warning: build failed, waiting for other jobs to finish...
> error: explicit call to `.into_iter()` in function argument accepting
> `IntoIterator`
> --> avro/src/writer.rs:675:25
> |
> 675 | expected.extend([b'f', b'o', b'o'].into_iter());
> | ^^ help: consider
> removing the `.into_iter()`: `[b'f', b'o', b'o']`
> |
> note: this parameter accepts any `IntoIterator`, so you don't need to call
> `.into_iter()`
> -->
> /home/martin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:18
> |
> 377 | fn extend>( self, iter: T);
> | ^^
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> = note: `-D clippy::useless-conversion` implied by `-D clippy::all`{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3830) Handle namespace properly if a name starts with dot
[
https://issues.apache.org/jira/browse/AVRO-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758680#comment-17758680
]
Kousuke Saruta commented on AVRO-3830:
--
[~stestagg]
Hmm, will you fix that issue by yourself?
> Handle namespace properly if a name starts with dot
> ---
>
> Key: AVRO-3830
> URL: https://issues.apache.org/jira/browse/AVRO-3830
> Project: Apache Avro
> Issue Type: Bug
>Affects Versions: 1.12.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The specification says about the name and namespace like as follows.
> ??The empty string may also be used as a namespace to indicate the null
> namespace??
> ??If the name specified contains a dot, then it is assumed to be a fullname,
> and any namespace also specified is ignored??
> According to this specification, if a name in a name field starts with a dot,
> it's considered that the namespace is null and the corresponding namespace
> field should be ignored.
> For example, given the following schema.
> {code}
> {
> "name": ".record1",
> "namespace": "ns1",
> "type": "record",
> "fields": []
> }
> {code}
> The name and namespace should be "record1" and null respectively.
> But the namespace is considered as "ns1" in the current Rust binding .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
