Re: [PR] AVRO-1524: avro-maven-plugin be able to generate schema from IDL [avro]
databius commented on PR #2568: URL: https://github.com/apache/avro/pull/2568#issuecomment-1790006266 Thanks for your comment. Just pushed some updates. Please help to take a look if you have time @opwvhk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (AVRO-3897) Disallow invalid namespace in fully qualified name for Rust SDK
[
https://issues.apache.org/jira/browse/AVRO-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kousuke Saruta updated AVRO-3897:
-
Description:
Currently, the Rust SDK allows the following fully qualified names with
Name::new.
{code}
Name::new("ns.0.record1")
Name::new("ns..record1")
{code}
But they should be disallowed according to the specification.
https://avro.apache.org/docs/1.11.1/specification/#names
{code}
The name portion of the fullname of named types, record field names, and enum
symbols must:
start with [A-Za-z_]
subsequently contain only [A-Za-z0-9_]
{code}
{code}
The null namespace may not be used in a dot-separated sequence of names. So the
grammar for a namespace is:
| [()*]
{code}
was:
Currently, the Rust SDK allows the following fully qualified names with
Name::new.
{code}
Name::new("ns.0.record1")
Name::new("ns..record1")
{code}
But they should be disallowed according to the specification.
> Disallow invalid namespace in fully qualified name for Rust SDK
> ---
>
> Key: AVRO-3897
> URL: https://issues.apache.org/jira/browse/AVRO-3897
> Project: Apache Avro
> Issue Type: Bug
> Components: rust
>Reporter: Kousuke Saruta
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the Rust SDK allows the following fully qualified names with
> Name::new.
> {code}
> Name::new("ns.0.record1")
> Name::new("ns..record1")
> {code}
> But they should be disallowed according to the specification.
> https://avro.apache.org/docs/1.11.1/specification/#names
> {code}
> The name portion of the fullname of named types, record field names, and enum
> symbols must:
> start with [A-Za-z_]
> subsequently contain only [A-Za-z0-9_]
> {code}
> {code}
> The null namespace may not be used in a dot-separated sequence of names. So
> the grammar for a namespace is:
>| [()*]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3897) Disallow invalid namespace in fully qualified name for Rust SDK
[
https://issues.apache.org/jira/browse/AVRO-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781733#comment-17781733
]
Martin Tzvetanov Grigorov commented on AVRO-3897:
-
Please cite the specification where it says that the examples above are invalid.
> Disallow invalid namespace in fully qualified name for Rust SDK
> ---
>
> Key: AVRO-3897
> URL: https://issues.apache.org/jira/browse/AVRO-3897
> Project: Apache Avro
> Issue Type: Bug
> Components: rust
>Reporter: Kousuke Saruta
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the Rust SDK allows the following fully qualified names with
> Name::new.
> {code}
> Name::new("ns.0.record1")
> Name::new("ns..record1")
> {code}
> But they should be disallowed according to the specification.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Minor: Fix an error in running ./build.sh docker [avro]
martin-g commented on PR #2571: URL: https://github.com/apache/avro/pull/2571#issuecomment-1788673353 Thank you, @sarutak ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (AVRO-3861) [Build] Add RAT exclusions for python docs
[
https://issues.apache.org/jira/browse/AVRO-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Tzvetanov Grigorov resolved AVRO-3861.
-
Fix Version/s: 1.12.0
1.11.4
Assignee: Kousuke Saruta
Resolution: Fixed
> [Build] Add RAT exclusions for python docs
> --
>
> Key: AVRO-3861
> URL: https://issues.apache.org/jira/browse/AVRO-3861
> Project: Apache Avro
> Issue Type: Bug
> Components: build
>Affects Versions: 1.12.0, 1.11.3
>Reporter: Ryan Skraba
>Assignee: Kousuke Saruta
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When following the release process and doing a *./build.sh clean test dist*
> we get the following error:
> {code}
> [INFO] --- apache-rat-plugin:0.15:check (default) @ avro-toplevel ---
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [INFO] Rat check: Summary over all files. Unapproved: 17, unknown: 17,
> generated: 0, approved: 1580 licenses.
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [WARNING] Files with unapproved licenses:
> lang/py/docs/build/html/searchindex.js
> lang/py/docs/build/html/.buildinfo
> lang/py/docs/build/html/search.html
> lang/py/docs/build/html/py-modindex.html
> lang/py/docs/build/html/genindex.html
> lang/py/docs/build/html/intro.html
> lang/py/docs/build/html/index.html
> lang/py/docs/build/html/automodule.html
> lang/py/docs/build/html/_static/alabaster.css
> lang/py/docs/build/html/_static/custom.css
> lang/py/docs/build/html/_static/basic.css
> lang/py/docs/build/html/_static/doctools.js
> lang/py/docs/build/html/_static/documentation_options.js
> lang/py/docs/build/html/_static/language_data.js
> lang/py/docs/build/html/_static/searchtools.js
> lang/py/docs/build/html/_static/sphinx_highlight.js
> lang/py/docs/build/html/_static/pygments.css
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 4.428 s
> [INFO] Finished at: 2023-09-20T12:50:06Z
> [INFO]
>
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check
> (default) on project avro-toplevel: Too many files with unapproved license:
> 17 See RAT report in: /home/ryan.skraba/avro/target/rat.txt -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
> The workaround is to do a `./build.sh clean test` followed by a `./build.sh
> clean dist`, but this should probably be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] AVRO-3861: [Build] Add RAT exclusions for python docs [avro]
martin-g commented on PR #2572: URL: https://github.com/apache/avro/pull/2572#issuecomment-1788670589 Thank you, @sarutak ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (AVRO-3861) [Build] Add RAT exclusions for python docs
[
https://issues.apache.org/jira/browse/AVRO-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781676#comment-17781676
]
ASF subversion and git services commented on AVRO-3861:
---
Commit 08200a5ad260d5db0edf2991462c481eac0c309b in avro's branch
refs/heads/branch-1.11 from Kousuke Saruta
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=08200a5ad ]
AVRO-3861: [Build] Add RAT exclusions for python docs (#2572)
(cherry picked from commit 8fda42aa289c590a703fe9529f5d7303e3327d66)
> [Build] Add RAT exclusions for python docs
> --
>
> Key: AVRO-3861
> URL: https://issues.apache.org/jira/browse/AVRO-3861
> Project: Apache Avro
> Issue Type: Bug
> Components: build
>Affects Versions: 1.12.0, 1.11.3
>Reporter: Ryan Skraba
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When following the release process and doing a *./build.sh clean test dist*
> we get the following error:
> {code}
> [INFO] --- apache-rat-plugin:0.15:check (default) @ avro-toplevel ---
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [INFO] Rat check: Summary over all files. Unapproved: 17, unknown: 17,
> generated: 0, approved: 1580 licenses.
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [WARNING] Files with unapproved licenses:
> lang/py/docs/build/html/searchindex.js
> lang/py/docs/build/html/.buildinfo
> lang/py/docs/build/html/search.html
> lang/py/docs/build/html/py-modindex.html
> lang/py/docs/build/html/genindex.html
> lang/py/docs/build/html/intro.html
> lang/py/docs/build/html/index.html
> lang/py/docs/build/html/automodule.html
> lang/py/docs/build/html/_static/alabaster.css
> lang/py/docs/build/html/_static/custom.css
> lang/py/docs/build/html/_static/basic.css
> lang/py/docs/build/html/_static/doctools.js
> lang/py/docs/build/html/_static/documentation_options.js
> lang/py/docs/build/html/_static/language_data.js
> lang/py/docs/build/html/_static/searchtools.js
> lang/py/docs/build/html/_static/sphinx_highlight.js
> lang/py/docs/build/html/_static/pygments.css
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 4.428 s
> [INFO] Finished at: 2023-09-20T12:50:06Z
> [INFO]
>
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check
> (default) on project avro-toplevel: Too many files with unapproved license:
> 17 See RAT report in: /home/ryan.skraba/avro/target/rat.txt -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
> The workaround is to do a `./build.sh clean test` followed by a `./build.sh
> clean dist`, but this should probably be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AVRO-3861) [Build] Add RAT exclusions for python docs
[
https://issues.apache.org/jira/browse/AVRO-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781675#comment-17781675
]
ASF subversion and git services commented on AVRO-3861:
---
Commit 8fda42aa289c590a703fe9529f5d7303e3327d66 in avro's branch
refs/heads/main from Kousuke Saruta
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=8fda42aa2 ]
AVRO-3861: [Build] Add RAT exclusions for python docs (#2572)
> [Build] Add RAT exclusions for python docs
> --
>
> Key: AVRO-3861
> URL: https://issues.apache.org/jira/browse/AVRO-3861
> Project: Apache Avro
> Issue Type: Bug
> Components: build
>Affects Versions: 1.12.0, 1.11.3
>Reporter: Ryan Skraba
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When following the release process and doing a *./build.sh clean test dist*
> we get the following error:
> {code}
> [INFO] --- apache-rat-plugin:0.15:check (default) @ avro-toplevel ---
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [INFO] Rat check: Summary over all files. Unapproved: 17, unknown: 17,
> generated: 0, approved: 1580 licenses.
> [INFO] Enabled default license matchers.
> [INFO] Will parse SCM ignores for exclusions...
> [INFO] Parsing exclusions from /home/ryan.skraba/avro/.gitignore
> [INFO] Finished adding exclusions from SCM ignore files.
> [INFO] 88 implicit excludes.
> [INFO] 131 explicit excludes.
> [INFO] 5630 resources included
> [WARNING] Files with unapproved licenses:
> lang/py/docs/build/html/searchindex.js
> lang/py/docs/build/html/.buildinfo
> lang/py/docs/build/html/search.html
> lang/py/docs/build/html/py-modindex.html
> lang/py/docs/build/html/genindex.html
> lang/py/docs/build/html/intro.html
> lang/py/docs/build/html/index.html
> lang/py/docs/build/html/automodule.html
> lang/py/docs/build/html/_static/alabaster.css
> lang/py/docs/build/html/_static/custom.css
> lang/py/docs/build/html/_static/basic.css
> lang/py/docs/build/html/_static/doctools.js
> lang/py/docs/build/html/_static/documentation_options.js
> lang/py/docs/build/html/_static/language_data.js
> lang/py/docs/build/html/_static/searchtools.js
> lang/py/docs/build/html/_static/sphinx_highlight.js
> lang/py/docs/build/html/_static/pygments.css
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 4.428 s
> [INFO] Finished at: 2023-09-20T12:50:06Z
> [INFO]
>
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check
> (default) on project avro-toplevel: Too many files with unapproved license:
> 17 See RAT report in: /home/ryan.skraba/avro/target/rat.txt -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
> The workaround is to do a `./build.sh clean test` followed by a `./build.sh
> clean dist`, but this should probably be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
