[jira] [Comment Edited] (BEAM-9061) New release of pyhamcrest==1.10.0 breaks portable Python precommits.

2020-01-16 Thread Valentyn Tymofieiev (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017582#comment-17017582
 ] 

Valentyn Tymofieiev edited comment on BEAM-9061 at 1/17/20 12:15 AM:
-

This is because we stage entire tmp directory to the Dataflow workers [1]
and pip does not check package metadata when installing dependencies with 
--find-links command, such as:

pip install pyhamcrest --find-links 


[1] 
https://lists.apache.org/thread.html/f99820489026a46160505ea9a4c8c4a0eabe8649143c1ee22b7088aa%40%3Cdev.beam.apache.org%3E


was (Author: tvalentyn):
This is because we stage entire tmp directory to the Dataflow workers [1]
and pip does not check package metadata when installing dependencies with 
--find-links command, such as:

pip install pyhamcrest --find-links 

[1] 
https://lists.apache.org/thread.html/f99820489026a46160505ea9a4c8c4a0eabe8649143c1ee22b7088aa%40%3Cdev.beam.apache.org%3E

> New release of pyhamcrest==1.10.0 breaks portable Python precommits.
> 
>
> Key: BEAM-9061
> URL: https://issues.apache.org/jira/browse/BEAM-9061
> Project: Beam
>  Issue Type: Bug
>  Components: test-failures
>Reporter: Valentyn Tymofieiev
>Assignee: Valentyn Tymofieiev
>Priority: Major
> Fix For: Not applicable
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> {noformat}
> 08:35:26   File "apache_beam/runners/portability/fn_api_runner_test.py", line 
> 38, in 
> 08:35:26 import hamcrest  # pylint: disable=ungrouped-imports
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/__init__.py",
>  line 2, in 
> 08:35:26 from hamcrest.library import *
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/__init__.py",
>  line 7, in 
> 08:35:26 from hamcrest.library.object import *
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/__init__.py",
>  line 4, in 
> 08:35:26 from .hasproperty import has_properties, has_property
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/hasproperty.py",
>  line 174
> 08:35:26 ),
> 08:35:26 ^
> {noformat}
> rootcause: https://github.com/hamcrest/PyHamcrest/issues/131



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (BEAM-9061) New release of pyhamcrest==1.10.0 breaks portable Python precommits.

2020-01-16 Thread Udi Meiri (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017572#comment-17017572
 ] 

Udi Meiri edited comment on BEAM-9061 at 1/16/20 11:48 PM:
---

I've manually patched in these changes to run postcommits locally on the 2.18 
release branch:
{code}
  echo "pyhamcrest!=1.10.0,<2.0.0" > postcommit_requirements.txt
  echo "mock<3.0.0" >> postcommit_requirements.txt
{code}


was (Author: udim):
I've manually patching in these changes to run postcommits locally on the 2.18 
release branch:
{code}
  echo "pyhamcrest!=1.10.0,<2.0.0" > postcommit_requirements.txt
  echo "mock<3.0.0" >> postcommit_requirements.txt
{code}

> New release of pyhamcrest==1.10.0 breaks portable Python precommits.
> 
>
> Key: BEAM-9061
> URL: https://issues.apache.org/jira/browse/BEAM-9061
> Project: Beam
>  Issue Type: Bug
>  Components: test-failures
>Reporter: Valentyn Tymofieiev
>Assignee: Valentyn Tymofieiev
>Priority: Major
> Fix For: Not applicable
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> {noformat}
> 08:35:26   File "apache_beam/runners/portability/fn_api_runner_test.py", line 
> 38, in 
> 08:35:26 import hamcrest  # pylint: disable=ungrouped-imports
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/__init__.py",
>  line 2, in 
> 08:35:26 from hamcrest.library import *
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/__init__.py",
>  line 7, in 
> 08:35:26 from hamcrest.library.object import *
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/__init__.py",
>  line 4, in 
> 08:35:26 from .hasproperty import has_properties, has_property
> 08:35:26   File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/hasproperty.py",
>  line 174
> 08:35:26 ),
> 08:35:26 ^
> {noformat}
> rootcause: https://github.com/hamcrest/PyHamcrest/issues/131



--
This message was sent by Atlassian Jira
(v8.3.4#803005)