[jira] [Commented] (BEAM-14215) Incomplete argument validation in SnowflakeIO
[ https://issues.apache.org/jira/browse/BEAM-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550063#comment-17550063 ] Danny McCormick commented on BEAM-14215: This issue has been migrated to https://github.com/apache/beam/issues/21633 > Incomplete argument validation in SnowflakeIO > - > > Key: BEAM-14215 > URL: https://issues.apache.org/jira/browse/BEAM-14215 > Project: Beam > Issue Type: Improvement > Components: io-java-snowflake >Reporter: Kamil Breguła (SF) >Priority: P2 > Time Spent: 2h 40m > Remaining Estimate: 0h > > Hi. > I noticed that the validation of arguments from users is not complete, which > sometimes leads to problems that are difficult to troubleshoot: > - The server name or address must be specified, but it is not checked. > - We have validation for multiple arguments, but only checks if the builder > method was called, but the value can still be empty as we use ValueProvider > in multiple places. > Best regards, > Kamil -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (BEAM-14215) Incomplete argument validation in SnowflakeIO
[ https://issues.apache.org/jira/browse/BEAM-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543681#comment-17543681 ] Beam JIRA Bot commented on BEAM-14215: -- This issue was marked "stale-assigned" and has not received a public comment in 7 days. It is now automatically unassigned. If you are still working on it, you can assign it to yourself again. Please also give an update about the status of the work. > Incomplete argument validation in SnowflakeIO > - > > Key: BEAM-14215 > URL: https://issues.apache.org/jira/browse/BEAM-14215 > Project: Beam > Issue Type: Improvement > Components: io-java-snowflake >Reporter: Kamil Breguła (SF) >Priority: P2 > Time Spent: 2h 40m > Remaining Estimate: 0h > > Hi. > I noticed that the validation of arguments from users is not complete, which > sometimes leads to problems that are difficult to troubleshoot: > - The server name or address must be specified, but it is not checked. > - We have validation for multiple arguments, but only checks if the builder > method was called, but the value can still be empty as we use ValueProvider > in multiple places. > Best regards, > Kamil -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (BEAM-14215) Incomplete argument validation in SnowflakeIO
[ https://issues.apache.org/jira/browse/BEAM-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540631#comment-17540631 ] Beam JIRA Bot commented on BEAM-14215: -- This issue is assigned but has not received an update in 30 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > Incomplete argument validation in SnowflakeIO > - > > Key: BEAM-14215 > URL: https://issues.apache.org/jira/browse/BEAM-14215 > Project: Beam > Issue Type: Improvement > Components: io-java-snowflake >Reporter: Kamil Breguła (SF) >Assignee: Kamil Breguła (SF) >Priority: P2 > Labels: stale-assigned > Time Spent: 2h 40m > Remaining Estimate: 0h > > Hi. > I noticed that the validation of arguments from users is not complete, which > sometimes leads to problems that are difficult to troubleshoot: > - The server name or address must be specified, but it is not checked. > - We have validation for multiple arguments, but only checks if the builder > method was called, but the value can still be empty as we use ValueProvider > in multiple places. > Best regards, > Kamil -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (BEAM-14215) Incomplete argument validation in SnowflakeIO
[ https://issues.apache.org/jira/browse/BEAM-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515484#comment-17515484 ] Chamikara Madhusanka Jayalath commented on BEAM-14215: -- Thanks for the fix. > Incomplete argument validation in SnowflakeIO > - > > Key: BEAM-14215 > URL: https://issues.apache.org/jira/browse/BEAM-14215 > Project: Beam > Issue Type: Improvement > Components: io-java-snowflake >Reporter: Kamil Breguła (SF) >Assignee: Kamil Breguła (SF) >Priority: P2 > Time Spent: 20m > Remaining Estimate: 0h > > Hi. > I noticed that the validation of arguments from users is not complete, which > sometimes leads to problems that are difficult to troubleshoot: > - The server name or address must be specified, but it is not checked. > - We have validation for multiple arguments, but only checks if the builder > method was called, but the value can still be empty as we use ValueProvider > in multiple places. > Best regards, > Kamil -- This message was sent by Atlassian Jira (v8.20.1#820001)