[jira] [Commented] (BEAM-8157) [Flink Runner 1.9] State requests return wrong state in timers when encoded key is length-prefixed

2019-09-11 Thread Mark Liu (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928062#comment-16928062
 ] 

Mark Liu commented on BEAM-8157:


[~mxm] 2.16 release branch is cut. I'll move it to 2.17. If you really want to 
have this in 2.16, please let me know and we can cherrypick your change if it 
fits the release time frame.

> [Flink Runner 1.9] State requests return wrong state in timers when encoded 
> key is length-prefixed
> --
>
> Key: BEAM-8157
> URL: https://issues.apache.org/jira/browse/BEAM-8157
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.13.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
>Priority: Major
> Fix For: 2.16.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> The Flink runner requires the internal key to be encoded without a length 
> prefix (OUTER context). The user state request handler exposes a serialized 
> version of the key to the Runner. This key is encoded with the NESTED context 
> which may add a length prefix. We need to convert it to OUTER context to 
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However, 
> with the upcoming support for Flink 1.9, the state backend will not accept 
> requests for keys not part of any key group/partition of the operator. This 
> is very likely to happen with the encoding not being consistent.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (BEAM-8157) [Flink Runner 1.9] State requests return wrong state in timers when encoded key is length-prefixed

2019-09-09 Thread Mark Liu (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926024#comment-16926024
 ] 

Mark Liu commented on BEAM-8157:


Is this issue on track for 2.16 release? (branch will be cut in 3 days) Shall 
we move it to 2.17?

> [Flink Runner 1.9] State requests return wrong state in timers when encoded 
> key is length-prefixed
> --
>
> Key: BEAM-8157
> URL: https://issues.apache.org/jira/browse/BEAM-8157
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.13.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
>Priority: Major
> Fix For: 2.16.0
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> The Flink runner requires the internal key to be encoded without a length 
> prefix (OUTER context). The user state request handler exposes a serialized 
> version of the key to the Runner. This key is encoded with the NESTED context 
> which may add a length prefix. We need to convert it to OUTER context to 
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However, 
> with the upcoming support for Flink 1.9, the state backend will not accept 
> requests for keys not part of any key group/partition of the operator. This 
> is very likely to happen with the encoding not being consistent.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)