[jira] [Updated] (BEAM-6598) build_release_candidate.sh fails because of leftover RC tags in working git clone
[ https://issues.apache.org/jira/browse/BEAM-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beam JIRA Bot updated BEAM-6598: Labels: (was: stale-P2) > build_release_candidate.sh fails because of leftover RC tags in working git > clone > - > > Key: BEAM-6598 > URL: https://issues.apache.org/jira/browse/BEAM-6598 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P3 > > Currently, the build_release_candidate.sh re-uses > $HOME/build_release_candidate/beam as the git clone. If the RC tag already > exists due to a prior build, it crashes. Instead, since that clone failed, it > should just not be used the next time. The workflow that makes sense to me is: > - Locally tag the intended RC commit > - Try to build the RC from that > - If the RC build fails, remove tag / discard working branch / etc > - If the RC succeeds, push the tag (and if it is on a gradle release plugin > commit, those commits) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (BEAM-6598) build_release_candidate.sh fails because of leftover RC tags in working git clone
[ https://issues.apache.org/jira/browse/BEAM-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beam JIRA Bot updated BEAM-6598: Priority: P3 (was: P2) > build_release_candidate.sh fails because of leftover RC tags in working git > clone > - > > Key: BEAM-6598 > URL: https://issues.apache.org/jira/browse/BEAM-6598 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P3 > Labels: stale-P2 > > Currently, the build_release_candidate.sh re-uses > $HOME/build_release_candidate/beam as the git clone. If the RC tag already > exists due to a prior build, it crashes. Instead, since that clone failed, it > should just not be used the next time. The workflow that makes sense to me is: > - Locally tag the intended RC commit > - Try to build the RC from that > - If the RC build fails, remove tag / discard working branch / etc > - If the RC succeeds, push the tag (and if it is on a gradle release plugin > commit, those commits) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (BEAM-6598) build_release_candidate.sh fails because of leftover RC tags in working git clone
[ https://issues.apache.org/jira/browse/BEAM-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beam JIRA Bot updated BEAM-6598: Labels: stale-P2 (was: ) > build_release_candidate.sh fails because of leftover RC tags in working git > clone > - > > Key: BEAM-6598 > URL: https://issues.apache.org/jira/browse/BEAM-6598 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P2 > Labels: stale-P2 > > Currently, the build_release_candidate.sh re-uses > $HOME/build_release_candidate/beam as the git clone. If the RC tag already > exists due to a prior build, it crashes. Instead, since that clone failed, it > should just not be used the next time. The workflow that makes sense to me is: > - Locally tag the intended RC commit > - Try to build the RC from that > - If the RC build fails, remove tag / discard working branch / etc > - If the RC succeeds, push the tag (and if it is on a gradle release plugin > commit, those commits) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (BEAM-6598) build_release_candidate.sh fails because of leftover RC tags in working git clone
[ https://issues.apache.org/jira/browse/BEAM-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Altay updated BEAM-6598: -- Parent: BEAM-7887 Issue Type: Sub-task (was: Bug) > build_release_candidate.sh fails because of leftover RC tags in working git > clone > - > > Key: BEAM-6598 > URL: https://issues.apache.org/jira/browse/BEAM-6598 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > > Currently, the build_release_candidate.sh re-uses > $HOME/build_release_candidate/beam as the git clone. If the RC tag already > exists due to a prior build, it crashes. Instead, since that clone failed, it > should just not be used the next time. The workflow that makes sense to me is: > - Locally tag the intended RC commit > - Try to build the RC from that > - If the RC build fails, remove tag / discard working branch / etc > - If the RC succeeds, push the tag (and if it is on a gradle release plugin > commit, those commits) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (BEAM-6598) build_release_candidate.sh fails because of leftover RC tags in working git clone
[ https://issues.apache.org/jira/browse/BEAM-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-6598: -- Description: Currently, the build_release_candidate.sh re-uses $HOME/build_release_candidate/beam as the git clone. If the RC tag already exists due to a prior build, it crashes. Instead, since that clone failed, it should just not be used the next time. The workflow that makes sense to me is: - Locally tag the intended RC commit - Try to build the RC from that - If the RC build fails, remove tag / discard working branch / etc - If the RC succeeds, push the tag (and if it is on a gradle release plugin commit, those commits) was: Currently, the build_release_candidate.sh does many things beyond the build - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT - Makes a local commit - Pushes commits to release branch - Reverts on failure, pushes those to release branch Instead, the release manager should determine what gets pushed. It is less fragile of a process and avoids cruft getting pushed and churning the branch. The only thing the plugin is really good for is flipping SNAPSHOT away and back. And it isn't even that great because that's Java only and other languages are at non-SNAPSHOT anyhow. > build_release_candidate.sh fails because of leftover RC tags in working git > clone > - > > Key: BEAM-6598 > URL: https://issues.apache.org/jira/browse/BEAM-6598 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > > Currently, the build_release_candidate.sh re-uses > $HOME/build_release_candidate/beam as the git clone. If the RC tag already > exists due to a prior build, it crashes. Instead, since that clone failed, it > should just not be used the next time. The workflow that makes sense to me is: > - Locally tag the intended RC commit > - Try to build the RC from that > - If the RC build fails, remove tag / discard working branch / etc > - If the RC succeeds, push the tag (and if it is on a gradle release plugin > commit, those commits) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
