[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=356400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356400
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 09/Dec/19 17:44
Start Date: 09/Dec/19 17:44
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #9189: [BEAM-5820]
Use vendored calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r355589635
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -76,70 +37,40 @@ configurations {
fmppTemplates
}
-def calcite_version = "1.20.0"
-def avatica_version = "1.15.0"
def zetasql_version = "2019.09.1"
dependencies {
javacc "net.java.dev.javacc:javacc:4.0"
fmppTask "com.googlecode.fmpp-maven-plugin:fmpp-maven-plugin:1.0"
fmppTask "org.freemarker:freemarker:2.3.28"
- fmppTemplates "org.apache.calcite:calcite-core:$calcite_version"
- shadow library.java.vendored_guava_26_0_jre // Internal use
- compile library.java.guava // Interfaces with Calcite use this
- compile "org.apache.calcite:calcite-core:$calcite_version"
- compile "org.apache.calcite:calcite-linq4j:$calcite_version"
- compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.google.api.grpc:proto-google-common-protos:1.12.0" //
Interfaces with ZetaSQL use this
+ fmppTemplates library.java.vendored_calcite_1_20_0
+ compile project(":sdks:java:core")
+ compile project(":sdks:java:extensions:join-library")
+ compile project(":runners:direct-java")
+ compile library.java.commons_csv
+ compile library.java.vendored_calcite_1_20_0
+ compile "com.alibaba:fastjson:1.2.49"
+ compile "org.codehaus.janino:janino:3.0.11"
+ compile "org.codehaus.janino:commons-compiler:3.0.11"
compile "com.google.zetasql:zetasql-jni-channel:$zetasql_version"
compile "com.google.zetasql:zetasql-client:$zetasql_version"
compile "com.google.zetasql:zetasql-types:$zetasql_version"
- shadow project(path: ":sdks:java:core", configuration: "shadow")
- shadow project(":sdks:java:extensions:join-library")
- shadow library.java.slf4j_api
- shadow library.java.commons_codec
Review comment:
I this this omission caused the @iemejia 's finding:
https://issues.apache.org/jira/browse/BEAM-8858?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel=16991773#comment-16991773
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 356400)
Time Spent: 16h 20m (was: 16h 10m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 16h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=318038=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318038 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 25/Sep/19 03:41 Start Date: 25/Sep/19 03:41 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #9189: [BEAM-5820] Use vendored calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534837694 Nice work! This is huge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 318038) Time Spent: 16h 10m (was: 16h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Fix For: 2.17.0 > > Time Spent: 16h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317956=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317956 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 25/Sep/19 00:57 Start Date: 25/Sep/19 00:57 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] Use vendored calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534804951 Thanks Luke! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317956) Time Spent: 16h (was: 15h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Fix For: 2.17.0 > > Time Spent: 16h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317854=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317854 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 21:17 Start Date: 24/Sep/19 21:17 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] Use vendored calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534752397 Thanks Luke! LGTM to the content of changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317854) Time Spent: 15h 50m (was: 15h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Fix For: 2.17.0 > > Time Spent: 15h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317735 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 18:12 Start Date: 24/Sep/19 18:12 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9189: [BEAM-5820] Use vendored calcite URL: https://github.com/apache/beam/pull/9189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317735) Time Spent: 15h 40m (was: 15.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 15h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317692=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317692 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 17:27 Start Date: 24/Sep/19 17:27 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534663011 @amaliujia pass nexmark tests (direct runner and non-direct runner). could you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317692) Time Spent: 15.5h (was: 15h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 15.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317374=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317374 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:55 Start Date: 24/Sep/19 10:55 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503783 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317374) Time Spent: 15h 10m (was: 15h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 15h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317373=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317373 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:55 Start Date: 24/Sep/19 10:55 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503212 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317373) Time Spent: 15h (was: 14h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 15h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317375 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:55 Start Date: 24/Sep/19 10:55 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534504965 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317375) Time Spent: 15h 20m (was: 15h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 15h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317371 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:54 Start Date: 24/Sep/19 10:54 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534504787 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317371) Time Spent: 14h 50m (was: 14h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317370 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:54 Start Date: 24/Sep/19 10:54 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534504747 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317370) Time Spent: 14h 40m (was: 14.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317368=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317368 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:52 Start Date: 24/Sep/19 10:52 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503293 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317368) Time Spent: 14.5h (was: 14h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317367=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317367 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503783 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317367) Time Spent: 14h 20m (was: 14h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317366=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317366 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332723 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317366) Time Spent: 14h 10m (was: 14h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317365 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332680 Run Spark Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317365) Time Spent: 14h (was: 13h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 14h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317362=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317362 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503509 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317362) Time Spent: 13.5h (was: 13h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317363 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503509 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317363) Time Spent: 13h 40m (was: 13.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317364 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:51 Start Date: 24/Sep/19 10:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332619 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317364) Time Spent: 13h 50m (was: 13h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317361=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317361 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:50 Start Date: 24/Sep/19 10:50 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534354241 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317361) Time Spent: 13h 20m (was: 13h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317359 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:50 Start Date: 24/Sep/19 10:50 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503293 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317359) Time Spent: 13h (was: 12h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317360=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317360 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:50 Start Date: 24/Sep/19 10:50 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332583 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317360) Time Spent: 13h 10m (was: 13h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 13h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317358 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 10:49 Start Date: 24/Sep/19 10:49 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534503212 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317358) Time Spent: 12h 50m (was: 12h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317127=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317127 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 01:56 Start Date: 24/Sep/19 01:56 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534354241 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317127) Time Spent: 12h 40m (was: 12.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317057=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317057 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 00:09 Start Date: 24/Sep/19 00:09 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332723 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317057) Time Spent: 12.5h (was: 12h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317055=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317055 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 00:09 Start Date: 24/Sep/19 00:09 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332680 Run Spark Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317055) Time Spent: 12h 20m (was: 12h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317054=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317054 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 00:09 Start Date: 24/Sep/19 00:09 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332619 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317054) Time Spent: 12h 10m (was: 12h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=317053=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317053 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 24/Sep/19 00:08 Start Date: 24/Sep/19 00:08 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534332583 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317053) Time Spent: 12h (was: 11h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 12h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=316615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316615 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 23/Sep/19 12:10 Start Date: 23/Sep/19 12:10 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-534071557 @vectorijk this aparently still needs a rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316615) Time Spent: 11h 50m (was: 11h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=316512=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316512 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 23/Sep/19 08:07 Start Date: 23/Sep/19 08:07 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-533998611 Run Spark Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316512) Time Spent: 11.5h (was: 11h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=316513=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316513 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 23/Sep/19 08:07 Start Date: 23/Sep/19 08:07 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-533998690 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316513) Time Spent: 11h 40m (was: 11.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=316511=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316511 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 23/Sep/19 08:07 Start Date: 23/Sep/19 08:07 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-533998571 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316511) Time Spent: 11h 20m (was: 11h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=313425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313425 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 17/Sep/19 02:16 Start Date: 17/Sep/19 02:16 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-532028996 I took a look at the gradle scan. The error message is truncated. But it looks like a transform translator registered with AutoService is not a subtype of the expected interface. I do not know why this is different with Dataflow and Direct runner. The stack trace does lead through the DataflowRunner `replaceTransforms` method. https://scans.gradle.com/s/tqk3vel4olim4/console-log?task=:sdks:java:testing:nexmark:run This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313425) Time Spent: 11h 10m (was: 11h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=312215=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312215 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 18:06 Start Date: 13/Sep/19 18:06 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531336114 I triggered Spark/Flink Runner Nexmark Test in #9553 and those tests are passed. This PR is against branch-2.16.0. I am not sure if it breaks Nexmark Test because latest commits on master branch. Since only Direct Runner nexmark test passes currently, For sure, I will ask in dev@ why this happened. Meanwhile, I'll try to run nexmark test with non-direct runner locally later :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312215) Time Spent: 11h (was: 10h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 11h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=312153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312153 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 16:17 Start Date: 13/Sep/19 16:17 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531301008 Maybe ask in dev@ about why Nexmark tests failed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312153) Time Spent: 10h 50m (was: 10h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311922 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 09:05 Start Date: 13/Sep/19 09:05 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531161576 Run Dataflow Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311922) Time Spent: 10h 40m (was: 10.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311916=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311916 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 08:45 Start Date: 13/Sep/19 08:45 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531154474 Run Flink Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311916) Time Spent: 10.5h (was: 10h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311884=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311884 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 06:06 Start Date: 13/Sep/19 06:06 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531110906 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311884) Time Spent: 10h 10m (was: 10h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311883=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311883 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 06:06 Start Date: 13/Sep/19 06:06 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531110888 Run Spark Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311883) Time Spent: 10h (was: 9h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311885=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311885 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 06:06 Start Date: 13/Sep/19 06:06 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531110946 Run Direct Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311885) Time Spent: 10h 20m (was: 10h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311880 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 05:55 Start Date: 13/Sep/19 05:55 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531108625 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311880) Time Spent: 9h 50m (was: 9h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311879=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311879 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 05:54 Start Date: 13/Sep/19 05:54 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531108567 Run Spark Runner Nexmark Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311879) Time Spent: 9h 40m (was: 9.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311856 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 03:04 Start Date: 13/Sep/19 03:04 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531081137 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311856) Time Spent: 9.5h (was: 9h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311836 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Sep/19 00:40 Start Date: 13/Sep/19 00:40 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531057820 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311836) Time Spent: 9h 20m (was: 9h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311797 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 22:49 Start Date: 12/Sep/19 22:49 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531035981 Thanks @amaliujia! I'll squash commits later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311797) Time Spent: 9h 10m (was: 9h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311772=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311772 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 21:57 Start Date: 12/Sep/19 21:57 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531022889 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311772) Time Spent: 8h 50m (was: 8h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311773=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311773 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 21:57 Start Date: 12/Sep/19 21:57 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-531022927 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311773) Time Spent: 9h (was: 8h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 9h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311605=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311605 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 19:14 Start Date: 12/Sep/19 19:14 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530964915 Thanks. I will review the usage of vendor calcite and merge this PR if I don't have further comment. Also FYI vendoring work is done by #9333 @vectorijk would you mind rebasing this PR and pass tests? It would also be great if you could squash this PR a bit into one single commit. I usually do rebase and requash together: ``` git fetch upstream git rebase -i upstream/master ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311605) Time Spent: 8h 40m (was: 8.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311604=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311604 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 19:14 Start Date: 12/Sep/19 19:14 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530964915 Thanks. I will review the usage of vendor calcite and merge this PR if I don't have further comment. Also FYI vendoring work is done by #9333 @vectorijk would you mind rebasing this PR and pass tests? It would also be great if you could squash this PR a bit into one single commit. I usually do rebase and requash together: ``` git fetch upstream` git rebase -i upstream/master ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311604) Time Spent: 8.5h (was: 8h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311595=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311595 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 19:11 Start Date: 12/Sep/19 19:11 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530964915 Thanks. I will review the usage of vendor calcite and merge this PR if I don't have further comment. Also FYI vendoring work is done by #9333 @vectorijk would you mind rebasing this PR and pass tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311595) Time Spent: 8h 20m (was: 8h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311238 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Sep/19 07:27 Start Date: 12/Sep/19 07:27 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530702087 Since vendoring has been done separately, it is a good time to rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311238) Time Spent: 8h 10m (was: 8h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311082 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 11/Sep/19 23:31 Start Date: 11/Sep/19 23:31 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530604564 I only reviewed the shading changes and not its usage. I would be fine with a rebase and update as all the vendoring of Calcite was done in a different PR. Please also update the PR title/description and link to JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311082) Time Spent: 8h (was: 7h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 8h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=311006=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311006 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 11/Sep/19 21:04 Start Date: 11/Sep/19 21:04 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530565186 Sorry @vectorijk, as your PR is big(which is a great refactor to move to vendor calcite), it's easy to have conflicts by code changes on java imports. You could wait until PR reviewers have a consensus, then do a final rebase and pass test to make PR be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311006) Time Spent: 7h 50m (was: 7h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 7h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=310996=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310996 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 11/Sep/19 20:52 Start Date: 11/Sep/19 20:52 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-530560947 @apilloud @lukecwik @iemejia @kennknowles As this PR has passed tests before(although it has conflicts now but that's can be solved quickly), if you don't have other comments, I will merge this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310996) Time Spent: 7h 40m (was: 7.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=310844=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310844
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 11/Sep/19 17:07
Start Date: 11/Sep/19 17:07
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r323012683
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -22,48 +22,7 @@ plugins {
id 'org.apache.beam.module'
id 'ca.coglinc.javacc'
}
-applyJavaNature(
- // javacc generated code produces lint warnings
- disableLintWarnings: ['dep-ann'],
- testShadowJar: true,
- enableStrictDependencies: true,
- shadowClosure: {
-dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
- include(dependency("com.google.zetasql:.*"))
-}
-// guava uses the com.google.common and com.google.thirdparty package
namespaces
-relocate("com.google.common",
project.getJavaRelocatedPath("com.google.common")) {
- // com.google.common is too generic, need to exclude guava-testlib
- exclude "com.google.common.collect.testing.**"
- exclude "com.google.common.escape.testing.**"
- exclude "com.google.common.testing.**"
- exclude "com.google.common.util.concurrent.testing.**"
-}
-relocate "com.google.cloud", getJavaRelocatedPath("com.google.cloud")
-relocate "com.google.logging", getJavaRelocatedPath("com.google.logging")
-relocate "com.google.longrunning",
getJavaRelocatedPath("com.google.longrunning")
-relocate "com.google.rpc", getJavaRelocatedPath("com.google.rpc")
-
-relocate "com.google.thirdparty",
project.getJavaRelocatedPath("com.google.thirdparty")
-
-relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf")
-relocate "com.google.zetasql", getJavaRelocatedPath("com.google.zetasql")
-relocate "org.apache.calcite", getJavaRelocatedPath("org.apache.calcite")
-
- // Looking up the compiler factory in Calcite depends on having a properties
- // file in the right location. We package one that is shading compatible
- // in src/main/resources. Note that if this shaded path changes, that
- // files name and contents need to be updated as well. TODO, swap to use
- // getJavaRelocatedPath once the Maven build is no longer also shading this
- // module.
- relocate "org.codehaus",
"org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus"
-})
+applyJavaNature( disableLintWarnings: ['dep-ann'] )
Review comment:
this step is used for disabling javacc generated code produces lint warnings
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 310844)
Time Spent: 7.5h (was: 7h 20m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=310210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310210
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 11/Sep/19 00:09
Start Date: 11/Sep/19 00:09
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r323012683
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -22,48 +22,7 @@ plugins {
id 'org.apache.beam.module'
id 'ca.coglinc.javacc'
}
-applyJavaNature(
- // javacc generated code produces lint warnings
- disableLintWarnings: ['dep-ann'],
- testShadowJar: true,
- enableStrictDependencies: true,
- shadowClosure: {
-dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
- include(dependency("com.google.zetasql:.*"))
-}
-// guava uses the com.google.common and com.google.thirdparty package
namespaces
-relocate("com.google.common",
project.getJavaRelocatedPath("com.google.common")) {
- // com.google.common is too generic, need to exclude guava-testlib
- exclude "com.google.common.collect.testing.**"
- exclude "com.google.common.escape.testing.**"
- exclude "com.google.common.testing.**"
- exclude "com.google.common.util.concurrent.testing.**"
-}
-relocate "com.google.cloud", getJavaRelocatedPath("com.google.cloud")
-relocate "com.google.logging", getJavaRelocatedPath("com.google.logging")
-relocate "com.google.longrunning",
getJavaRelocatedPath("com.google.longrunning")
-relocate "com.google.rpc", getJavaRelocatedPath("com.google.rpc")
-
-relocate "com.google.thirdparty",
project.getJavaRelocatedPath("com.google.thirdparty")
-
-relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf")
-relocate "com.google.zetasql", getJavaRelocatedPath("com.google.zetasql")
-relocate "org.apache.calcite", getJavaRelocatedPath("org.apache.calcite")
-
- // Looking up the compiler factory in Calcite depends on having a properties
- // file in the right location. We package one that is shading compatible
- // in src/main/resources. Note that if this shaded path changes, that
- // files name and contents need to be updated as well. TODO, swap to use
- // getJavaRelocatedPath once the Maven build is no longer also shading this
- // module.
- relocate "org.codehaus",
"org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus"
-})
+applyJavaNature( disableLintWarnings: ['dep-ann'] )
Review comment:
disable javacc generated code produces lint warnings
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 310210)
Time Spent: 7h 20m (was: 7h 10m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=309413=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309413 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 10/Sep/19 00:35 Start Date: 10/Sep/19 00:35 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529718568 LGTM but please wait for other reviewers feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309413) Time Spent: 7h 10m (was: 7h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=309411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309411 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 10/Sep/19 00:34 Start Date: 10/Sep/19 00:34 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529718568 LGTM but do wait for other reviewers comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309411) Time Spent: 7h (was: 6h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 7h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=309410=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309410
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 10/Sep/19 00:33
Start Date: 10/Sep/19 00:33
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r322509104
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -22,48 +22,7 @@ plugins {
id 'org.apache.beam.module'
id 'ca.coglinc.javacc'
}
-applyJavaNature(
- // javacc generated code produces lint warnings
- disableLintWarnings: ['dep-ann'],
- testShadowJar: true,
- enableStrictDependencies: true,
- shadowClosure: {
-dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
- include(dependency("com.google.zetasql:.*"))
-}
-// guava uses the com.google.common and com.google.thirdparty package
namespaces
-relocate("com.google.common",
project.getJavaRelocatedPath("com.google.common")) {
- // com.google.common is too generic, need to exclude guava-testlib
- exclude "com.google.common.collect.testing.**"
- exclude "com.google.common.escape.testing.**"
- exclude "com.google.common.testing.**"
- exclude "com.google.common.util.concurrent.testing.**"
-}
-relocate "com.google.cloud", getJavaRelocatedPath("com.google.cloud")
-relocate "com.google.logging", getJavaRelocatedPath("com.google.logging")
-relocate "com.google.longrunning",
getJavaRelocatedPath("com.google.longrunning")
-relocate "com.google.rpc", getJavaRelocatedPath("com.google.rpc")
-
-relocate "com.google.thirdparty",
project.getJavaRelocatedPath("com.google.thirdparty")
-
-relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf")
-relocate "com.google.zetasql", getJavaRelocatedPath("com.google.zetasql")
-relocate "org.apache.calcite", getJavaRelocatedPath("org.apache.calcite")
-
- // Looking up the compiler factory in Calcite depends on having a properties
- // file in the right location. We package one that is shading compatible
- // in src/main/resources. Note that if this shaded path changes, that
- // files name and contents need to be updated as well. TODO, swap to use
- // getJavaRelocatedPath once the Maven build is no longer also shading this
- // module.
- relocate "org.codehaus",
"org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus"
-})
+applyJavaNature( disableLintWarnings: ['dep-ann'] )
Review comment:
What's this step used for?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 309410)
Time Spent: 6h 50m (was: 6h 40m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308310 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 07/Sep/19 06:39 Start Date: 07/Sep/19 06:39 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529079395 > Thanks for replacing calcite in Beam ZetaSQL to vendor calcite, which will unblock us from moving Beam ZetaSQL to a separate module. Cool! Looking forward to this. Once this effort is done, we can move ZetaSQL code to a separate module path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308310) Time Spent: 6h 40m (was: 6.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 6h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308252 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 07/Sep/19 01:13 Start Date: 07/Sep/19 01:13 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529058347 Thanks for replacing calcite in Beam ZetaSQL to vendor calcite, which will unblock us from moving Beam ZetaSQL to a separate module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308252) Time Spent: 6.5h (was: 6h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 6.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308251=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308251 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 07/Sep/19 01:13 Start Date: 07/Sep/19 01:13 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529058347 Thanks for replacing calcite in Beam ZetaSQL to vendor calcite, which will unblock us to move Beam ZetaSQL to a separate module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308251) Time Spent: 6h 20m (was: 6h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 6h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308250 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 07/Sep/19 01:13 Start Date: 07/Sep/19 01:13 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-529058347 Thanks for replace calcite in Beam ZetaSQL to vendor calcite, which will unblock us to move Beam ZetaSQL to a separate module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308250) Time Spent: 6h 10m (was: 6h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 6h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308185 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 06/Sep/19 21:50 Start Date: 06/Sep/19 21:50 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-516307123 @kennknowles @iemejia pass unit test locally This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308185) Time Spent: 6h (was: 5h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=308048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308048 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 06/Sep/19 17:49 Start Date: 06/Sep/19 17:49 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-528950626 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308048) Time Spent: 5h 50m (was: 5h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=307986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307986 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 06/Sep/19 16:07 Start Date: 06/Sep/19 16:07 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-528915643 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307986) Time Spent: 5h 40m (was: 5.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=307985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307985 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 06/Sep/19 16:07 Start Date: 06/Sep/19 16:07 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-528915471 Run CommunityMetrics PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307985) Time Spent: 5.5h (was: 5h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=307711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307711 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 06/Sep/19 09:10 Start Date: 06/Sep/19 09:10 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-528777671 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307711) Time Spent: 5h 20m (was: 5h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=297301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297301
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 19/Aug/19 17:15
Start Date: 19/Aug/19 17:15
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r315319821
##
File path: sdks/java/extensions/sql/jdbc/build.gradle
##
@@ -53,32 +50,13 @@ processResources {
]
}
-shadowJar {
- manifest {
-attributes "Main-Class":
"org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
Review comment:
Yes, we need to keep creating the uber jar for the JDBC target.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297301)
Time Spent: 5h 10m (was: 5h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=297290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297290 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 19/Aug/19 16:59 Start Date: 19/Aug/19 16:59 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9333: [BEAM-5820] release vendor calcite URL: https://github.com/apache/beam/pull/9333#issuecomment-522664796 Please take a look at https://s.apache.org/beam-release-vendored-artifacts. The first step is finding a release manager by reaching out on the dev@ mailing list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297290) Time Spent: 5h (was: 4h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=296650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296650 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 16/Aug/19 23:25 Start Date: 16/Aug/19 23:25 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9333: [BEAM-5820] release vendor calcite URL: https://github.com/apache/beam/pull/9333#issuecomment-522180056 Thanks Luke! Could you help with releasing the 0.1 version? Are there some instructions I can help with? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296650) Time Spent: 4h 50m (was: 4h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=296313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296313 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 16/Aug/19 14:30 Start Date: 16/Aug/19 14:30 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9333: [BEAM-5820] release vendor calcite URL: https://github.com/apache/beam/pull/9333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296313) Time Spent: 4h 40m (was: 4.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=295321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295321 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 15/Aug/19 08:42 Start Date: 15/Aug/19 08:42 Worklog Time Spent: 10m Work Description: vectorijk commented on pull request #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#discussion_r314221769 ## File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlDataCatalogExample.java ## @@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.MapElements; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TypeDescriptor; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; Review comment: Yes, calcite internal has guava type need to be passed in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295321) Time Spent: 4.5h (was: 4h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=295302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295302
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:32
Start Date: 15/Aug/19 08:32
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r314218560
##
File path: sdks/java/extensions/sql/jdbc/build.gradle
##
@@ -53,32 +50,13 @@ processResources {
]
}
-shadowJar {
- manifest {
-attributes "Main-Class":
"org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
Review comment:
should we keep creating the uber jar?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295302)
Time Spent: 4h 20m (was: 4h 10m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=295299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295299
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:26
Start Date: 15/Aug/19 08:26
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r313582544
##
File path: sdks/java/extensions/sql/jdbc/build.gradle
##
@@ -53,32 +50,13 @@ processResources {
]
}
-shadowJar {
- manifest {
-attributes "Main-Class":
"org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
Review comment:
cc: @akedin
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295299)
Time Spent: 4h 10m (was: 4h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294265=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294265 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 22:53 Start Date: 13/Aug/19 22:53 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-521034816 > > > We'll need to break this PR up into two pieces eventually: > > > > > > 1. A piece which just vendors calcite (so that it can go through the release process) > > > 2. The change which consumes vendored calcite. > > > > > > Yes. If `vendor/calcite-1_20_0/build.gradle`looks good, I'll open a self-contained pr for build vendored calcite package and we can go through the release process. > > Yes, the build.gradle looks fine but I didn't validate where the vendored calcite artifact actually works. I'm relying on your proof of concept to validate the contents are good and meet the Beam SQL needs. If it doesn't work, you can always produce another update version and release 0.2. Thanks Luke. I opened pr #9333 for releasing vendor calcite. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294265) Time Spent: 4h (was: 3h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294252 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 22:37 Start Date: 13/Aug/19 22:37 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9333: [BEAM-5820] release vendor calcite URL: https://github.com/apache/beam/pull/9333#issuecomment-521034975 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294252) Time Spent: 3h 50m (was: 3h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294251=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294251 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 22:36 Start Date: 13/Aug/19 22:36 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-521034816 > > > We'll need to break this PR up into two pieces eventually: > > > > > > 1. A piece which just vendors calcite (so that it can go through the release process) > > > 2. The change which consumes vendored calcite. > > > > > > Yes. If `vendor/calcite-1_20_0/build.gradle`looks good, I'll open a self-contained pr for build vendored calcite package and we can go through the release process. > > Yes, the build.gradle looks fine but I didn't validate where the vendored calcite artifact actually works. I'm relying on your proof of concept to validate the contents are good and meet the Beam SQL needs. If it doesn't work, you can always produce another update version and release 0.2. sure. I opened pr #9333 for releasing vendor calcite. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294251) Time Spent: 3h 40m (was: 3.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294249=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294249 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 22:34 Start Date: 13/Aug/19 22:34 Worklog Time Spent: 10m Work Description: vectorijk commented on pull request #9333: [BEAM-5820] release vendor calcite URL: https://github.com/apache/beam/pull/9333 Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | [![Build
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294136=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294136 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 19:58 Start Date: 13/Aug/19 19:58 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-520985656 > > We'll need to break this PR up into two pieces eventually: > > > > 1. A piece which just vendors calcite (so that it can go through the release process) > > 2. The change which consumes vendored calcite. > > Yes. If `vendor/calcite-1_20_0/build.gradle`looks good, I'll open a self-contained pr for build vendored calcite package and we can go through the release process. Yes, the build.gradle looks fine but I didn't validate where the vendored calcite artifact actually works. I'm relying on your proof of concept to validate the contents are good and meet the Beam SQL needs. If it doesn't work, you can always produce another update version and release 0.2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294136) Time Spent: 3h 20m (was: 3h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294130
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 13/Aug/19 19:52
Start Date: 13/Aug/19 19:52
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r313582544
##
File path: sdks/java/extensions/sql/jdbc/build.gradle
##
@@ -53,32 +50,13 @@ processResources {
]
}
-shadowJar {
- manifest {
-attributes "Main-Class":
"org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
Review comment:
cc: @akedin
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 294130)
Time Spent: 3h 10m (was: 3h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=294129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294129 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 19:51 Start Date: 13/Aug/19 19:51 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-520983060 > We'll need to break this PR up into two pieces eventually: > > 1. A piece which just vendors calcite (so that it can go through the release process) > 2. The change which consumes vendored calcite. Yes. If `vendor/calcite-1_20_0/build.gradle`looks good, I'll open a self-contained pr for build vendored calcite package and we can go through the release process. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294129) Time Spent: 3h (was: 2h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293993
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 13/Aug/19 16:19
Start Date: 13/Aug/19 16:19
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r313488507
##
File path: sdks/java/extensions/sql/jdbc/build.gradle
##
@@ -53,32 +50,13 @@ processResources {
]
}
-shadowJar {
- manifest {
-attributes "Main-Class":
"org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
Review comment:
I thought we were purposely trying to create an uber jar for
sdks/java/extensions/sql/jdbc.
@kennknowles @apilloud ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 293993)
Time Spent: 2h 50m (was: 2h 40m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293510=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293510 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 00:42 Start Date: 13/Aug/19 00:42 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#discussion_r313183324 ## File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlDataCatalogExample.java ## @@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.MapElements; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TypeDescriptor; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; Review comment: Calcite does, indeed, have ImmutableSet (or maybe it is a different immutable Guava thing) on its public API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293510) Time Spent: 2h 40m (was: 2.5h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293509=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293509 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 13/Aug/19 00:41 Start Date: 13/Aug/19 00:41 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#discussion_r313183324 ## File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlDataCatalogExample.java ## @@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.MapElements; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TypeDescriptor; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; Review comment: Calcite does, indeed, have ImmutableSet on its public API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293509) Time Spent: 2.5h (was: 2h 20m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293309 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Aug/19 18:40 Start Date: 12/Aug/19 18:40 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#discussion_r313070757 ## File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlDataCatalogExample.java ## @@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.MapElements; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TypeDescriptor; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; Review comment: I could see this happen if the calcite implementation requires a guava type to be passed in (which is likely a bad interface in Calcites implementation IMO). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293309) Time Spent: 2h 20m (was: 2h 10m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293242 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Aug/19 16:16 Start Date: 12/Aug/19 16:16 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#discussion_r313007490 ## File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlDataCatalogExample.java ## @@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.MapElements; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TypeDescriptor; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; Review comment: What is the reason to have to change the guava imports.? Shouldn't we stick to the vendored version of guava for Beam related code. I found a similar issue with gRPC imports too https://issues.apache.org/jira/browse/BEAM-7954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293242) Time Spent: 2h 10m (was: 2h) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293241 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Aug/19 16:15 Start Date: 12/Aug/19 16:15 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-520491053 Minor requirement, can you please add a checkstyle validation so other Beam modules don't accidentally import the non vendored version of calcite (similar to what is done for ByteBuddy in #9313). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293241) Time Spent: 2h (was: 1h 50m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=293238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293238 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 12/Aug/19 16:11 Start Date: 12/Aug/19 16:11 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9189: [BEAM-5820] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-520491053 Minor requirement, can you please add a checkstyle validation so other Beam modules don't accidentally import the non vendored version of calcite (similar to what is done for ByteBuddy in #9313). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293238) Time Spent: 1h 50m (was: 1h 40m) > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=290254=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290254
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 07/Aug/19 05:54
Start Date: 07/Aug/19 05:54
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r311378668
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
Review comment:
address this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 290254)
Time Spent: 1h 40m (was: 1.5h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=290214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290214
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 07/Aug/19 05:19
Start Date: 07/Aug/19 05:19
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r311371881
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
Review comment:
addressed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 290214)
Time Spent: 1h 20m (was: 1h 10m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=290217=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290217
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 07/Aug/19 05:19
Start Date: 07/Aug/19 05:19
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #9189: [BEAM-5820]
vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r311371979
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+"com.google.thirdparty":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+
+// Making this self-contained, includes Calcite's dependencies
+"org.apache.commons": "${prefix}.org.apache.beam",
Review comment:
addressed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 290217)
Time Spent: 1.5h (was: 1h 20m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289077
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310713423
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+"com.google.thirdparty":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+
+// Making this self-contained, includes Calcite's dependencies
+"org.apache.commons": "${prefix}.org.apache.beam",
+"com.esri": "${prefix}.com.esri",
+"com.fasterxml": "${prefix}.com.fasterxml",
+"com.yahoo": "${prefix}.com.yahoo",
+"com.jayway": "${prefix}.com.jayway",
+"org.pentaho": "${prefix}.org.pentaho",
+"org.codehaus": "${prefix}.org.codehaus",
+"org.slf4j": "${prefix}.org.slf4j",
+"org.apache.http": "${prefix}.org.apache.http",
+"org.yaml": "${prefix}.org.yaml",
+"org.codehaus.commons.compiler.properties":
"${prefix}.org.codehaus.commons.compiler.properties"
Review comment:
redundant since `"org.codehaus": "${prefix}.org.codehaus",` covers this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 289077)
Time Spent: 1h (was: 50m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289076
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310713605
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+"com.google.thirdparty":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+
+// Making this self-contained, includes Calcite's dependencies
+"org.apache.commons": "${prefix}.org.apache.beam",
Review comment:
`org.apache.commons` -> `org.apache.beam`???
Note that it is much easier to not make a mistake like this by using a [for
loop](https://github.com/apache/beam/blob/ea081746ff1f82752d8b4ebf368ea70c2f6b5be0/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring.groovy#L96)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 289076)
Time Spent: 50m (was: 40m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289074
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310712681
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+"com.google.thirdparty":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
+
+// Making this self-contained, includes Calcite's dependencies
+"org.apache.commons": "${prefix}.org.apache.beam",
+"com.esri": "${prefix}.com.esri",
+"com.fasterxml": "${prefix}.com.fasterxml",
+"com.yahoo": "${prefix}.com.yahoo",
+"com.jayway": "${prefix}.com.jayway",
+"org.pentaho": "${prefix}.org.pentaho",
+"org.codehaus": "${prefix}.org.codehaus",
+"org.slf4j": "${prefix}.org.slf4j",
Review comment:
Consider not shading slf4j to retain logging from Calcite and any generated
code as well just declare slf4j-api as a dependency of this vendored artifact.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 289074)
Time Spent: 0.5h (was: 20m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289078
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310710894
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -29,33 +29,8 @@ applyJavaNature(
enableStrictDependencies: true,
shadowClosure: {
dependencies {
- include(dependency(library.java.guava))
- include(dependency(library.java.protobuf_java))
- include(dependency(library.java.protobuf_java_util))
- include(dependency("org.apache.calcite:.*"))
- include(dependency("org.apache.calcite.avatica:.*"))
- include(dependency("org.codehaus.janino:.*"))
+ include(dependency(library.java.vendored_calcite_1_19_0))
Review comment:
You wouldn't need to shade this dependency at all and could disable shading
within this gradle file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 289078)
Time Spent: 1h 10m (was: 1h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=289075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289075
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 05/Aug/19 17:38
Start Date: 05/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310712108
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
Review comment:
The relocation should go to `$prefix` and not
`org.apache.beam.vendor.guava`. We don't want to have a dependency between
vendored calcite and vendored guava.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 289075)
Time Spent: 40m (was: 0.5h)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[
https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=288319=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288319
]
ASF GitHub Bot logged work on BEAM-5820:
Author: ASF GitHub Bot
Created on: 02/Aug/19 23:03
Start Date: 02/Aug/19 23:03
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9189: [BEAM-5820]
[PoC] vendor calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r310321188
##
File path: vendor/calcite-1_19_0/build.gradle
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.19.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.19.0"
+def avatica_version = "1.15.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_19_0"
+
+vendorJava(
+ dependencies: [
+"org.apache.calcite:calcite-core:$calcite_version",
+"org.apache.calcite:calcite-linq4j:$calcite_version",
+"org.apache.calcite.avatica:avatica-core:$avatica_version",
+ ],
+ relocations: [
+"org.apache.calcite": "${prefix}.org.apache.calcite",
+
+// Calcite has Guava on its API surface
+"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
Review comment:
I don't understand this. Why are we moving "com.google.common" to
"com.google.thirdparty"? This does not match guava:
https://github.com/apache/beam/blob/f7cbf88f550c8918b99a13af4182d6efa07cd2b5/vendor/guava-26_0-jre/build.gradle#L29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 288319)
Time Spent: 20m (was: 10m)
> Vendor Calcite
> --
>
> Key: BEAM-5820
> URL: https://issues.apache.org/jira/browse/BEAM-5820
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Kenneth Knowles
>Assignee: Kai Jiang
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5820) Vendor Calcite
[ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=286636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286636 ] ASF GitHub Bot logged work on BEAM-5820: Author: ASF GitHub Bot Created on: 01/Aug/19 10:58 Start Date: 01/Aug/19 10:58 Worklog Time Spent: 10m Work Description: kanterov commented on issue #9189: [BEAM-5820] [PoC] vendor calcite URL: https://github.com/apache/beam/pull/9189#issuecomment-517234752 This would be great! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 286636) Time Spent: 10m Remaining Estimate: 0h > Vendor Calcite > -- > > Key: BEAM-5820 > URL: https://issues.apache.org/jira/browse/BEAM-5820 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql >Reporter: Kenneth Knowles >Assignee: Kai Jiang >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
