[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=373328=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373328 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 17/Jan/20 00:30 Start Date: 17/Jan/20 00:30 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373328) Time Spent: 1.5h (was: 1h 20m) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[
https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371194=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371194
]
ASF GitHub Bot logged work on BEAM-8739:
Author: ASF GitHub Bot
Created on: 13/Jan/20 23:27
Start Date: 13/Jan/20 23:27
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10149: [BEAM-8739]
Consistently use with Pipeline(...) syntax
URL: https://github.com/apache/beam/pull/10149#discussion_r366071940
##
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##
@@ -111,30 +111,30 @@ def filter_words(unused_x):
import apache_beam as beam
from apache_beam.options.pipeline_options import PipelineOptions
- p = beam.Pipeline(options=PipelineOptions())
- # [END pipelines_constructing_creating]
+ with beam.Pipeline(options=PipelineOptions()) as p:
+# [END pipelines_constructing_creating]
- p = TestPipeline() # Use TestPipeline for testing.
+with TestPipeline() as p: # Use TestPipeline for testing.
+ # pylint: disable=line-too-long
- # [START pipelines_constructing_reading]
- lines = p | 'ReadMyFile' >> beam.io.ReadFromText('gs://some/inputData.txt')
- # [END pipelines_constructing_reading]
+ # [START pipelines_constructing_reading]
+ lines = p | 'ReadMyFile' >>
beam.io.ReadFromText('gs://some/inputData.txt')
+ # [END pipelines_constructing_reading]
- # [START pipelines_constructing_applying]
- words = lines | beam.FlatMap(lambda x: re.findall(r'[A-Za-z\']+', x))
- reversed_words = words | ReverseWords()
- # [END pipelines_constructing_applying]
+ # [START pipelines_constructing_applying]
+ words = lines | beam.FlatMap(lambda x: re.findall(r'[A-Za-z\']+', x))
+ reversed_words = words | ReverseWords()
+ # [END pipelines_constructing_applying]
- # [START pipelines_constructing_writing]
- filtered_words = reversed_words | 'FilterWords' >> beam.Filter(filter_words)
- filtered_words | 'WriteMyFile' >> beam.io.WriteToText(
- 'gs://some/outputData.txt')
- # [END pipelines_constructing_writing]
+ # [START pipelines_constructing_writing]
+ filtered_words = reversed_words | 'FilterWords' >>
beam.Filter(filter_words)
+ filtered_words | 'WriteMyFile' >> beam.io.WriteToText(
+ 'gs://some/outputData.txt')
+ # [END pipelines_constructing_writing]
- p.visit(SnippetUtils.RenameFiles(renames))
+ p.visit(SnippetUtils.RenameFiles(renames))
- # [START pipelines_constructing_running]
- p.run()
+ # [START pipelines_constructing_running]
Review comment:
`pipelines_constructing_running` is now empty. It doesn't look like it's
being used anywhere, though, so maybe we can just remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 371194)
Time Spent: 1h 10m (was: 1h)
> Consistently use with Pipeline(...) syntax
> --
>
> Key: BEAM-8739
> URL: https://issues.apache.org/jira/browse/BEAM-8739
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I've run into a couple of tests that forgot to do p.run(). In addition, I'm
> seeing new tests written in this old style. We should consistently use the
> with syntax where possible for our examples and tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371196=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371196 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 13/Jan/20 23:27 Start Date: 13/Jan/20 23:27 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#discussion_r366081824 ## File path: sdks/python/apache_beam/runners/dataflow/template_runner_test.py ## @@ -54,19 +54,19 @@ def test_full_completion(self): dummy_dir = tempfile.mkdtemp() remote_runner = DataflowRunner() -pipeline = Pipeline(remote_runner, -options=PipelineOptions([ -'--dataflow_endpoint=ignored', -'--sdk_location=' + dummy_file_name, -'--job_name=test-job', -'--project=test-project', -'--staging_location=' + dummy_dir, -'--temp_location=/dev/null', -'--template_location=' + dummy_file_name, -'--no_auth'])) +with Pipeline(remote_runner, + options=PipelineOptions([ + '--dataflow_endpoint=ignored', + '--sdk_location=' + dummy_file_name, + '--job_name=test-job', + '--project=test-project', + '--staging_location=' + dummy_dir, + '--temp_location=/dev/null', + '--template_location=' + dummy_file_name, + '--no_auth=True'])) as pipeline: Review comment: `--no_auth=True` seems to be causing precommit to fail. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 371196) Time Spent: 1h 20m (was: 1h 10m) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[
https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371191
]
ASF GitHub Bot logged work on BEAM-8739:
Author: ASF GitHub Bot
Created on: 13/Jan/20 23:27
Start Date: 13/Jan/20 23:27
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10149: [BEAM-8739]
Consistently use with Pipeline(...) syntax
URL: https://github.com/apache/beam/pull/10149#discussion_r366075219
##
File path: sdks/python/apache_beam/io/gcp/pubsub_test.py
##
@@ -630,13 +620,13 @@ def test_write_messages_unsupported_features(self,
mock_pubsub):
p.run()
options = PipelineOptions([])
options.view_as(StandardOptions).streaming = True
-p = TestPipeline(options=options)
-_ = (p
- | Create(payloads)
- | WriteToPubSub('projects/fakeprj/topics/a_topic',
- timestamp_attribute='timestamp'))
with self.assertRaisesRegex(NotImplementedError,
r'timestamp_attribute is not supported'):
+ p = TestPipeline(options=options)
Review comment:
There's no `with` added here. (Probably these two separate pipelines should
be in two separate tests to begin with.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 371191)
Time Spent: 1h (was: 50m)
> Consistently use with Pipeline(...) syntax
> --
>
> Key: BEAM-8739
> URL: https://issues.apache.org/jira/browse/BEAM-8739
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I've run into a couple of tests that forgot to do p.run(). In addition, I'm
> seeing new tests written in this old style. We should consistently use the
> with syntax where possible for our examples and tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371193 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 13/Jan/20 23:27 Start Date: 13/Jan/20 23:27 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#discussion_r366072456 ## File path: sdks/python/apache_beam/examples/snippets/snippets.py ## @@ -111,30 +111,30 @@ def filter_words(unused_x): import apache_beam as beam from apache_beam.options.pipeline_options import PipelineOptions - p = beam.Pipeline(options=PipelineOptions()) - # [END pipelines_constructing_creating] + with beam.Pipeline(options=PipelineOptions()) as p: Review comment: This will appear as a `with` statement without a body. Maybe we should add a `pass # your code here` or something? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 371193) Time Spent: 1h 10m (was: 1h) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371192 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 13/Jan/20 23:27 Start Date: 13/Jan/20 23:27 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#discussion_r366080454 ## File path: sdks/python/apache_beam/transforms/util_test.py ## @@ -624,11 +619,9 @@ def test_in_streaming_mode(self): | WindowInto(FixedWindows(window_duration)) \ | util.GroupIntoBatches(GroupIntoBatchesTest.BATCH_SIZE) num_elements_in_batches = collection | beam.Map(len) - -result = pipeline.run() -result.wait_until_finish() assert_that(num_elements_in_batches, equal_to([expected_0, expected_1, expected_2])) +pipeline.run() Review comment: If we have to skip this test anyway, shouldn't we still add the `with`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 371192) Time Spent: 1h 10m (was: 1h) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371195=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371195 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 13/Jan/20 23:27 Start Date: 13/Jan/20 23:27 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#discussion_r366077436 ## File path: sdks/python/apache_beam/testing/test_stream_test.py ## @@ -542,4 +539,4 @@ def process(self, if __name__ == '__main__': - unittest.main() + unittest.main() Review comment: Looks like we lost a newline here, making linter unhappy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 371195) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=371133=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371133 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 13/Jan/20 21:46 Start Date: 13/Jan/20 21:46 Worklog Time Spent: 10m Work Description: robertwb commented on issue #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#issuecomment-573886596 Post-holiday ping. Rebased on latest master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 371133) Time Spent: 50m (was: 40m) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[
https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=353154=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353154
]
ASF GitHub Bot logged work on BEAM-8739:
Author: ASF GitHub Bot
Created on: 04/Dec/19 00:58
Start Date: 04/Dec/19 00:58
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #10149: [BEAM-8739]
Consistently use with Pipeline(...) syntax
URL: https://github.com/apache/beam/pull/10149#issuecomment-561426430
Just a bunch of regular expression munging...
```
import re
import sys
for file in sys.argv[1:]:
with open(file) as fin:
contents = fin.read().split('\n')
new_contents = []
in_pipeline = False
indent = None
converted_pipelines = 0
total_pipelines = 0
for ix, line in enumerate(contents):
if in_pipeline:
if line.startswith('%s%s.run()' % (indent, pipeline_var)):
converted_pipelines += 1
new_contents.append('%swith %s as %s:' % (indent, pipeline_expr,
pipeline_var))
for b in body:
new_contents.append(' ' + b if b.strip() and b[0] != '#' else b)
# if body[-1]:
# new_contents.append('\n')
in_pipeline = False
elif not line.startswith(indent) and line.strip() and not re.match('^
*#', line):
print('END', file, ix, list(filter(lambda x: x, [b.strip() for b in
body]))[-2:])
new_contents.append(pipeline_init)
new_contents.extend(body)
new_contents.append(line)
in_pipeline = False
else:
body.append(line)
else:
m = re.match(r'^( *)(\S+) = (\S*Pipeline[(].*)', line)
if m:
total_pipelines += 1
in_pipeline = True
indent = m.group(1)
pipeline_init = line
pipeline_var = m.group(2)
pipeline_expr = m.group(3)
body = []
else:
new_contents.append(line)
if in_pipeline and body:
new_contents.append(pipeline_init)
new_contents.extend(body)
if new_contents != contents:
with open(file, 'w') as fout:
fout.write('\n'.join(new_contents))
if total_pipelines:
print(file, converted_pipelines, total_pipelines)
print()
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 353154)
Time Spent: 40m (was: 0.5h)
> Consistently use with Pipeline(...) syntax
> --
>
> Key: BEAM-8739
> URL: https://issues.apache.org/jira/browse/BEAM-8739
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've run into a couple of tests that forgot to do p.run(). In addition, I'm
> seeing new tests written in this old style. We should consistently use the
> with syntax where possible for our examples and tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=353152=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353152 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 04/Dec/19 00:56 Start Date: 04/Dec/19 00:56 Worklog Time Spent: 10m Work Description: robertwb commented on issue #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#issuecomment-561425881 > Before I actually go through all of this, a few general comments: > > * I see you did a lot of these conversions automatically. I'd be curious what the scripts looked like. Yes, I'll attach the script. Nothing fancy. > * Ideally we would incorporate this into the linting process, but there's probably enough edge cases to make this infeasible. Yeah. I'm hoping that mostly people will follow conventions of the surrounding code. > * I noticed (as you pointed out on the Jira) that a few tests in here originally didn't call `pipeline.run()` at all (whether through `with` or directly). My biggest concern with this PR is that it might go the other direction and somewhere remove an existing call to `pipeline.run()`. (All other errors I could think of would have resulted in test failures, so you would have caught them already.) If something is converted to the with syntax, run() will always be called. > * If one of the goals here is to encourage everyone to use this syntax, it'd be important to cover the code snippets on the website as well. Yes. That code is harder to auto (or manually) convert given the amount of mocking and ordering in which things are included/excluded. Taking a pass at the examples and snippets is certainly something that should be done and I'll keep this ticket open until then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 353152) Time Spent: 0.5h (was: 20m) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=347751=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347751 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 21/Nov/19 22:33 Start Date: 21/Nov/19 22:33 Worklog Time Spent: 10m Work Description: robertwb commented on issue #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149#issuecomment-557302872 R: @ibzib lint and tests are now all happy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 347751) Time Spent: 20m (was: 10m) > Consistently use with Pipeline(...) syntax > -- > > Key: BEAM-8739 > URL: https://issues.apache.org/jira/browse/BEAM-8739 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Robert Bradshaw >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > I've run into a couple of tests that forgot to do p.run(). In addition, I'm > seeing new tests written in this old style. We should consistently use the > with syntax where possible for our examples and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8739) Consistently use with Pipeline(...) syntax
[ https://issues.apache.org/jira/browse/BEAM-8739?focusedWorklogId=345726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345726 ] ASF GitHub Bot logged work on BEAM-8739: Author: ASF GitHub Bot Created on: 19/Nov/19 00:51 Start Date: 19/Nov/19 00:51 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #10149: [BEAM-8739] Consistently use with Pipeline(...) syntax URL: https://github.com/apache/beam/pull/10149 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[