[jira] [Work logged] (BEAM-8780) Improve publish_docker_images.sh
[ https://issues.apache.org/jira/browse/BEAM-8780?focusedWorklogId=367787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367787 ] ASF GitHub Bot logged work on BEAM-8780: Author: ASF GitHub Bot Created on: 07/Jan/20 21:38 Start Date: 07/Jan/20 21:38 Worklog Time Spent: 10m Work Description: Ardagan commented on pull request #10512: [BEAM-8780]Improve docker container release script URL: https://github.com/apache/beam/pull/10512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367787) Time Spent: 50m (was: 40m) > Improve publish_docker_images.sh > > > Key: BEAM-8780 > URL: https://issues.apache.org/jira/browse/BEAM-8780 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Mark Liu >Assignee: Hannah Jiang >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Few improvement places: > * The script builds new image for publishing. Better to reuse existing > staged rc images. > * This script ask input that’s unrelated to publish (i.e rc #, gpg key...) > * This script first run unrelated staging steps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8780) Improve publish_docker_images.sh
[ https://issues.apache.org/jira/browse/BEAM-8780?focusedWorklogId=367786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367786 ] ASF GitHub Bot logged work on BEAM-8780: Author: ASF GitHub Bot Created on: 07/Jan/20 21:37 Start Date: 07/Jan/20 21:37 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10512: [BEAM-8780]Improve docker container release script URL: https://github.com/apache/beam/pull/10512#issuecomment-571784528 The PR is ready to be merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367786) Time Spent: 40m (was: 0.5h) > Improve publish_docker_images.sh > > > Key: BEAM-8780 > URL: https://issues.apache.org/jira/browse/BEAM-8780 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Mark Liu >Assignee: Hannah Jiang >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Few improvement places: > * The script builds new image for publishing. Better to reuse existing > staged rc images. > * This script ask input that’s unrelated to publish (i.e rc #, gpg key...) > * This script first run unrelated staging steps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8780) Improve publish_docker_images.sh
[ https://issues.apache.org/jira/browse/BEAM-8780?focusedWorklogId=367784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367784 ] ASF GitHub Bot logged work on BEAM-8780: Author: ASF GitHub Bot Created on: 07/Jan/20 21:35 Start Date: 07/Jan/20 21:35 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10512: [BEAM-8780]Improve docker container release script URL: https://github.com/apache/beam/pull/10512#issuecomment-571783984 > LGTM overall. > There's also a way to do this without pulling image. See https://issues.apache.org/jira/browse/BEAM-8780 > Would be great if we can utilize that one. Thanks for reviewing it. I investigate both options mentioned at BEAM-8780. The option with updating manifest is not recommended to use in production. (https://docs.docker.com/engine/reference/commandline/manifest/). The second option with `docker build` creates new images, so that is not an option here. After all, I think pull, tag and push process is the most stable and easy to understand for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367784) Time Spent: 0.5h (was: 20m) > Improve publish_docker_images.sh > > > Key: BEAM-8780 > URL: https://issues.apache.org/jira/browse/BEAM-8780 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Mark Liu >Assignee: Hannah Jiang >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Few improvement places: > * The script builds new image for publishing. Better to reuse existing > staged rc images. > * This script ask input that’s unrelated to publish (i.e rc #, gpg key...) > * This script first run unrelated staging steps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8780) Improve publish_docker_images.sh
[ https://issues.apache.org/jira/browse/BEAM-8780?focusedWorklogId=367703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367703 ] ASF GitHub Bot logged work on BEAM-8780: Author: ASF GitHub Bot Created on: 07/Jan/20 19:42 Start Date: 07/Jan/20 19:42 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10512: [BEAM-8780]Improve docker container release script URL: https://github.com/apache/beam/pull/10512#issuecomment-571740512 R: @markflyhigh Cc: @kyle-winkelman do we need to do the same thing for Flink images? Cc: @Ardagan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367703) Time Spent: 20m (was: 10m) > Improve publish_docker_images.sh > > > Key: BEAM-8780 > URL: https://issues.apache.org/jira/browse/BEAM-8780 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Mark Liu >Assignee: Hannah Jiang >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Few improvement places: > * The script builds new image for publishing. Better to reuse existing > staged rc images. > * This script ask input that’s unrelated to publish (i.e rc #, gpg key...) > * This script first run unrelated staging steps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8780) Improve publish_docker_images.sh
[ https://issues.apache.org/jira/browse/BEAM-8780?focusedWorklogId=367140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367140 ] ASF GitHub Bot logged work on BEAM-8780: Author: ASF GitHub Bot Created on: 07/Jan/20 01:10 Start Date: 07/Jan/20 01:10 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10512: [WIP][BEAM-8780]Improve container release script URL: https://github.com/apache/beam/pull/10512 Improve docker container script: reuse verified rc images instead of recreating images. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[