[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=382747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382747 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 06/Feb/20 06:12 Start Date: 06/Feb/20 06:12 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-582753782 Thank you! Happy Happy :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382747) Time Spent: 5h (was: 4h 50m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 5h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=382667=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382667 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 06/Feb/20 01:38 Start Date: 06/Feb/20 01:38 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on pull request #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382667) Time Spent: 4h 50m (was: 4h 40m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=382666=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382666 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 06/Feb/20 01:38 Start Date: 06/Feb/20 01:38 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-582695162 Sorry for the delay, I was out of the office for a few days. Merging now! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382666) Time Spent: 4h 40m (was: 4.5h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=381059=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381059 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 03/Feb/20 16:13 Start Date: 03/Feb/20 16:13 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-581491165 As promised, schema aware topics adding: @iemejia @aromanenko-dev (this one can be merged) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381059) Time Spent: 4.5h (was: 4h 20m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380736 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 03/Feb/20 07:01 Start Date: 03/Feb/20 07:01 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-581267503 @TheNeuralBit or @reuvenlax as this is approved can some this be merged. I can't do it as I'm only a humble contributor. I like to rebase my other work then on master. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380736) Time Spent: 4h 20m (was: 4h 10m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380323=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380323 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 01/Feb/20 08:07 Start Date: 01/Feb/20 08:07 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-581006289 @TheNeuralBit all green, v1 added, rebased against master and squached. Ready to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380323) Time Spent: 4h 10m (was: 4h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380207 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 21:01 Start Date: 31/Jan/20 21:01 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580909721 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380207) Time Spent: 4h (was: 3h 50m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 4h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380206 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 21:01 Start Date: 31/Jan/20 21:01 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580909218 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380206) Time Spent: 3h 50m (was: 3h 40m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380204=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380204 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 21:00 Start Date: 31/Jan/20 21:00 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580844716 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380204) Time Spent: 3.5h (was: 3h 20m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380205 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 21:00 Start Date: 31/Jan/20 21:00 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580836423 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380205) Time Spent: 3h 40m (was: 3.5h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380203 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 20:59 Start Date: 31/Jan/20 20:59 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580909218 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380203) Time Spent: 3h 20m (was: 3h 10m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380115 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 18:07 Start Date: 31/Jan/20 18:07 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580844575 I shouldn't have triggered Run Java_Examples_Dataflow PreCommit it was green. Grumple. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380115) Time Spent: 3h (was: 2h 50m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380116 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 18:07 Start Date: 31/Jan/20 18:07 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580844716 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380116) Time Spent: 3h 10m (was: 3h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.20.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380107 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 17:44 Start Date: 31/Jan/20 17:44 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580836423 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380107) Time Spent: 2h 50m (was: 2h 40m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380106 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 17:44 Start Date: 31/Jan/20 17:44 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580833223 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380106) Time Spent: 2h 40m (was: 2.5h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380104 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 17:38 Start Date: 31/Jan/20 17:38 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580833223 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380104) Time Spent: 2.5h (was: 2h 20m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=380067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380067 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Jan/20 16:03 Start Date: 31/Jan/20 16:03 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580793619 I've rebased and squashed. Hopefully this avoid the Jenkins trouble... Fingers crossed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380067) Time Spent: 2h 20m (was: 2h 10m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=379475=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379475 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 30/Jan/20 16:48 Start Date: 30/Jan/20 16:48 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580346401 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379475) Time Spent: 2h 10m (was: 2h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=379462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379462 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 30/Jan/20 16:25 Start Date: 30/Jan/20 16:25 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580335482 > @alexvanboxel I can go ahead and merge if you just add a `v1` to the URNs Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379462) Time Spent: 2h (was: 1h 50m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=379454=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379454 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 30/Jan/20 16:19 Start Date: 30/Jan/20 16:19 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-580332263 @alexvanboxel I can go ahead and merge if you just add a `v1` to the URNs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379454) Time Spent: 1h 50m (was: 1h 40m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[
https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=378538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378538
]
ASF GitHub Bot logged work on BEAM-9037:
Author: ASF GitHub Bot
Created on: 28/Jan/20 22:37
Start Date: 28/Jan/20 22:37
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10486:
[BEAM-9037] Instant and duration as logical type
URL: https://github.com/apache/beam/pull/10486#discussion_r366529282
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/NanosDuration.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas.logicaltypes;
+
+import java.time.Duration;
+import org.apache.beam.sdk.values.Row;
+
+/** A duration represented in nanoseconds. */
+public class NanosDuration extends NanosType {
+ public static final String IDENTIFIER = "beam:logical_type:nanos_duration";
Review comment:
I think we should version these, can you add a v1 to this and nanos_instant?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 378538)
Time Spent: 1h 40m (was: 1.5h)
> Instant and duration as logical type
> -
>
> Key: BEAM-9037
> URL: https://issues.apache.org/jira/browse/BEAM-9037
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
>Reporter: Alex Van Boxel
>Assignee: Alex Van Boxel
>Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The proto schema includes Timestamp and Duration with nano precision. The
> logical types should be promoted to the core logical types, so they can be
> handled on various IO's as standard mandatory conversions.
> This means that the logical type should use the proto specific Timestamp and
> Duration but the java 8 Instant and Duration.
> See discussion in the design document:
> [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[
https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=377416=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377416
]
ASF GitHub Bot logged work on BEAM-9037:
Author: ASF GitHub Bot
Created on: 26/Jan/20 19:06
Start Date: 26/Jan/20 19:06
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10486:
[BEAM-9037] Instant and duration as logical type
URL: https://github.com/apache/beam/pull/10486#discussion_r371022191
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/NanosType.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas.logicaltypes;
+
+import java.util.UUID;
+import org.apache.beam.sdk.schemas.Schema;
+import org.apache.beam.sdk.values.Row;
+
+/** Base class for types representing timestamps or durations as nanoseconds.
*/
+abstract class NanosType implements Schema.LogicalType {
+ private final String identifier;
+
+ protected static final Schema SCHEMA;
+
+ static {
+Schema schema =
Schema.builder().addInt64Field("seconds").addInt32Field("nanos").build();
+schema.setUUID(UUID.fromString("dc5915f1-6db8-3134-9444-4980fb088e92"));
+SCHEMA = schema;
Review comment:
Switched to instance variables. Proto conversion used by ByteBuddy still
uses a static version of the schema for performance reasons.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 377416)
Time Spent: 1.5h (was: 1h 20m)
> Instant and duration as logical type
> -
>
> Key: BEAM-9037
> URL: https://issues.apache.org/jira/browse/BEAM-9037
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
>Reporter: Alex Van Boxel
>Assignee: Alex Van Boxel
>Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The proto schema includes Timestamp and Duration with nano precision. The
> logical types should be promoted to the core logical types, so they can be
> handled on various IO's as standard mandatory conversions.
> This means that the logical type should use the proto specific Timestamp and
> Duration but the java 8 Instant and Duration.
> See discussion in the design document:
> [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=377407=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377407 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 26/Jan/20 17:37 Start Date: 26/Jan/20 17:37 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-578524681 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377407) Time Spent: 1h 20m (was: 1h 10m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=376985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376985 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 24/Jan/20 19:04 Start Date: 24/Jan/20 19:04 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-578259007 I'm +1 for instant and duration as logical type. I think we should do the same for millis_instant, but that will require a lot of other changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 376985) Time Spent: 1h 10m (was: 1h) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=376982=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376982 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 24/Jan/20 19:01 Start Date: 24/Jan/20 19:01 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-578257988 > @reuvenlax FYI the static schema stuff is a backport of #10569 - we were discussing alternatives over there. Let's first agree on: is replacing the proto specific into these standard logical types. Then I want to put in the work of fixing this. I think we indeed need instance variables. But the ByteBuffy coding was using the static SCHEMA as well... so it's not that easy. So question 1) is this a good idea: Instant and duration as logical type? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 376982) Time Spent: 1h (was: 50m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 1h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=376981=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376981 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 24/Jan/20 18:56 Start Date: 24/Jan/20 18:56 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-578255921 @reuvenlax FYI the static schema stuff is a backport of #10569 - we were discussing alternatives over there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 376981) Time Spent: 50m (was: 40m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[
https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=376643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376643
]
ASF GitHub Bot logged work on BEAM-9037:
Author: ASF GitHub Bot
Created on: 23/Jan/20 23:20
Start Date: 23/Jan/20 23:20
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10486: [BEAM-9037]
Instant and duration as logical type
URL: https://github.com/apache/beam/pull/10486#discussion_r370406145
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/NanosType.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas.logicaltypes;
+
+import java.util.UUID;
+import org.apache.beam.sdk.schemas.Schema;
+import org.apache.beam.sdk.values.Row;
+
+/** Base class for types representing timestamps or durations as nanoseconds.
*/
+abstract class NanosType implements Schema.LogicalType {
+ private final String identifier;
+
+ protected static final Schema SCHEMA;
+
+ static {
+Schema schema =
Schema.builder().addInt64Field("seconds").addInt32Field("nanos").build();
+schema.setUUID(UUID.fromString("dc5915f1-6db8-3134-9444-4980fb088e92"));
+SCHEMA = schema;
Review comment:
this is a bit ugly - should we instead just make it an instance variable?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 376643)
Time Spent: 40m (was: 0.5h)
> Instant and duration as logical type
> -
>
> Key: BEAM-9037
> URL: https://issues.apache.org/jira/browse/BEAM-9037
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
>Reporter: Alex Van Boxel
>Assignee: Alex Van Boxel
>Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The proto schema includes Timestamp and Duration with nano precision. The
> logical types should be promoted to the core logical types, so they can be
> handled on various IO's as standard mandatory conversions.
> This means that the logical type should use the proto specific Timestamp and
> Duration but the java 8 Instant and Duration.
> See discussion in the design document:
> [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=365141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365141 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 01/Jan/20 09:50 Start Date: 01/Jan/20 09:50 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-569953631 R: @TheNeuralBit R: @reuvenlax this PR promotes the Timestamp+Duration to NanosInstant and NanosDuration. Please see the PR for more information and reference to the design document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365141) Time Spent: 0.5h (was: 20m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=365024=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365024 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Dec/19 16:23 Start Date: 31/Dec/19 16:23 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-569953631 @TheNeuralBit @reuvenlax this PR promotes the Timestamp+Duration to NanosInstant and NanosDuration. Please see the PR for more information and reference to the design document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365024) Time Spent: 20m (was: 10m) > Instant and duration as logical type > - > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core >Reporter: Alex Van Boxel >Assignee: Alex Van Boxel >Priority: Major > Fix For: 2.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9037) Instant and duration as logical type
[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=365001=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365001 ] ASF GitHub Bot logged work on BEAM-9037: Author: ASF GitHub Bot Created on: 31/Dec/19 14:50 Start Date: 31/Dec/19 14:50 Worklog Time Spent: 10m Work Description: alexvanboxel commented on pull request #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486 The proto schema includes Timestamp and Duration with nano precision. The logical types should be promoted to the core logical types, so they can be handled on various IO's as standard mandatory conversions. This means that the logical type should use the proto specific Timestamp and Duration but the java 8 Instant and Duration. Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [