[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[
https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367658
]
ASF GitHub Bot logged work on BEAM-9058:
Author: ASF GitHub Bot
Created on: 07/Jan/20 18:52
Start Date: 07/Jan/20 18:52
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10510: [BEAM-9058]
Reenable line-too-long linter check.
URL: https://github.com/apache/beam/pull/10510
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367658)
Time Spent: 1h 10m (was: 1h)
> Line-too-long Python lint checks are no longer working.
> ---
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Valentyn Tymofieiev
>Assignee: Chad Dombrova
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are
> the reasons to treat type annotations differently than other parts of Python
> code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> * Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long
> (106/80) (line-too-long)
> * Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80)
> (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80)
> (line-too-long)
> * Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long
> (114/80) (line-too-long)
> * Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80)
> (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80)
> (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80)
> (line-too-long)
> * Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[
https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367635
]
ASF GitHub Bot logged work on BEAM-9058:
Author: ASF GitHub Bot
Created on: 07/Jan/20 18:20
Start Date: 07/Jan/20 18:20
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #10510: [BEAM-9058]
Reenable line-too-long linter check.
URL: https://github.com/apache/beam/pull/10510#issuecomment-571708597
Run PythonLint PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367635)
Time Spent: 1h (was: 50m)
> Line-too-long Python lint checks are no longer working.
> ---
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Valentyn Tymofieiev
>Assignee: Chad Dombrova
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are
> the reasons to treat type annotations differently than other parts of Python
> code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> * Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long
> (106/80) (line-too-long)
> * Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80)
> (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80)
> (line-too-long)
> * Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long
> (114/80) (line-too-long)
> * Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80)
> (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80)
> (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80)
> (line-too-long)
> * Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[
https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367529
]
ASF GitHub Bot logged work on BEAM-9058:
Author: ASF GitHub Bot
Created on: 07/Jan/20 16:06
Start Date: 07/Jan/20 16:06
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #10510: [BEAM-9058]
Reenable line-too-long linter check.
URL: https://github.com/apache/beam/pull/10510#issuecomment-571652522
Run Portable_Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367529)
Time Spent: 50m (was: 40m)
> Line-too-long Python lint checks are no longer working.
> ---
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Valentyn Tymofieiev
>Assignee: Chad Dombrova
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are
> the reasons to treat type annotations differently than other parts of Python
> code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> * Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long
> (106/80) (line-too-long)
> * Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80)
> (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80)
> (line-too-long)
> * Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long
> (114/80) (line-too-long)
> * Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80)
> (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80)
> (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80)
> (line-too-long)
> * Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[
https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367102
]
ASF GitHub Bot logged work on BEAM-9058:
Author: ASF GitHub Bot
Created on: 06/Jan/20 23:39
Start Date: 06/Jan/20 23:39
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #10510: [BEAM-9058]
Reenable line-too-long linter check.
URL: https://github.com/apache/beam/pull/10510#issuecomment-571363535
@chadrik np. Please LGTM once you think this is good to go :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367102)
Time Spent: 40m (was: 0.5h)
> Line-too-long Python lint checks are no longer working.
> ---
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Valentyn Tymofieiev
>Assignee: Chad Dombrova
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are
> the reasons to treat type annotations differently than other parts of Python
> code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> * Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long
> (106/80) (line-too-long)
> * Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80)
> (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80)
> (line-too-long)
> * Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long
> (114/80) (line-too-long)
> * Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80)
> (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80)
> (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80)
> (line-too-long)
> * Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[
https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367098
]
ASF GitHub Bot logged work on BEAM-9058:
Author: ASF GitHub Bot
Created on: 06/Jan/20 23:35
Start Date: 06/Jan/20 23:35
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #10510: [BEAM-9058] Reenable
line-too-long linter check.
URL: https://github.com/apache/beam/pull/10510#issuecomment-571362692
d'oh! sorry about that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367098)
Time Spent: 0.5h (was: 20m)
> Line-too-long Python lint checks are no longer working.
> ---
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
>Reporter: Valentyn Tymofieiev
>Assignee: Chad Dombrova
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are
> the reasons to treat type annotations differently than other parts of Python
> code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> * Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long
> (106/80) (line-too-long)
> * Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80)
> (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80)
> (line-too-long)
> * Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long
> (114/80) (line-too-long)
> * Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80)
> (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80)
> (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80)
> (line-too-long)
> * Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[ https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367097 ] ASF GitHub Bot logged work on BEAM-9058: Author: ASF GitHub Bot Created on: 06/Jan/20 23:28 Start Date: 06/Jan/20 23:28 Worklog Time Spent: 10m Work Description: tvalentyn commented on issue #10510: [BEAM-9058] Reenable line-too-long linter check. URL: https://github.com/apache/beam/pull/10510#issuecomment-571361008 R: @chadrik @udim This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367097) Time Spent: 20m (was: 10m) > Line-too-long Python lint checks are no longer working. > --- > > Key: BEAM-9058 > URL: https://issues.apache.org/jira/browse/BEAM-9058 > Project: Beam > Issue Type: Bug > Components: sdk-py-core >Reporter: Valentyn Tymofieiev >Assignee: Chad Dombrova >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Without getting into a question whether 80 is a reasonable limit, what are > the reasons to treat type annotations differently than other parts of Python > code (including comments), which have a 80 character limit? > > Places that need to be fixed (PR coming): > ``` > > Task :sdks:python:test-suites:tox:py37:lintPy37 > * Module apache_beam.testing.test_stream_it_test > apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long > (106/80) (line-too-long) > * Module apache_beam.io.filesystems > apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80) > (line-too-long) > apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80) > (line-too-long) > * Module apache_beam.runners.portability.fn_api_runner > apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long > (114/80) (line-too-long) > * Module apache_beam.transforms.core > apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80) > (line-too-long) > apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80) > (line-too-long) > apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80) > (line-too-long) > * Module setup > setup.py:141:0: C0301: Line too long (81/80) (line-too-long) > > ``` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9058) Line-too-long Python lint checks are no longer working.
[ https://issues.apache.org/jira/browse/BEAM-9058?focusedWorklogId=367096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367096 ] ASF GitHub Bot logged work on BEAM-9058: Author: ASF GitHub Bot Created on: 06/Jan/20 23:28 Start Date: 06/Jan/20 23:28 Worklog Time Spent: 10m Work Description: tvalentyn commented on pull request #10510: [BEAM-9058] Reenable line-too-long linter check. URL: https://github.com/apache/beam/pull/10510 This PR fixes the regular expression to exclude type annotations from linter line-too-long check. We may also want to reconsider whether type annotations should be excluded from 80 character limit, see BEAM-9058. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)[