[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380208=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380208 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 21:12 Start Date: 31/Jan/20 21:12 Worklog Time Spent: 10m Work Description: ianlancetaylor commented on issue #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737#issuecomment-580913576 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380208) Time Spent: 1h 10m (was: 1h) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380196=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380196 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 20:24 Start Date: 31/Jan/20 20:24 Worklog Time Spent: 10m Work Description: lostluck commented on pull request #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380196) Time Spent: 1h (was: 50m) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380192 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 19:47 Start Date: 31/Jan/20 19:47 Worklog Time Spent: 10m Work Description: lostluck commented on issue #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737#issuecomment-580882040 Run Go Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380192) Time Spent: 50m (was: 40m) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380191 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 19:44 Start Date: 31/Jan/20 19:44 Worklog Time Spent: 10m Work Description: lostluck commented on issue #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737#issuecomment-580882040 Run Go Postcommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380191) Time Spent: 40m (was: 0.5h) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380190=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380190 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 19:44 Start Date: 31/Jan/20 19:44 Worklog Time Spent: 10m Work Description: lostluck commented on issue #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737#issuecomment-580881977 Run Go Precommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380190) Time Spent: 0.5h (was: 20m) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380188 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 19:37 Start Date: 31/Jan/20 19:37 Worklog Time Spent: 10m Work Description: ianlancetaylor commented on pull request #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737 Use symbol tables, rather than DWARF, to map between symbol names and address. This will work when the DWARF information is stripped. It should also be more efficient, as it does not require parsing the DWARF information. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [![Build
[jira] [Work logged] (BEAM-9233) Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w
[ https://issues.apache.org/jira/browse/BEAM-9233?focusedWorklogId=380189=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380189 ] ASF GitHub Bot logged work on BEAM-9233: Author: ASF GitHub Bot Created on: 31/Jan/20 19:37 Start Date: 31/Jan/20 19:37 Worklog Time Spent: 10m Work Description: ianlancetaylor commented on issue #10737: [BEAM-9233] Support -buildmode=pie -ldflags=-w with unregistered Go functions URL: https://github.com/apache/beam/pull/10737#issuecomment-580879513 R: @lostluck This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380189) Time Spent: 20m (was: 10m) > Go: unregistered Go functions fail when using -buildmode=pie -ldflags=-w > > > Key: BEAM-9233 > URL: https://issues.apache.org/jira/browse/BEAM-9233 > Project: Beam > Issue Type: Bug > Components: sdk-go >Affects Versions: 2.18.0 > Environment: GNU/Linux >Reporter: Ian Lance Taylor >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > If a Go program is built with -buildmode=pie -ldflags=-w, the code that > transfers an unregistered function fails. It tries to look up the symbol in > the DWARF debug info, but that info has been stripped because of the -w flag. > This causes a program crash when calling the function. > I have a patch for this problem that I will send shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005)