[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=384612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384612 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 10/Feb/20 18:06 Start Date: 10/Feb/20 18:06 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-584254644 Looks like main Java PreCommit passed. I'll go ahead and merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384612) Time Spent: 1h 40m (was: 1.5h) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1h 40m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=384613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384613 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 10/Feb/20 18:06 Start Date: 10/Feb/20 18:06 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384613) Time Spent: 1h 50m (was: 1h 40m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1h 50m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=384611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384611 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 10/Feb/20 18:05 Start Date: 10/Feb/20 18:05 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-584254012 Run Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384611) Time Spent: 1.5h (was: 1h 20m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1.5h > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=384322=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384322 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 10/Feb/20 10:24 Start Date: 10/Feb/20 10:24 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583419430 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384322) Time Spent: 1h 20m (was: 1h 10m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1h 20m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=384321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384321 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 10/Feb/20 10:24 Start Date: 10/Feb/20 10:24 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583443870 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384321) Time Spent: 1h 10m (was: 1h) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1h 10m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383785=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383785 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 18:44 Start Date: 07/Feb/20 18:44 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583549180 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383785) Time Spent: 1h (was: 50m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 1h > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383646 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 15:11 Start Date: 07/Feb/20 15:11 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583443870 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383646) Time Spent: 50m (was: 40m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 50m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383619=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383619 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 14:44 Start Date: 07/Feb/20 14:44 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583419430 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383619) Time Spent: 40m (was: 0.5h) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 40m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383615 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 14:35 Start Date: 07/Feb/20 14:35 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583409088 > Can you please create a JIRA and mention in the CL description ? Done: https://issues.apache.org/jira/browse/BEAM-9268 > Retest this please I did try with the trigger-phrase - as you did - but it has not yet been run... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383615) Time Spent: 0.5h (was: 20m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 0.5h > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383613 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 14:27 Start Date: 07/Feb/20 14:27 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-578741802 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383613) Time Spent: 20m (was: 10m) > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 20m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9268) SpannerIO: Better documentation and warning about creating tables in the pipeline
[ https://issues.apache.org/jira/browse/BEAM-9268?focusedWorklogId=383607=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383607 ] ASF GitHub Bot logged work on BEAM-9268: Author: ASF GitHub Bot Created on: 07/Feb/20 14:22 Start Date: 07/Feb/20 14:22 Worklog Time Spent: 10m Work Description: nielm commented on issue #10690: [BEAM-9268] SpannerIO: Add more documentation and warnings for unknown tables. URL: https://github.com/apache/beam/pull/10690#issuecomment-583409088 > Can you please create a JIRA and mention in the CL description ? Done: https://issues.apache.org/jira/browse/BEAM-9268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383607) Remaining Estimate: 0h Time Spent: 10m > SpannerIO: Better documentation and warning about creating tables in the > pipeline > - > > Key: BEAM-9268 > URL: https://issues.apache.org/jira/browse/BEAM-9268 > Project: Beam > Issue Type: Improvement > Components: io-go-gcp >Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0 >Reporter: Niel Markwick >Assignee: Niel Markwick >Priority: Major > Labels: google-cloud-spanner, perfomance > Time Spent: 10m > Remaining Estimate: 0h > > The javadoc for SpannerIO.Write mentions in passing that the transform needs > to know the DB schema for optimal performance. If the schema is created > within the pipeline, then there is a race between the schema being created > and SpannerIO reading it, leading to a potential performance penalty if > SpannerIO does not know about the existence of some tables. > > Javadoc needs to make this clearer and more explicit, and point the user at > the Write.withSchemaReadySignal(). > > Pipeline needs to raise (rate limited) warnings if it sees writes being made > to tables it does not know about (warnings can refer back to javadocs) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
