[jira] [Work logged] (BEAM-9500) Refactor load tests
[
https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=438518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438518
]
ASF GitHub Bot logged work on BEAM-9500:
Author: ASF GitHub Bot
Created on: 28/May/20 23:45
Start Date: 28/May/20 23:45
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #11181:
URL: https://github.com/apache/beam/pull/11181#issuecomment-635674912
@piotr-szuberski - what is the next step for this PR? Is it still active?
Should we close it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 438518)
Time Spent: 50m (was: 40m)
> Refactor load tests
> ---
>
> Key: BEAM-9500
> URL: https://issues.apache.org/jira/browse/BEAM-9500
> Project: Beam
> Issue Type: Improvement
> Components: testing
>Reporter: Michał Walenia
>Assignee: Piotr Szuberski
>Priority: P3
> Time Spent: 50m
> Remaining Estimate: 0h
>
> `make {{LoadTest}} parameterized instead of a base class.
> Each subclass of {{LoadTest}} is really just the main {{loadTest}} function
> and really that function is about the same as writing a {{PTransform}}. If
> you eliminate subclassing you can have {{LoadTest}} own the pipeline setup
> with so it will never be possible to forget or mess up
> {{readSourceFromOptions}} and {{ParDo.of(runtimeMonitor)}}. It will be less
> repeat boilerplate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9500) Refactor load tests
[
https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=435062=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435062
]
ASF GitHub Bot logged work on BEAM-9500:
Author: ASF GitHub Bot
Created on: 19/May/20 16:51
Start Date: 19/May/20 16:51
Worklog Time Spent: 10m
Work Description: stale[bot] commented on pull request #11181:
URL: https://github.com/apache/beam/pull/11181#issuecomment-630946506
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull request requires a review, please simply write any
comment. If closed, you can revive the PR at any time and @mention a reviewer
or discuss it on the d...@beam.apache.org list. Thank you for your
contributions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 435062)
Time Spent: 40m (was: 0.5h)
> Refactor load tests
> ---
>
> Key: BEAM-9500
> URL: https://issues.apache.org/jira/browse/BEAM-9500
> Project: Beam
> Issue Type: Improvement
> Components: testing
>Reporter: Michał Walenia
>Assignee: Piotr Szuberski
>Priority: P3
> Time Spent: 40m
> Remaining Estimate: 0h
>
> `make {{LoadTest}} parameterized instead of a base class.
> Each subclass of {{LoadTest}} is really just the main {{loadTest}} function
> and really that function is about the same as writing a {{PTransform}}. If
> you eliminate subclassing you can have {{LoadTest}} own the pipeline setup
> with so it will never be possible to forget or mess up
> {{readSourceFromOptions}} and {{ParDo.of(runtimeMonitor)}}. It will be less
> repeat boilerplate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9500) Refactor load tests
[
https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=407096=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407096
]
ASF GitHub Bot logged work on BEAM-9500:
Author: ASF GitHub Bot
Created on: 20/Mar/20 15:33
Start Date: 20/Mar/20 15:33
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on issue #11181: [BEAM-9500]
Refactor load tests
URL: https://github.com/apache/beam/pull/11181#issuecomment-601761814
I think there is a lot more to do with the part "make LoadTest parameterized
instead of a base class."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 407096)
Time Spent: 0.5h (was: 20m)
> Refactor load tests
> ---
>
> Key: BEAM-9500
> URL: https://issues.apache.org/jira/browse/BEAM-9500
> Project: Beam
> Issue Type: Improvement
> Components: testing
>Reporter: Michał Walenia
>Assignee: Piotr Szuberski
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> `make {{LoadTest}} parameterized instead of a base class.
> Each subclass of {{LoadTest}} is really just the main {{loadTest}} function
> and really that function is about the same as writing a {{PTransform}}. If
> you eliminate subclassing you can have {{LoadTest}} own the pipeline setup
> with so it will never be possible to forget or mess up
> {{readSourceFromOptions}} and {{ParDo.of(runtimeMonitor)}}. It will be less
> repeat boilerplate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9500) Refactor load tests
[
https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=407095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407095
]
ASF GitHub Bot logged work on BEAM-9500:
Author: ASF GitHub Bot
Created on: 20/Mar/20 15:32
Start Date: 20/Mar/20 15:32
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on issue #11181: [BEAM-9500]
Refactor load tests
URL: https://github.com/apache/beam/pull/11181#issuecomment-601761169
@mwalenia
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 407095)
Time Spent: 20m (was: 10m)
> Refactor load tests
> ---
>
> Key: BEAM-9500
> URL: https://issues.apache.org/jira/browse/BEAM-9500
> Project: Beam
> Issue Type: Improvement
> Components: testing
>Reporter: Michał Walenia
>Assignee: Piotr Szuberski
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> `make {{LoadTest}} parameterized instead of a base class.
> Each subclass of {{LoadTest}} is really just the main {{loadTest}} function
> and really that function is about the same as writing a {{PTransform}}. If
> you eliminate subclassing you can have {{LoadTest}} own the pipeline setup
> with so it will never be possible to forget or mess up
> {{readSourceFromOptions}} and {{ParDo.of(runtimeMonitor)}}. It will be less
> repeat boilerplate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9500) Refactor load tests
[ https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=407094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407094 ] ASF GitHub Bot logged work on BEAM-9500: Author: ASF GitHub Bot Created on: 20/Mar/20 15:32 Start Date: 20/Mar/20 15:32 Worklog Time Spent: 10m Work Description: piotr-szuberski commented on pull request #11181: [BEAM-9500] Refactor load tests URL: https://github.com/apache/beam/pull/11181 Changed the input to be initialized in the base class instead of the subclasses. Minor: - Replaced creating new TimeMonitors with the one from the superclass - Added type to List at LoadTest:104 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[